[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/554#issuecomment-134925991 LGTM, merging. Someone needs to add the unit test, later. I'm trying to build my skills around vmware related codebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/554#issuecomment-129227018 Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/554#issuecomment-125155019 +1 for @DaanHoogland's comments: please add unit tests to cover the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/554#issuecomment-124869104 please add (unit) tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/554#issuecomment-124468346 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/554#issuecomment-124474599 Looks like all checks are good and there are 2 LGTM too. Should we merge this branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/554#issuecomment-122200420 LGTM. Device id 7 on virtual SCSI (can be of any sub type : LsiLogic, LsiSAS, BusLogic, Paravirtual) controller is reserved for controller itself, rest all virtual nodes could be used for virtual disks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/554 CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 ⦠â¦instance. During disk attach, while trying to obtain the controller key for SCSI controller, look for device with the generic SCSI controller type i.e. VirtualSCSIController. While trying to obtain the SCSI id to attach a disk to, CS should ignore the reserved SCSI id 7. But this is not being honored in case of VMs with SCSI controller of type 'VirtualLsiLogicSASController'. And so in case of Windows 2012 R2 VMs, CS chooses to attach the 7th disk on the reserved SCSI id and this fails on vCenter. You can merge this pull request into a Git repository by running: $ git pull https://github.com/likitha/cloudstack CLOUDSTACK-8610 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/554.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #554 commit cbfcf7cccf75c54decdcfa0c1185c42cb69d0a7a Author: Likitha Shetty likitha.she...@citrix.com Date: 2015-06-01T08:53:56Z CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 instance. During disk attach, while trying to obtain the controller key for SCSI controller, look for device with the generic SCSI controller type i.e. VirtualSCSIController. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
