[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/631 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...
LGTM!!
On Mon, Aug 3, 2015 at 11:46 AM, pritisarap12 wrote:
> Github user pritisarap12 commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/631#discussion_r36058447
>
> --- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
> @@ -0,0 +1,209 @@
> +# Licensed to the Apache Software Foundation (ASF) under one
> +# or more contributor license agreements. See the NOTICE file
> +# distributed with this work for additional information
> +# regarding copyright ownership. The ASF licenses this file
> +# to you under the Apache License, Version 2.0 (the
> +# "License"); you may not use this file except in compliance
> +# with the License. You may obtain a copy of the License at
> +#
> +# http://www.apache.org/licenses/LICENSE-2.0
> +#
> +# Unless required by applicable law or agreed to in writing,
> +# software distributed under the License is distributed on an
> +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +# KIND, either express or implied. See the License for the
> +# specific language governing permissions and limitations
> +# under the License.
> +""" Test case for Data Disk Attach to VM on ZWPS Test Path
> +"""
> +
> +from nose.plugins.attrib import attr
> +from marvin.cloudstackTestCase import cloudstackTestCase
> +from marvin.lib.utils import (cleanup_resources,
> + validateList)
> +from marvin.lib.base import (Account,
> + ServiceOffering,
> + DiskOffering,
> + Volume,
> + VirtualMachine,
> + StoragePool
> + )
> +from marvin.lib.common import (get_domain,
> + get_zone,
> + get_template
> + )
> +
> +from marvin.codes import (PASS,
> + ZONETAG1)
> +
> +
> +class TestAttachDataDisk(cloudstackTestCase):
> +
> +@classmethod
> +def setUpClass(cls):
> +testClient = super(TestAttachDataDisk, cls).getClsTestClient()
> +cls.apiclient = testClient.getApiClient()
> +cls.testdata = testClient.getParsedTestDataConfig()
> +cls.hypervisor = cls.testClient.getHypervisorInfo()
> +
> +# Get Zone, Domain and templates
> +cls.domain = get_domain(cls.apiclient)
> +cls.zone = get_zone(cls.apiclient,
> testClient.getZoneForTests())
> +cls._cleanup = []
> +cls.template = get_template(
> +cls.apiclient,
> +cls.zone.id,
> +cls.testdata["ostype"])
> +cls.skiptest = False
> +
> +try:
> +cls.pools = StoragePool.list(cls.apiclient, zoneid=
> cls.zone.id)
> +except Exception as e:
> +cls.skiptest = True
> +return
> +try:
> +
> +# Create an account
> +cls.account = Account.create(
> +cls.apiclient,
> +cls.testdata["account"],
> +domainid=cls.domain.id
> +)
> +cls._cleanup.append(cls.account)
> +
> +# Create user api client of the account
> +cls.userapiclient = testClient.getUserApiClient(
> +UserName=cls.account.name,
> +DomainName=cls.account.domain
> +)
> +# Create Service offering
> +cls.service_offering_zone1 = ServiceOffering.create(
> +cls.apiclient,
> +cls.testdata["service_offering"],
> +tags=ZONETAG1
> +)
> +cls._cleanup.append(cls.service_offering_zone1)
> +
> +# Create Disk offering
> +cls.disk_offering = DiskOffering.create(
> +cls.apiclient,
> +cls.testdata["disk_offering"]
> +)
> +
> +cls._cleanup.append(cls.disk_offering)
> +
> +except Exception as e:
> +cls.tearDownClass()
> +raise e
> +return
> +
> +@classmethod
> +def tearDownClass(cls):
> +try:
> +cleanup_resources(cls.apiclient, cls._cleanup)
> +except Exception as e:
> +raise Exception("Warning: Exception during cleanup : %s"
> % e)
> +
> +def setUp(self):
> +self.apiclient = self.testClient.getApiClient()
> +self.dbclient = self.testClient.getDbConnection()
> +self.cleanup = []
> +
> +def tearDown(self):
>
[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/631#discussion_r36058447
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,209 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test case for Data Disk Attach to VM on ZWPS Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+ validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Volume,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+ get_zone,
+ get_template
+ )
+
+from marvin.codes import (PASS,
+ ZONETAG1)
+
+
+class TestAttachDataDisk(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestAttachDataDisk, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls._cleanup = []
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+cls.skiptest = False
+
+try:
+cls.pools = StoragePool.list(cls.apiclient, zoneid=cls.zone.id)
+except Exception as e:
+cls.skiptest = True
+return
+try:
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zone1 = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+cls._cleanup.append(cls.service_offering_zone1)
+
+# Create Disk offering
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"]
+)
+
+cls._cleanup.append(cls.disk_offering)
+
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.cleanup = []
+
+def tearDown(self):
+try:
+for storagePool in self.pools:
+StoragePool.update(self.apiclient, id=storagePool.id,
tags="")
+
+if hasattr(self, "data_volume_created"):
+data_volumes_list = Volume.list(
+self.userap
[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/631#discussion_r35955307
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,209 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test case for Data Disk Attach to VM on ZWPS Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+ validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Volume,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+ get_zone,
+ get_template
+ )
+
+from marvin.codes import (PASS,
+ ZONETAG1)
+
+
+class TestAttachDataDisk(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestAttachDataDisk, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls._cleanup = []
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+cls.skiptest = False
+
+try:
+cls.pools = StoragePool.list(cls.apiclient, zoneid=cls.zone.id)
+except Exception as e:
+cls.skiptest = True
+return
+try:
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zone1 = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+cls._cleanup.append(cls.service_offering_zone1)
+
+# Create Disk offering
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"]
+)
+
+cls._cleanup.append(cls.disk_offering)
+
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.cleanup = []
+
+def tearDown(self):
+try:
+for storagePool in self.pools:
+StoragePool.update(self.apiclient, id=storagePool.id,
tags="")
+
+if hasattr(self, "data_volume_created"):
+data_volumes_list = Volume.list(
+self.userapicl
[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/631#discussion_r35955247
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,209 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test case for Data Disk Attach to VM on ZWPS Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+ validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Volume,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+ get_zone,
+ get_template
+ )
+
+from marvin.codes import (PASS,
+ ZONETAG1)
+
+
+class TestAttachDataDisk(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestAttachDataDisk, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls._cleanup = []
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+cls.skiptest = False
+
+try:
+cls.pools = StoragePool.list(cls.apiclient, zoneid=cls.zone.id)
+except Exception as e:
+cls.skiptest = True
+return
+try:
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zone1 = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+cls._cleanup.append(cls.service_offering_zone1)
+
+# Create Disk offering
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"]
+)
+
+cls._cleanup.append(cls.disk_offering)
+
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.cleanup = []
+
+def tearDown(self):
+try:
+for storagePool in self.pools:
+StoragePool.update(self.apiclient, id=storagePool.id,
tags="")
+
+if hasattr(self, "data_volume_created"):
+data_volumes_list = Volume.list(
+self.userapicl
[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/631#issuecomment-126605717 All is green and as there is no other reviews and all tests are green, I am going to say: LGTM. But please someone that understands the full ramifications of the test verify. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/631#discussion_r35947714
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,185 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test case for Data Disk Attach to VM on ZWPS Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+ validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Volume,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+ get_zone,
+ get_template
+ )
+
+from marvin.codes import (PASS,
+ ZONETAG1)
+
+
+class TestAttachDataDisk(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestAttachDataDisk, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls._cleanup = []
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+cls.skiptest = False
+
+try:
+cls.pools = StoragePool.list(cls.apiclient, zoneid=cls.zone.id)
+except Exception as e:
+cls.skiptest = True
+return
+try:
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zone1 = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+cls._cleanup.append(cls.service_offering_zone1)
+
+# Create Disk offering
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"]
+)
+
+cls._cleanup.append(cls.disk_offering)
+
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.cleanup = []
+
+def tearDown(self):
+try:
+if hasattr(self, "data_volume_created"):
+data_volumes_list = Volume.list(
+self.userapiclient,
+id=self.data_volume_created.id,
+virtualmachineid=self.vm.id
+
[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/631#discussion_r35743142
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,185 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test case for Data Disk Attach to VM on ZWPS Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+ validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Volume,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+ get_zone,
+ get_template
+ )
+
+from marvin.codes import (PASS,
+ ZONETAG1)
+
+
+class TestAttachDataDisk(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestAttachDataDisk, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls._cleanup = []
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+cls.skiptest = False
+
+try:
+cls.pools = StoragePool.list(cls.apiclient, zoneid=cls.zone.id)
+except Exception as e:
+cls.skiptest = True
+return
+try:
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zone1 = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+cls._cleanup.append(cls.service_offering_zone1)
+
+# Create Disk offering
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"]
+)
+
+cls._cleanup.append(cls.disk_offering)
+
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.cleanup = []
+
+def tearDown(self):
+try:
+if hasattr(self, "data_volume_created"):
+data_volumes_list = Volume.list(
+self.userapiclient,
+id=self.data_volume_created.id,
+virtualmachineid=self.vm.id
+)
[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/631#issuecomment-125875443 I can only judge this on code cleanliness. An added pep8 pull request builder might help;) @pritisarap12 please solicit review from test experts that have access to the required hardware (zwmp?) or add verification instructions for no-knows like me to test this. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...
GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/631 CLOUDSTACK-8686:Verify data disk attachment for clusters with only zone wide primary -Attaching the uploaded/allocated volume to a VM on zwps You can merge this pull request into a Git repository by running: $ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-8686-Data-disk-attach-failed-for-clusters-with-only-zone-wide-primary Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/631.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #631 commit 608fff5412a6cbb4a7f19849c61b69c049cc3e4e Author: Priti Sarap Date: 2015-07-29T06:14:59Z CLOUDSTACK-8686: Data disk attach failed for clusters with only zone wide primary -Attaching the uploaded/allocated volume to a VM on zwps --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
