[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/808


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/808#issuecomment-139957981
  
@DaanHoogland the repeated code is two lines calling sendalert and logger. 
may be we could move the logging to send alert itself. Will check that later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/808#issuecomment-139521444
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

[karuturi]

GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/808

CLOUDSTACK-8835: Added alerts incase of template download failure

Authored-By: @sanjaytripathi 
Reviewed-By: Devdeep

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack CLOUDSTACK-8835

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/808.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #808


commit 9a35f87d370fb781763d1d243d2f225e3fb60c4a
Author: Sanjay Tripathi 
Date:   2015-02-26T10:04:29Z

CLOUDSTACK-8835: Added alerts incase of template download failure

Reviewed-By: Devdeep




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/808#issuecomment-139532776
  
Makes sense and LGTM. I see some code duplication in 
ImageStoreUploadMonitorImpl, though. A good moment to get rid of this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/808#issuecomment-139538657
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---