[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/978


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-27 Thread wido 
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/978#issuecomment-151444216
  
LGTM

Nice feature indeed :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-27 Thread remibergsma 
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/978#issuecomment-151487786
  
@borisroman Can you review this again please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-27 Thread borisroman 
Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/978#issuecomment-151636411
  
@remibergsma LGMT :+1: 
![screenshot from 2015-10-27 21 36 
41](https://cloud.githubusercontent.com/assets/5996146/10771758/e04ddde8-7cf2-11e5-9540-02c94bfc72ab.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou 
GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/978

CLOUDSTACK-8990: start a stopped machine on a specific determinable host on 
UI



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack startvm-specific-host

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/978.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #978


commit dd1d5a1c10d9aa619c6026f41b81761e837304d6
Author: Wei Zhou 
Date:   2015-10-26T10:02:04Z

CLOUDSTACK-8990: start a stopped machine on a specific determinable host on 
UI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou 
Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/978#issuecomment-151115822
  
@borisroman None means cloudstack will allocate the host to start the vm. I 
think it is also needed for users. Not everyone wants to specify a host, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread borisroman 
Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/978#issuecomment-151115178
  
@ustcweizhou Thanks for implementing this feature. I've got 1 comment, 
could you select the first host available instead of none? See image.

![screenshot from 2015-10-26 13 11 
21](https://cloud.githubusercontent.com/assets/5996146/10728602/889efc5e-7be3-11e5-96e7-07ebe698f1e1.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread borisroman 
Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/978#issuecomment-151116076
  
@ustcweizhou Oke! Though can you make that visible to the user? Now it 
seems like you "have to" select a host, like you're forced to do so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou 
Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/978#issuecomment-151136095
  
change default host from empty to 'Default'. done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou 
Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/978#issuecomment-151127784
  
@borisroman sorry my comment made you confused. The users I meant is one 
who use cloudstack for deployment. 
This window is only visible for root admins. For non-root users (defined in 
cloudstack), they still use the old window.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread borisroman 
Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/978#issuecomment-151115265
  
@remibergsma @karuturi I've run the following tests:

```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou 
Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/978#issuecomment-151133235
  
@borisroman yes, sure


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread borisroman 
Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/978#issuecomment-151131758
  
@ustcweizhou By "user" I meant the root admin. So my question is: Could you 
adjust the dialog you created to show something like "Default" instead of an 
empty label.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---