[GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1041


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

[Sanjeev N]

This PR is related to changes in base.py So ran one test which invokes the
changes to make sure the changes works fine.

Check Snapshots size in database ... === TestName:
test_02_snapshot_size_check | Status : SUCCESS ===
ok

--
Ran 1 tests in 385.302s

OK

On Mon, Dec 28, 2015 at 6:08 PM, sanju1010  wrote:

> Github user sanju1010 commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1041#issuecomment-167562620
>
> I will post test results. LGTM !!
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1041#issuecomment-167562620
  
I will post test results. LGTM !!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

[pvr9711]

Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/1041#issuecomment-166879168
  
LGTM - changes look pretty straightforward.  @remibergsma can you please 
merge this in.  Thanks, Raja


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

[pritisarap12]

GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/1041

CLOUDSTACK-9041: Modifying template creation from snapshot function 

In create_from_snapshot function of Template class there is no parameter to 
accept if the template is public hence default it is creating private templates 
Hence adding this parameter.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-9041-Modifying-template-creation-from-snapshot-function-in-base.py

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1041.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1041


commit bbe0fc4be9527d51820b067a602886003991db4d
Author: Priti Sarap 
Date:   2015-11-06T09:06:32Z

CLOUDSTACK-9041: Modifying template creation from snapshot function in 
base.py




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---