[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-175683694 LGTM anyone, needs one more? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...
Github user rajesh-battala commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-212805433 Gone through the code. API change for the description param is good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-212976859 We need to be doing this to more API calls, so I am happy we are starting to look at this. @DaanHoogland I don't think JSON adds much value here. I think the main thing that needs to be in this documentation is how the URL query looks. I have run into many situation where the URL query is very hard to figure out and I have spent way too much time doing trial and error on this. I think the information presented here is the correct format and is useful. I will add this to my merge queue. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1126 CLOUDSTACK-9088: Update the description for migrateVirtualMachineWithVolume api https://issues.apache.org/jira/browse/CLOUDSTACK-9088 You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9088 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1126.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1126 commit 14c95b1871399d1988ff2fce50dab02e268bc765 Author: Anshul Gangwar Date: 2015-06-17T05:25:07Z CLOUDSTACK-9088: Update the description for migrateVirtualMachineWithVolume api. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-160908595 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-160936999 It seems to me this text is only suitable for use with cloudmonkey or maybe python clients. I don't think it makes sense to format it this way in the java annotation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-160938583 @DaanHoogland Could you suggest a better way of putting this information in API documents in current scenario? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1126#issuecomment-160941315
There is two problems to solve here;
1. how to document the api in a concise way. The information you are
providing is very useful and I think it makes sense to put it there
2. how to use the api. the formatting of the information is specific to the
client so I would try to use a more formal format or as in my exmple below in
json. I don't have a universal answer to this but in this case I would say,
though it is somewhate oververbose:
```
migrateto : [ {
volume: '71f43cd6-69b0-4d3b-9fbc-67f50963d60b',
pool: 'a382f181-3d2b-4413-b92d-b8931befa7e1'
},
{
volume: '88de0173-55c0-4c1c-a269-83d0279eeedf',
pool: '95d6e97c-6766-4d67-9a30-c449c15011d1'
},
{
volume: '1b331390-59f2-4796-9993-bf11c6e76225',
pool: '41fdb564-9d3b-447d-88ed-7628f7640cbc'
} ]
This example in cloudmoney:
migrateto[0].volume=<71f43cd6-69b0-4d3b-9fbc-67f50963d60b>&migrateto[0].pool=&migrateto[1].volume=<88de0173-55c0-4c1c-a269-83d0279eeedf>&migrateto[1].pool=<95d6e97c-6766-4d67-9a30-c449c15011d1>&migrateto[2].volume=<1b331390-59f2-4796-9993-bf11c6e76225>&migrateto[2].pool=<41fdb564-9d3b-447d-88ed-7628f7640cbc>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-161180226 @DaanHoogland I don't understand how json format is helping here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-161205824 @anshul1886 It is a language independent description of the parameters and applicable to all API client implementations. It can also be view as a more generic/formal description of the parameter format. Users of powershell or go implementation will probably need to format their commandline differently. Seeing the data in a second format will prevent to some extend prejudice on how the data is to be formatted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
