[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...
Github user priyankparihar closed the pull request at: https://github.com/apache/cloudstack/pull/1207 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1207#issuecomment-164178065 @priyankparihar Could you point me where in VolumeStateListener it is emitted? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1207#issuecomment-164177131 @priyankparihar these are nice results but I have no way of verifying the latter is actually the good result. can you write a test that proves proper behaviour? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...
Github user priyankparihar commented on the pull request: https://github.com/apache/cloudstack/pull/1207#issuecomment-163912073 @DaanHoogland Prior Behaviour | 127 | VOLUME.DELETE | 2 | 2015-12-08 09:30:18 | 1 | 25 | ROOT-14 |NULL | NULL | NULL | NULL | 0 | NULL | | 128 | VOLUME.DELETE | 2 | 2015-12-08 09:30:20 | 1 | 25 | ROOT-14 |NULL | NULL | NULL | NULL | 0 | NULL | New Behaviour | 127 | VOLUME.DELETE | 2 | 2015-12-08 09:30:18 | 1 | 25 | ROOT-14 |NULL | NULL | NULL | NULL | 0 | NULL | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1207#issuecomment-163903617 @priyankparihar please expand on testing that can prove prior and new behaviour. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...
GitHub user priyankparihar opened a pull request: https://github.com/apache/cloudstack/pull/1207 CLOUDSTACK-9133: Two volume.delete usage events are getting generated⦠It was happening because event triggering was happening in UserVmManagerImpl.java and VolumeStateListener.java respectively. So i have removed it from UserVmManagerImpl.java. You can merge this pull request into a Git repository by running: $ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9133 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1207.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1207 commit 5af3fd1987e797358e9bc99232202225850ed2c1 Author: Priyank Parihar Date: 2015-12-10T07:14:06Z CLOUDSTACK-9133: Two volume.delete usage events are getting generated for destoy vm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---