[GitHub] cloudstack pull request: CLOUDSTACK-9184: [VMware] vmware.ports.pe...
Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1253#issuecomment-192951641 @sureshanaparti Although it might be a bit tricky, I believe that the ideal solution would be to check for the hypervisor version; if it is 4.1/4.0 then the default value of 8 is changed to 256 (or any recommended amount for the given version). This way does not rely on admin to manually configure it (the idea would be to consider the global configuration if the admin set it, would just change a default value). I checked and maybe a method for check the hypervisor version and set the **_portsPerDvPortGroup** could be called by **com.cloud.hypervisor.vmware.manager.VmwareManagerImpl.addHostToPodCluster(VmwareContext, long, Long, Long, String)**. This method would search a host using the clusterId (**com.cloud.host.dao.HostDaoImpl.findByClusterId(Long)**); with the given HostVO it verifies the hypervisor version (**com.cloud.host.HostVO.getHypervisorVersion()**) to set the default value according this version. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9184: [VMware] vmware.ports.pe...
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1253#issuecomment-207147802 ### ACS CI BVT Run **Sumarry:** Build Number 161 Hypervisor xenserver NetworkType Advanced Passed=110 Failed=18 Skipped=4 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_vpc_router_nics.py * test_02_VPC_default_routes Failed * test_vpc_redundant.py * test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failed * test_02_redundant_VPC_default_routes Failed * test_privategw_acl.py * test_01_vpc_privategw_acl Failed * test_scale_vm.py * ContextSuite context=TestScaleVm>:setup Failing since 2 runs * test_router_dhcphosts.py * test_router_dhcphosts Failed * ContextSuite context=TestRouterDHCPHosts>:teardown Failed * test_quota.py * test_01_quota Failed * test_02_quota Failed * test_03_quota Failed * test_04_quota Failed * test_05_quota Failed * test_06_quota Failed * test_07_quota Failed * test_password_server.py * test_isolate_network_password_server Failed * test_routers_network_ops.py * test_01_isolate_network_FW_PF_default_routes_egress_true Failed * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_deploy_vgpu_enabled_vm test_06_copy_template test_06_copy_iso **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_guest_vlan_range.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_snapshots.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_non_contigiousvlan.py test_deploy_vm_iso.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_ssvm.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9184: [VMware] vmware.ports.pe...
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1253#issuecomment-216210337 @sureshanaparti please rebase against latest master, move the schema changes to 481-490 upgrade path tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9184: [VMware] vmware.ports.pe...
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1253#issuecomment-98365 ### ACS CI BVT Run **Sumarry:** Build Number 71 Hypervisor xenserver NetworkType Advanced Passed=73 Failed=0 Skipped=3 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_vpc_vpn.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_routers.py test_reset_vm_on_reboot.py test_snapshots.py test_deploy_vms_with_varied_deploymentplanners.py test_login.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9184: [VMware] vmware.ports.pe...
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1253 CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards Modify the default value of this setting, which is currently 256, by decreasing it to 8 because even a dvportgroup with autoexpand feature enabled there exists an initial number of ports as starting point, which can be again configured through this configuration setting. But keeping this value 256 doesn't make sense when auto expand feature is available. Keeping the starting number of dvports per dvportgroup to reasonably minimum would ensure optimal distribution across dvportgroups in dvSwitch. The vSphere Auto Expand feature (introduced in vSphere 5.0) will take care of dynamically increasing/decreasing the dvPorts when running out of distributed ports . But in case of vSphere 4.1/4.0 (If used), as this feature is not there, the new default value (=> 8) have an impact in the existing deployments. Action item for vSphere 4.1/4.0: Admin should modify the global configuration setting "vmware.ports.per.dvportgroup" from 8 to any number based on their environment because the proposal default value of 8 would be very less without auto expand feature in general. The current default value of 256 may not need immediate modification after deployment, but 8 would be very less which means admin need to update immediately after upgrade. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sureshanaparti/cloudstack CLOUDSTACK-9184 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1253.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1253 commit 4e0cd09226ed1819f51ad018ec0020358d5c3e85 Author: Suresh Kumar Anaparti Date: 2015-12-17T04:34:53Z CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards Fix: Modify the default value of this setting, which is currently 256, by decreasing it to 8 because even a dvportgroup with autoexpand feature enabled there exists an initial number of ports as starting point, which can be again configured through this configuration setting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
