[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1364#issuecomment-174884655
  
Routes are supposed to be to networks when going out, so this makes sense. 
production at sbp is good enough a test for me: LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1364


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1364#issuecomment-174863942
  

`cat /etc/cloudstack/staticroutes.json` before and after change:

Before always had one entry:


```
{
"10.135.255.10": {
"gateway": "10.135.255.129",
"ip_address": "10.135.255.10",
"network": "10.0.0.0/9",
"revoke": false
},
 }
```

After this PR:

```
{
"10.0.0.0/9": {
"gateway": "10.135.255.129",
"ip_address": "10.135.255.10",
"network": "10.0.0.0/9",
"revoke": false
},
"10.128.0.0/13": {
"gateway": "10.135.255.129",
"ip_address": "10.135.255.10",
"network": "10.128.0.0/13",
"revoke": false
},
}
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1364#issuecomment-174861340
  
LGTM :+1: 

Already running in production at SBP!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1364

CLOUDSTACK-9256 add unique key for static routes in json

Static routes that are being set do not show up in the static_routes.json 
file. The reason for this is that the index that is used, is the gateway 
address, which is not unique. Hence stuff is overwritten and lost.

Ping @borisroman @wilderrodrigues @DaanHoogland 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack CLOUDSTACK-9256

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1364


commit 62fc6fef97efb2c938737262cabb9254fca55ba1
Author: Remi Bergsma 
Date:   2016-01-25T16:17:55Z

CLOUDSTACK-9256 add unique key for static routes in json




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---