[GitHub] cloudstack pull request: CPU socket count reporting correction

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-219105793
  
Awesome, thanks guys.  I will merge this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[kiwiflyer]

Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-219033610
  
@swill  This one is green now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-219027354
  
LGTM, running this in prod for about a month now. See link above for 
screenshots.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[NuxRo]

GitHub user NuxRo reopened a pull request:

https://github.com/apache/cloudstack/pull/1520

CPU socket count reporting correction

CPU socket count reporting correction
From 
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NuxRo/cloudstack kvm-numa-cpu-reporting

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1520


commit 42de1f81ed13145374a5838459ce068881966e8c
Author: NuxRo 
Date:   2016-04-27T09:49:53Z

CPU socket count reporting correction

CPU socket count reporting correction
From 
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16

commit 108b3517afc8a5bd5cb1443fb7dc88a8c71ef168
Author: NuxRo 
Date:   2016-04-27T18:15:02Z

Remove empty spaces causing the build to fail




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[NuxRo]

Github user NuxRo closed the pull request at:

https://github.com/apache/cloudstack/pull/1520


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-218793268
  
@NuxRo I have pushed fixes to both Jenkins and Travis this morning.  Can 
you close and reopen the PR to kick off the Jenkins and Travis runs again.  
Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[NuxRo]

GitHub user NuxRo reopened a pull request:

https://github.com/apache/cloudstack/pull/1520

CPU socket count reporting correction

CPU socket count reporting correction
From 
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NuxRo/cloudstack kvm-numa-cpu-reporting

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1520


commit 42de1f81ed13145374a5838459ce068881966e8c
Author: NuxRo 
Date:   2016-04-27T09:49:53Z

CPU socket count reporting correction

CPU socket count reporting correction
From 
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16

commit 108b3517afc8a5bd5cb1443fb7dc88a8c71ef168
Author: NuxRo 
Date:   2016-04-27T18:15:02Z

Remove empty spaces causing the build to fail




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[NuxRo]

Github user NuxRo closed the pull request at:

https://github.com/apache/cloudstack/pull/1520


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-218365187
  
@NuxRo can you close and reopen this PR to force Jenkins to kick off a run. 
 It has been hung in this state for days.  I know you can't easily `amend` and 
force push, so closing and reopening the PR will let you kick it off again 
through the UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-217514394
  
I am comfortable not running CI on this one given the scope of the change 
and the manual tests that have been run.  This one is ready now.  We need this 
force pushed again though so we can get Jenkins green.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-217507357
  
LGTM (code review)

tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[dmabry]

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-217485432
  
We have rolled this patch in our lab and verified that it does indeed 
report the number of sockets correctly.  Based on testing this LGTM.

Please do a force push to kick off jenkins and travis again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-217475012
  
Can we get another code review on this?  Also, Jenkins seems to be hung, 
can we either close and reopen the PR or do a force push to kick it off?  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[NuxRo]

Github user NuxRo commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-217094836
  
I'd appreciate it if someone else could do it, I do not have the setup to 
perform more advanced github operations right now, other than the UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-216230034
  
@NuxRo thanks, please rebase and squash to a single commit

LGTM

tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-215143364
  
Great, thanks @remibergsma.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-215143007
  
@swill more details here: 
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-215124694
  
@NuxRo can you do a force push to kick off jenkins and travis again.  Also, 
can you show this change fixes the behavior with a screenshot or something.  I 
don't think the code change warrants a full CI run since nothing new was 
introduced, only the value of a variable has changed and it uses proper 
defensive programming...  It would be nice to see the problem it solves 
though...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

[NuxRo]

GitHub user NuxRo opened a pull request:

https://github.com/apache/cloudstack/pull/1520

CPU socket count reporting correction

CPU socket count reporting correction
From 
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NuxRo/cloudstack kvm-numa-cpu-reporting

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1520


commit 42de1f81ed13145374a5838459ce068881966e8c
Author: NuxRo 
Date:   2016-04-27T09:49:53Z

CPU socket count reporting correction

CPU socket count reporting correction
From 
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---