[GitHub] cloudstack pull request: Fix 3 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/443


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix 3 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request:

https://github.com/apache/cloudstack/pull/443

Fix 3 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRI…

…NG warnings in Upgrade410to420.java

There was no risk of sql injection here, nor any need to use 
PreparedStatement, still this fixes the warnings

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rsafonseca/cloudstack findbugs60

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/443.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #443


commit 699152f57daaa0b425197091debb25463b252ff5
Author: Rafael da Fonseca 
Date:   2015-06-14T17:27:06Z

Fix 3 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 
warnings in Upgrade410to420.java
There was no risk of sql injection here, nor any need to use 
PreparedStatement, still this fixes the warnings




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---