[GitHub] cloudstack pull request: Modification in setupClass to skip testca...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Modification in setupClass to skip testca...
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/343#issuecomment-108277011 LGTM, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Modification in setupClass to skip testca...
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/343#discussion_r31596502
--- Diff: test/integration/component/test_netscaler_lb_algo.py ---
@@ -76,8 +78,12 @@ def setUpClass(cls):
cls.testdata["service_offering"]
)
except Exception as e:
-cls.tearDownClass()
-raise Exception("Warning: Exception in setUpClass: %s" % e)
+if cls.exception_string.lower() in e.lower():
--- End diff --
e.lower() won't work as e is an Exception object. Convert it to string and
then use it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Modification in setupClass to skip testca...
Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/343#issuecomment-107824912 Done with the review changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Modification in setupClass to skip testca...
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/343#discussion_r31494908
--- Diff: test/integration/component/test_netscaler_lb_algo.py ---
@@ -76,8 +78,12 @@ def setUpClass(cls):
cls.testdata["service_offering"]
)
except Exception as e:
-cls.tearDownClass()
-raise Exception("Warning: Exception in setUpClass: %s" % e)
+if cls.exception_string in e:
--- End diff --
Do case insensitive string comparisons to be safe. Change wherever
applicable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Modification in setupClass to skip testca...
GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/343 Modification in setupClass to skip testcases rather than throwing exception Skip the testcase which is throwing an exception on "Exceeding connection limit to NetScaler device" You can merge this pull request into a Git repository by running: $ git pull https://github.com/pritisarap12/cloudstack Regrassion-testing-test_netscaler_lb_algo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/343.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #343 commit 3dcfa82de109264a724b5aeca0809271295727a6 Author: pritisarap12 Date: 2015-06-02T05:34:34Z Modification in setupClass to skip testcases rather than throwing an exception on "Exceeding connection limit to Netscaler device" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
