[GitHub] cloudstack pull request: Refactor/citrix resource base rebase
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Refactor/citrix resource base rebase
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/137#issuecomment-88999899 Skimmed over diff, looks good. Built after merging branch and was able to deploy a basic zone and do basic vm lifecycle tests. TravisCI is green as well, so merging. @wilderrodrigues thanks for the PR, in case this breaks master (after merge) please watch out :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Refactor/citrix resource base rebase
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/137#issuecomment-89023853 Thanks a lot, man! Will keep an eye on Master. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Refactor/citrix resource base rebase
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/137#issuecomment-88510623 Addced documentation here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Refactoring+CitirxResourceBase+class --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Refactor/citrix resource base rebase
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/137 Refactor/citrix resource base rebase Hi Rohit (@bhaisaab) It's a huge piece of work, but it has been extensively tested. Could you please have a look? :) Thanks in advance. Cheers, Wilder XenServer 6.2 running under our VMWare zone CloudStack Management Server running on MacBook Pro MySql running on MackBook Pro Storage Type: Local Storage +87 new unit tests Tests: Test Create Account and user for that account ... === TestName: test_01_create_account | Status : SUCCESS === ok Test Sub domain allowed to launch VM when a Domain level zone is created ... === TestName: test_01_add_vm_to_subdomain | Status : SUCCESS === ok Test delete domain without force option ... === TestName: test_DeleteDomain | Status : SUCCESS === ok Test delete domain with force option ... === TestName: test_forceDeleteDomain | Status : SUCCESS === ok Test update admin details ... === TestName: test_updateAdminDetails | Status : SUCCESS === ok Test update domain admin details ... === TestName: test_updateDomainAdminDetails | Status : SUCCESS === ok Test user update API ... === TestName: test_updateUserDetails | Status : SUCCESS === ok Test login API with domain ... === TestName: test_LoginApiDomain | Status : SUCCESS === ok Test if Login API does not return UUID's ... === TestName: test_LoginApiUuidResponse | Status : SUCCESS === ok -- Ran 9 tests in 1330.562s OK /tmp//MarvinLogs/test_accounts_K2LZXD/results.txt (END) Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS === ok Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS === ok Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS === ok Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS === ok Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS === ok Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS === ok Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS === ok Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS === ok Test migrate VM ... SKIP: At least two hosts should be present in the zone for migration Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS === ok -- Ran 10 tests in 917.300s OK (SKIP=1) /tmp//MarvinLogs/test_vm_life_cycle_HWY7MI/results.txt (END) Test router internal advanced zone ... SKIP: Marvin configuration has no host credentials to check router services Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS === ok Test router basic setup ... === TestName: test_05_router_basic | Status : SUCCESS === ok Test router advanced setup ... === TestName: test_06_router_advanced | Status : SUCCESS === ok Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS === ok Test start router ... === TestName: test_08_start_router | Status : SUCCESS === ok Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS === ok -- Ran 7 tests in 438.857s OK (SKIP=1) /tmp//MarvinLogs/test_routers_15MIHW/results.txt (END) Test start/stop of router after addition of one guest network ... === TestName: test_01_start_stop_router_after_addition_of_one_guest_network | Status : SUCCESS === ok Test reboot of router after addition of one guest network ... === TestName: test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS === ok Test to change service offering of router after addition of one guest network ... === TestName: test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : SUCCESS === ok Test destroy of router after addition of one guest network ... === TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : SUCCESS === ok Test to stop and start router after creation of VPC ... === TestName: test_01_stop_start_router_after_creating_vpc | Status : SUCCESS === ok Test to reboot the router after creating a VPC ... === TestName: test_02_reboot_router_after_creating_vpc | Status : SUCCESS === ok Tests to change service offering of the Router after ... === TestName:
[GitHub] cloudstack pull request: Refactor/citrix resource base rebase
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/137#issuecomment-88354995 Hi @wilderrodrigues, I'll try to review and test it soon. Thanks for the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
