[GitHub] cloudstack pull request: Squashing two commits in to single commit
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1411#issuecomment-184636485 @runseb very sorry but I saw @remibergsma LGTM above here in this PR. please revert. I have not looked into this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Squashing two commits in to single commit
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1411#issuecomment-184633589 @DaanHoogland @sanjeevneelarapu you guys are writing the code so I have nothing to say...but @remibergsma asked for updating the PR message and nothing was done. Now we have a commit in our history with the message "squashing two commits" , I would be a BD I would revert this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Squashing two commits in to single commit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: Squashing two commits in to single commit
LGTM based on PR#667 On Mon, Feb 15, 2016 at 5:37 PM, DaanHoogland wrote: > Github user DaanHoogland commented on the pull request: > > https://github.com/apache/cloudstack/pull/1411#issuecomment-184182132 > > @sanjeevneelarapu If you LGTM this there are 2 LGTM here so please go > ahead and merge. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
[GitHub] cloudstack pull request: Squashing two commits in to single commit
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1411#issuecomment-184182132 @sanjeevneelarapu If you LGTM this there are 2 LGTM here so please go ahead and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: Squashing two commits in to single commit
Is it okay to merge this PR or we need to wait for two LGTMs, since original PR 667 already has two LGTMs ? On Fri, Feb 12, 2016 at 1:59 PM, remibergsma wrote: > Github user remibergsma commented on the pull request: > > https://github.com/apache/cloudstack/pull/1411#issuecomment-183226537 > > Thanks! LGTM, based on #667. > > I'd suggest though to make the commit message and PR title more > descriptive. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
[GitHub] cloudstack pull request: Squashing two commits in to single commit
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1411#issuecomment-183226537 Thanks! LGTM, based on #667. I'd suggest though to make the commit message and PR title more descriptive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Squashing two commits in to single commit
GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/1411 Squashing two commits in to single commit CLOUDSTACK-8717: Failed to start instance after restoring the running instance -Modified code to add tag to aonly one cluster wide SP -Added validateList function -Added code to clear tags in tearDown class You can merge this pull request into a Git repository by running: $ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-8717-Failed-to-start-instance-after-restoring-the-running-instance Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1411.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1411 commit 8c7f5ab93d56c2aa0cde194509b728511173f7a9 Author: Priti Sarap Date: 2015-08-07T12:27:54Z Squashing two commits in to single commit CLOUDSTACK-8717: Failed to start instance after restoring the running instance -Modified code to add tag to aonly one cluster wide SP -Added validateList function -Added code to clear tags in tearDown class --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
