[GitHub] cloudstack pull request: Use constant-time comparison functions wh...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Use constant-time comparison functions wh...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/65#issuecomment-69926558 Tested locally on master, works for me. Thanks for your contribution @pyr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Use constant-time comparison functions wh...
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/65#issuecomment-69926943 thanks @bhaisaab --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: Use constant-time comparison functions wh...
I'll note here that this can be applied to 4.4 and 4.3 as well, modulo some simple changes. On Wed, Jan 14, 2015 at 11:32 AM, pyr g...@git.apache.org wrote: GitHub user pyr opened a pull request: https://github.com/apache/cloudstack/pull/65 Use constant-time comparison functions when checking signatures This limits the likeliness of timing attacks against the API. See http://codahale.com/a-lesson-in-timing-attacks/ for the full rationale. You can merge this pull request into a Git repository by running: $ git pull https://github.com/exoscale/cloudstack feature/constant-time Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/65.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #65 commit 9b4e39e837af498599859c4a6687eb8bf9f8ad89 Author: Pierre-Yves Ritschard p...@spootnik.org Date: 2015-01-14T10:27:35Z Use constant-time comparison functions when checking signatures This limits the likeliness of timing attacks against the API. See http://codahale.com/a-lesson-in-timing-attacks/ for the full rationale. Conflicts: server/src/com/cloud/api/ApiServer.java server/src/com/cloud/user/AccountManagerImpl.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Use constant-time comparison functions wh...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/65#issuecomment-69899701 LGTM, let me test it. I can help backport it to 4.3/4.4, it's a good fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Use constant-time comparison functions wh...
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/65#discussion_r22929307
--- Diff: server/src/com/cloud/api/ConstantTimeComparator.java ---
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// License); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.api;
+
+public class ConstantTimeComparator {
+
+public static boolean compareBytes(byte[] b1, byte[] b2) {
+if (b1.length != b2.length) {
+return false;
+}
+
+int result = 0;
+for (int i = 0; i b1.length; i++) {
+result |= b1[i] ^ b2[i];
--- End diff --
Neat. +1
I would suggest moving this to utils instead of api. The api directory or
artifact should hold only contracts, commands and interfaces, if this is in
utils it could be re-usable (or maybe not) in future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Use constant-time comparison functions wh...
Github user pyr commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/65#discussion_r22930247
--- Diff: server/src/com/cloud/api/ConstantTimeComparator.java ---
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// License); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.api;
+
+public class ConstantTimeComparator {
+
+public static boolean compareBytes(byte[] b1, byte[] b2) {
+if (b1.length != b2.length) {
+return false;
+}
+
+int result = 0;
+for (int i = 0; i b1.length; i++) {
+result |= b1[i] ^ b2[i];
--- End diff --
Agreed, updated accordingly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Use constant-time comparison functions wh...
GitHub user pyr opened a pull request: https://github.com/apache/cloudstack/pull/65 Use constant-time comparison functions when checking signatures This limits the likeliness of timing attacks against the API. See http://codahale.com/a-lesson-in-timing-attacks/ for the full rationale. You can merge this pull request into a Git repository by running: $ git pull https://github.com/exoscale/cloudstack feature/constant-time Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/65.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #65 commit 9b4e39e837af498599859c4a6687eb8bf9f8ad89 Author: Pierre-Yves Ritschard p...@spootnik.org Date: 2015-01-14T10:27:35Z Use constant-time comparison functions when checking signatures This limits the likeliness of timing attacks against the API. See http://codahale.com/a-lesson-in-timing-attacks/ for the full rationale. Conflicts: server/src/com/cloud/api/ApiServer.java server/src/com/cloud/user/AccountManagerImpl.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
