[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

[lsimons]

GitHub user lsimons opened a pull request:

https://github.com/apache/cloudstack/pull/17

bugfix/CLOUDSTACK-7476 for 4.4 branch.

See https://github.com/apache/cloudstack/pull/15 for the pull request
that was merged to master & associated discussion.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/schubergphilis/cloudstack hotfix/4.4-7476

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit c6136255b95ac81d6da9cebc1b80639242d6a029
Author: Leo Simons 
Date:   2014-09-05T17:54:36Z

bugfix/CLOUDSTACK-7476 for 4.4 branch.

See https://github.com/apache/cloudstack/pull/15 for the pull request
that was merged to master & associated discussion.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/17#issuecomment-54707381
  
I merged it without closely reading the comment in #15. Does other logic 
need to ported as well, Leo?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/17#issuecomment-54777280
  
4.4:packaging/debian/init/cloud-usage already has the new logic to set 
$JAVA_HOME (e77da80e01b0774951e5c2ab1b23539af002b8b4) 

Given that it is already in 4.3(3bf4c294313eb0bdb9597f0af2cf6b81a8b4) 
and master(c468228fe807c621decc5919dadae9bcbb38c753), I think we should port 
the change to the file 4.4:packaging/centos63/cloud-usage.rc as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

[lsimons]

Github user lsimons commented on the pull request:

https://github.com/apache/cloudstack/pull/17#issuecomment-54785217
  
Hey Daan, _this_ change is fine&done as-is. Like Rajani mentioned, the 
other changes to that file could be ported, too. I'm +0 on that -- on the one 
hand, it's a good change and I can't see any way that it would ever break 
anything, on the other hand it's a (however minor) behavioral change so I 
personally wouldn't put that in a point release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/17#issuecomment-54790328
  
Leo, you are right but if it is in 4.3 not putting it in 4.4 would make it
a double behavioural change from a user perspective. So I will look at
cherry-picking it anyway


On Mon, Sep 8, 2014 at 9:38 AM, Leo Simons  wrote:

> Hey Daan, *this* change is fine&done as-is. Like Rajani mentioned, the
> other changes to that file could be ported, too. I'm +0 on that -- on the
> one hand, it's a good change and I can't see any way that it would ever
> break anything, on the other hand it's a (however minor) behavioral change
> so I personally wouldn't put that in a point release.
>
> —
> Reply to this email directly or view it on GitHub
> .
>



-- 
Daan


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---