[GitHub] cloudstack pull request: Coverity resource leaks

2015-07-15 Thread DaanHoogland
Github user DaanHoogland closed the pull request at:

https://github.com/apache/cloudstack/pull/578


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Coverity resource leaks

2015-07-14 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/578#issuecomment-121140173
  
LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Coverity resource leaks

2015-07-13 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/578#issuecomment-121138178
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Coverity resource leaks

2015-07-10 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/578#issuecomment-120455619
  
LGTM (squash maybe)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Coverity resource leaks

2015-07-10 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/578

Coverity resource leaks



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack 
coverity-resource-leaks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/578.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #578


commit b082443518bb2225dec3973b76b365a8ccbcf5e9
Author: Daan Hoogland d...@onecht.net
Date:   2015-07-10T14:31:22Z

coverity in upgrade code
 1164030: memory upgrade for ssvm
 1164031: image store details encryption

commit 706ce7f5ed33e421db1a750afb42d9ffe805206f
Author: Daan Hoogland d...@onecht.net
Date:   2015-07-10T14:45:16Z

coverity 1148416: auto close server socket




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: coverity resource leaks

2015-07-09 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/564#issuecomment-119917601
  
LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: coverity resource leaks

2015-07-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/564


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: coverity resource leaks

2015-07-08 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/564#issuecomment-119546107
  
changes looks good. :+1: 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: coverity resource leaks

2015-07-07 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/564

coverity resource leaks

This PR holds fixes for different resource leaks of the type that can be 
fixed by using try-with resource. The complete category is to be absent from 
coverity reports.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack 
coverity-resource-leaks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/564.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #564


commit 2f1d8b4c5a415534e5f6100ab9871c9021a10a83
Author: Daan Hoogland d...@onecht.net
Date:   2015-07-07T10:34:10Z

coverity 1308118: more resources being opened only one closed
 on exception nothing was closed




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---