[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/626#issuecomment-125471653 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/626#discussion_r35628826 --- Diff: debian/rules --- @@ -1,6 +1,6 @@ #!/usr/bin/make -f # -*- makefile -*- -VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v \[) +VERSION := $(shell cat pom.xml |sed '22!d'| cut -d'' -f2 |cut -d'' -f1) --- End diff -- @rsafonseca I checked the changes you made. Any reason why it wasn't merged in master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/626#discussion_r35627314 --- Diff: debian/rules --- @@ -1,6 +1,6 @@ #!/usr/bin/make -f # -*- makefile -*- -VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v \[) +VERSION := $(shell cat pom.xml |sed '22!d'| cut -d'' -f2 |cut -d'' -f1) --- End diff -- I proposed a similar solution before that was not merged on master, but was merged on 4.4 . It doesn't use line number. just check the 4.4 file :-) On Jul 28, 2015 8:24 AM, koushik-das notificati...@github.com wrote: In debian/rules https://github.com/apache/cloudstack/pull/626#discussion_r35620265: @@ -1,6 +1,6 @@ #!/usr/bin/make -f # -*- makefile -*- -VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v \[) +VERSION := $(shell cat pom.xml |sed '22!d'| cut -d'' -f2 |cut -d'' -f1) Is it possible to avoid using the line number (22)? If the line number changes for some reason then it won't work. â Reply to this email directly or view it on GitHub https://github.com/apache/cloudstack/pull/626/files#r35620265. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/626#discussion_r35620265 --- Diff: debian/rules --- @@ -1,6 +1,6 @@ #!/usr/bin/make -f # -*- makefile -*- -VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v \[) +VERSION := $(shell cat pom.xml |sed '22!d'| cut -d'' -f2 |cut -d'' -f1) --- End diff -- Is it possible to avoid using the line number (22)? If the line number changes for some reason then it won't work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/626#issuecomment-125522926 LGTM The thing with the line number could be done in a different PR. Cheers, Wilder Sent from my iPhone On 28 Jul 2015, at 04:38, Pierrre-Luc Dion notificati...@github.commailto:notificati...@github.com wrote: * build .deb package job must be change for dpkg-buildpackage -uc -us ubuntu 14.04 enforce signature of package. CLOUDSTACK-8638 * @wilderrodrigueshttps://github.com/wilderrodrigues: this fix dependency for keepalived on building systemvm64template. Changing libnl1 by libnl-3-200 libnl-genl-3-200 seams resolve the build problem. For unknown reason the default way to retrieve version mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v \[ does not work in package creation, it return a null value. You can view, comment on, or merge this pull request online at: https://github.com/apache/cloudstack/pull/626 Commit Summary * fix dependency for keepalived from wheezy-backports * fix release version automatically updated using pom.xml * change last owner of change for pgp signature File Changes * M debian/changeloghttps://github.com/apache/cloudstack/pull/626/files#diff-0 (2) * M debian/ruleshttps://github.com/apache/cloudstack/pull/626/files#diff-1 (2) * M tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.shhttps://github.com/apache/cloudstack/pull/626/files#diff-2 (2) Patch Links: * https://github.com/apache/cloudstack/pull/626.patch * https://github.com/apache/cloudstack/pull/626.diff â Reply to this email directly or view it on GitHubhttps://github.com/apache/cloudstack/pull/626. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/626#issuecomment-125573670 @pdion891 Thanks for the PR. I'm still a bit puzzled because the latest build (from 27th July) also failed by did not mention the dependency. Is that okay to merge it and have the other fix (line 22) be done in a different PR? Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/626#discussion_r35639533 --- Diff: debian/rules --- @@ -1,6 +1,6 @@ #!/usr/bin/make -f # -*- makefile -*- -VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v \[) +VERSION := $(shell cat pom.xml |sed '22!d'| cut -d'' -f2 |cut -d'' -f1) --- End diff -- I made a separate PR for 4.4 and master. 4.4 got merged and master didn't.. you can check the PR here: https://github.com/apache/cloudstack/pull/341 It wasn't merged mostly due to aesthetic reasons, although using native tools instead of maven would provide a faster run and should have less compatibility issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/626 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/626#issuecomment-125581299 I will go ahead and apply this PR to fix builds, @rsafonseca can you create a PR with your line that does not look at line 22 ? @wilderrodrigues, I know! it's pretty weird, I'm under the impression the package dependency would have changed over the weekend on wheeze-upsteam ? Anyway, I guest you idea was to go on a more recent version of keepalived. Cheers, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/626#issuecomment-125581160 I'm merging it as the line#22 will be fixed in another PR: https://github.com/apache/cloudstack/commit/e6f81dbbbc8b597755007d9e6d247d2d6ec6c74c#commitcomment-12394387 Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack/pull/626 fix systemvm64template build, fix .deb package creation. - build .deb package job must be change for ``dpkg-buildpackage -uc -us`` ubuntu 14.04 enforce signature of package. CLOUDSTACK-8638 - @wilderrodrigues: this fix dependency for keepalived on building systemvm64template. Changing ``libnl1`` by ``libnl-3-200 libnl-genl-3-200`` seams resolve the build problem. For unknown reason the default way to retrieve version ``mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v \[`` does not work in package creation, it return a null value. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdion891/cloudstack 8675 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/626.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #626 commit 6a01f48e1bb55826790af354686d150b5d440e02 Author: Pierre-Luc Dion pdion...@apache.org Date: 2015-07-28T00:49:40Z fix dependency for keepalived from wheezy-backports commit a3319b76ba04f64f3121470a976799c44a58d53b Author: Pierre-Luc Dion pdion...@apache.org Date: 2015-07-28T01:16:30Z fix release version automatically updated using pom.xml commit d4bfca6330a3fbe50156e9e249a2535e80be9cda Author: Pierre-Luc Dion pdion...@apache.org Date: 2015-07-28T01:20:48Z change last owner of change for pgp signature --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
