[GitHub] cloudstack pull request: reboot much faster in case of storage fai...

2015-04-01 Thread remibergsma
GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/140

reboot much faster in case of storage failure

When storage cannot be reached, it does not make sense to reboot as it will 
try to flush buffers, umount NFS mounts, etc. This will not work and thus cause 
a long delay. With this change, the box will reboot immediately (like pressing 
the reset button).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #140


commit 2b41f98346eaae981238c41f8cc7092ef72492d9
Author: Remi Bergsma 
Date:   2015-04-01T17:45:16Z

reboot much faster in case of storage failure

When storage cannot be reached, it does not make sense to reboot as it will 
try to flush buffers, umount NFS mounts, etc. This will not work and thus cause 
a long delay. With this change, the box will reboot immediately (like pressing 
the reset button).

commit fe53329958e3d835d1b2c24cf78bc1c409cb7ee3
Author: Remi Bergsma 
Date:   2015-04-01T18:04:44Z

Merge pull request #1 from remibergsma/remibergsma-kvmheartbeat

reboot much faster in case of storage failure




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: reboot much faster in case of storage fai...

2015-04-02 Thread runseb
Github user runseb commented on the pull request:

https://github.com/apache/cloudstack/pull/140#issuecomment-6601
  
pinging @llambiel and @pyr @wido  LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: reboot much faster in case of storage fai...

2015-04-02 Thread NuxRo
Github user NuxRo commented on the pull request:

https://github.com/apache/cloudstack/pull/140#issuecomment-8641
  
Looks OK to me, waiting for a dead NFS connection is a PITA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: reboot much faster in case of storage fai...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/140


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: reboot much faster in case of storage fai...

2015-04-02 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/140#issuecomment-88928090
  
Yes, it is, but we should log somewhere. Now a machine just reboots. We 
should send something to syslog prior to rebooting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: reboot much faster in case of storage fai...

2015-04-02 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/140#issuecomment-89006232
  
Ok, check! I will add it like that. 

Although you can never be sure log packets go out over the network because 
if the storage is unavailable due to local host having network issues (or 
switch died, or,...) remote logging is most likely to fail as well. But logging 
locally should succeed this way. :-)

Regards, Remi 

> On 02 Apr 2015, at 17:35, NuxRo  wrote:
> 
> Cool. Then it seems like we have a deal. It remains to test if the actual 
log entry survives the sudden reboot.
> 
> —
> Reply to this email directly or view it on GitHub.
> 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---