[GitHub] cloudstack pull request #1652: Marvin Tests: Fix VPC network offering select...

2016-09-28 Thread PaulAngus
Github user PaulAngus closed the pull request at:

https://github.com/apache/cloudstack/pull/1652


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1652: Marvin Tests: Fix VPC network offering select...

2016-08-19 Thread PaulAngus
GitHub user PaulAngus opened a pull request:

https://github.com/apache/cloudstack/pull/1652

Marvin Tests: Fix VPC network offering selection .

It appears that original code did not expect there to be an alternate 
default VPC offering (Nuage) .
VPC selection uses isdefault=True  which selects the Nuage Network 
offering, stopping the test from being run.
Fix was to look for name="Default VPC Offering" instead.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack vpcselectionfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1652.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1652


commit f1b64a3b509ed59ac0061a4e11dbff34d7ce1ba0
Author: Paul Angus 
Date:   2016-08-19T15:29:22Z

VPC fix network offering.
orginal code did not expect there to be an alternate default (Nuage) there 
when the isdefault=True is used a Nuage Network offering is returned stopping 
the test from being run.
Fix was to look for name="Default VPC Offering"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---