[GitHub] cloudstack pull request #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1779#discussion_r104616622
  
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -2488,6 +2488,22 @@ public boolean maintenanceFailed(final long hostId) {
 }
 
 @Override
+public List listAllHosts(Type type, Long clusterId, Long 
podId, long dcId) {
--- End diff --

Modified. Thank you for your careful observation. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up...

[abhinandanprateek]

Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1779#discussion_r104609930
  
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -2488,6 +2488,22 @@ public boolean maintenanceFailed(final long hostId) {
 }
 
 @Override
+public List listAllHosts(Type type, Long clusterId, Long 
podId, long dcId) {
--- End diff --

make the input params final.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1779

CLOUDSTACK-9610: Disabled Host Keeps Being up status after unmanaging …

Disabled Host Keeps Being up status after unmanaging cluster.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9610

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1779.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1779


commit 2b9e46a293950db7c13bc49c952a0c856bd99c90
Author: Priyank Parihar 
Date:   2016-05-05T10:00:09Z

CLOUDSTACK-9610: Disabled Host Keeps Being up status after unmanging 
cluster.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---