[GitHub] cloudstack pull request #1918: Management Server UI (VM statistics page) CPU...
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1918#discussion_r108463719
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -196,6 +196,7 @@ public UserVmResponse newUserVmResponse(ResponseView
view, String objectName, Us
// stats calculation
VmStats vmStats = ApiDBUtils.getVmStatistics(userVm.getId());
if (vmStats != null) {
+
--- End diff --
I think you can remove this extra line here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1918: Management Server UI (VM statistics page) CPU...
GitHub user jayakarteek opened a pull request: https://github.com/apache/cloudstack/pull/1918 Management Server UI (VM statistics page) CPU Utilized value is incorrect. VMware CPU Utilised value is in Mhz , in MS value is displayed directly. If CPU utilised is 500Mhz, UI value is displayed as 500 % Planned to restrict changes in resource layer VmwareResource.java, but cpu allocated to VM by VMware is not same as allocated in the service offering. If CPU limit flag is set to false in service offerings the Allocated CPU can go beyond what is assigned. So picking actual user assigned Total CPU from database for calculating percentage. It is expected that percentage would go beyond 100 percent. so changes are made in UserVmJoinDaoImpl.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/jayakarteek/cloudstack cloudstack-9762 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1918.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1918 commit 58d721603300b236bded82147363a06e80ecf67a Author: Jayakarteek Vasana Date: 2017-01-30T09:06:03Z Bug fix for CLOUDSTACK-9762 Management Server UI (VM statistics page) CPU Utilized value is incorrect --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
