Re: [PR] Add hostname annotation to set loadbalancer ingress hostname [cloudstack-kubernetes-provider]

2024-05-28 Thread via GitHub


weizhouapache merged PR #48:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/48


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add hostname annotation to set loadbalancer ingress hostname [cloudstack-kubernetes-provider]

2024-05-22 Thread via GitHub


vishesh92 commented on PR #48:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/48#issuecomment-2125262104

   @weizhouapache I am not able to reproduce the issue, but I can verify the 
functionality is working as expected. For why hostname is required as part of 
the loadbalancerStatus, check: 
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#loadbalanceringress-v1-core


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add hostname annotation to set loadbalancer ingress hostname [cloudstack-kubernetes-provider]

2024-05-22 Thread via GitHub


weizhouapache commented on PR #48:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/48#issuecomment-2124138528

   > Did some manual testing. After this change, I have verified that the 
service created has external IP equal to hostname set in 
`service.beta.kubernetes.io/cloudstack-load-balancer-hostname`. And the same 
hostname is also set in the status of the service.
   
   cool, thanks @vishesh92 
   can you test ipvs mode if the issue can be reproduced and fixed by this 
change ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add hostname annotation to set loadbalancer ingress hostname [cloudstack-kubernetes-provider]

2024-05-22 Thread via GitHub


vishesh92 commented on PR #48:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/48#issuecomment-2124115258

   Did some testing. After this change, I have verified that the service 
created has external IP equal to hostname set in 
`service.beta.kubernetes.io/cloudstack-load-balancer-hostname`. And the same 
hostname is also set in the status of the service.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org