Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2168415802 @vishesh92 issues fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640111066
##
cloudstack/resource_cloudstack_network.go:
##
@@ -176,14 +175,12 @@ func resourceCloudStackNetworkCreate(d
*schema.ResourceData, meta interface{}) e
return e.Error()
}
- // Compute/set the display text
- displaytext, ok := d.GetOk("display_text")
- if !ok {
- displaytext = name
- }
-
// Create a new parameter struct
- p := cs.Network.NewCreateNetworkParams(displaytext.(string), name,
networkofferingid, zoneid)
+ p := cs.Network.NewCreateNetworkParams(name, networkofferingid, zoneid)
+
+ if displaytext, ok := d.GetOk("display_text"); ok {
+ p.SetDisplaytext(displaytext.(string))
Review Comment:
Fixed, I've added an `else` condition to set the display text with the
`name` in case the `display_text` param is not set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640109567
##
cloudstack/resource_cloudstack_disk_test.go:
##
@@ -228,6 +228,7 @@ resource "cloudstack_disk" "foo" {
const testAccCloudStackDisk_deviceID = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fixed
##
cloudstack/resource_cloudstack_firewall_test.go:
##
@@ -188,14 +188,15 @@ func testAccCheckCloudStackFirewallDestroy(s
*terraform.State) error {
const testAccCloudStackFirewall_basic = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fixed
##
cloudstack/resource_cloudstack_firewall_test.go:
##
@@ -213,14 +214,15 @@ resource "cloudstack_firewall" "foo" {
const testAccCloudStackFirewall_update = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640110316
##
cloudstack/resource_cloudstack_ipaddress_test.go:
##
@@ -137,14 +137,15 @@ func testAccCheckCloudStackIPAddressDestroy(s
*terraform.State) error {
const testAccCloudStackIPAddress_basic = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fixed
##
cloudstack/resource_cloudstack_ipaddress_test.go:
##
@@ -173,14 +174,15 @@ resource "cloudstack_vpc" "foo" {
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640110141
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -404,16 +409,17 @@ resource "cloudstack_instance" "foobar" {
name = "terraform-test"
display_name = "terraform-test"
service_offering= "Small Instance"
- network_id = "${cloudstack_network.foo.id}"
+ network_id = cloudstack_network.foo.id
template = "CentOS 5.6 (64-bit) no GUI (Simulator)"
zone = "Sandbox-simulator"
- keypair = "${cloudstack_ssh_keypair.foo.name}"
+ keypair = cloudstack_ssh_keypair.foo.name
Review Comment:
fixed
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -404,16 +409,17 @@ resource "cloudstack_instance" "foobar" {
name = "terraform-test"
display_name = "terraform-test"
service_offering= "Small Instance"
- network_id = "${cloudstack_network.foo.id}"
+ network_id = cloudstack_network.foo.id
template = "CentOS 5.6 (64-bit) no GUI (Simulator)"
zone = "Sandbox-simulator"
- keypair = "${cloudstack_ssh_keypair.foo.name}"
+ keypair = cloudstack_ssh_keypair.foo.name
expunge = true
}`
const testAccCloudStackInstance_project = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640109989
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -372,6 +375,7 @@ resource "cloudstack_instance" "foobar" {
const testAccCloudStackInstance_fixedIP = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fixed
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -391,6 +395,7 @@ resource "cloudstack_instance" "foobar" {
const testAccCloudStackInstance_keyPair = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640109823
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -312,6 +312,7 @@ func testAccCheckCloudStackInstanceDestroy(s
*terraform.State) error {
const testAccCloudStackInstance_basic = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fixed
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -334,6 +335,7 @@ resource "cloudstack_instance" "foobar" {
const testAccCloudStackInstance_stopped = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fixed
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -353,6 +355,7 @@ resource "cloudstack_instance" "foobar" {
const testAccCloudStackInstance_renameAndResize = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639582074
##
cloudstack/provider_test.go:
##
@@ -20,56 +20,79 @@
package cloudstack
import (
+ "context"
"os"
"testing"
- "github.com/hashicorp/terraform/helper/schema"
- "github.com/hashicorp/terraform/terraform"
+ "github.com/hashicorp/terraform-plugin-go/tfprotov5"
+ "github.com/hashicorp/terraform-plugin-mux/tf5muxserver"
+ "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+ "github.com/hashicorp/terraform-plugin-testing/helper/resource"
)
-var testAccProviders map[string]terraform.ResourceProvider
+var testAccProviders map[string]*schema.Provider
var testAccProvider *schema.Provider
var cloudStackTemplateURL = os.Getenv("CLOUDSTACK_TEMPLATE_URL")
func init() {
- testAccProvider = Provider().(*schema.Provider)
- testAccProviders = map[string]terraform.ResourceProvider{
+ testAccProvider = New()
+ testAccProviders = map[string]*schema.Provider{
"cloudstack": testAccProvider,
}
}
func TestProvider(t *testing.T) {
- if err := Provider().(*schema.Provider).InternalValidate(); err != nil {
+ if err := New().InternalValidate(); err != nil {
t.Fatalf("err: %s", err)
}
}
func TestProvider_impl(t *testing.T) {
- var _ terraform.ResourceProvider = Provider()
+ var _ *schema.Provider = New()
}
-func testSetValueOnResourceData(t *testing.T) {
Review Comment:
those functions were not in use @vishesh92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
vishesh92 commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2167283327 @fabiomatavelli I have reviewed the PR. Changes looks good. I have left comments where I have some questions about the changes. Apart from this, there are sinor code style issues related to indentation at some places which is due to tabs and spaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639312096
##
cloudstack/resource_cloudstack_network.go:
##
@@ -176,14 +175,12 @@ func resourceCloudStackNetworkCreate(d
*schema.ResourceData, meta interface{}) e
return e.Error()
}
- // Compute/set the display text
- displaytext, ok := d.GetOk("display_text")
- if !ok {
- displaytext = name
- }
-
// Create a new parameter struct
- p := cs.Network.NewCreateNetworkParams(displaytext.(string), name,
networkofferingid, zoneid)
+ p := cs.Network.NewCreateNetworkParams(name, networkofferingid, zoneid)
+
+ if displaytext, ok := d.GetOk("display_text"); ok {
+ p.SetDisplaytext(displaytext.(string))
Review Comment:
@fabiomatavelli We are changing the existing behavior of terraform provider
here.
Previously we used to set the value of `displaytext` same as `name` if
`displaytext` wasn't set.
This could break existing user's setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639297478
##
cloudstack/resource_cloudstack_ipaddress_test.go:
##
@@ -137,14 +137,15 @@ func testAccCheckCloudStackIPAddressDestroy(s
*terraform.State) error {
const testAccCloudStackIPAddress_basic = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fix indentation
##
cloudstack/resource_cloudstack_ipaddress_test.go:
##
@@ -173,14 +174,15 @@ resource "cloudstack_vpc" "foo" {
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fix indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639297273
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -404,16 +409,17 @@ resource "cloudstack_instance" "foobar" {
name = "terraform-test"
display_name = "terraform-test"
service_offering= "Small Instance"
- network_id = "${cloudstack_network.foo.id}"
+ network_id = cloudstack_network.foo.id
template = "CentOS 5.6 (64-bit) no GUI (Simulator)"
zone = "Sandbox-simulator"
- keypair = "${cloudstack_ssh_keypair.foo.name}"
+ keypair = cloudstack_ssh_keypair.foo.name
Review Comment:
fix indentation
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -404,16 +409,17 @@ resource "cloudstack_instance" "foobar" {
name = "terraform-test"
display_name = "terraform-test"
service_offering= "Small Instance"
- network_id = "${cloudstack_network.foo.id}"
+ network_id = cloudstack_network.foo.id
template = "CentOS 5.6 (64-bit) no GUI (Simulator)"
zone = "Sandbox-simulator"
- keypair = "${cloudstack_ssh_keypair.foo.name}"
+ keypair = cloudstack_ssh_keypair.foo.name
expunge = true
}`
const testAccCloudStackInstance_project = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fix indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639297083
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -353,6 +355,7 @@ resource "cloudstack_instance" "foobar" {
const testAccCloudStackInstance_renameAndResize = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fix indentation
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -372,6 +375,7 @@ resource "cloudstack_instance" "foobar" {
const testAccCloudStackInstance_fixedIP = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fix indentation
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -391,6 +395,7 @@ resource "cloudstack_instance" "foobar" {
const testAccCloudStackInstance_keyPair = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fix indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639296948
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -312,6 +312,7 @@ func testAccCheckCloudStackInstanceDestroy(s
*terraform.State) error {
const testAccCloudStackInstance_basic = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fix indentation
##
cloudstack/resource_cloudstack_instance_test.go:
##
@@ -334,6 +335,7 @@ resource "cloudstack_instance" "foobar" {
const testAccCloudStackInstance_stopped = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fix indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639296109
##
cloudstack/resource_cloudstack_firewall_test.go:
##
@@ -188,14 +188,15 @@ func testAccCheckCloudStackFirewallDestroy(s
*terraform.State) error {
const testAccCloudStackFirewall_basic = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fix indentation
##
cloudstack/resource_cloudstack_firewall_test.go:
##
@@ -213,14 +214,15 @@ resource "cloudstack_firewall" "foo" {
const testAccCloudStackFirewall_update = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
fix indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639294876
##
cloudstack/resource_cloudstack_disk_test.go:
##
@@ -228,6 +228,7 @@ resource "cloudstack_disk" "foo" {
const testAccCloudStackDisk_deviceID = `
resource "cloudstack_network" "foo" {
name = "terraform-network"
+ display_text = "terraform-network"
Review Comment:
some weird indentation here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
vishesh92 commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639289992
##
cloudstack/provider_test.go:
##
@@ -20,56 +20,79 @@
package cloudstack
import (
+ "context"
"os"
"testing"
- "github.com/hashicorp/terraform/helper/schema"
- "github.com/hashicorp/terraform/terraform"
+ "github.com/hashicorp/terraform-plugin-go/tfprotov5"
+ "github.com/hashicorp/terraform-plugin-mux/tf5muxserver"
+ "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+ "github.com/hashicorp/terraform-plugin-testing/helper/resource"
)
-var testAccProviders map[string]terraform.ResourceProvider
+var testAccProviders map[string]*schema.Provider
var testAccProvider *schema.Provider
var cloudStackTemplateURL = os.Getenv("CLOUDSTACK_TEMPLATE_URL")
func init() {
- testAccProvider = Provider().(*schema.Provider)
- testAccProviders = map[string]terraform.ResourceProvider{
+ testAccProvider = New()
+ testAccProviders = map[string]*schema.Provider{
"cloudstack": testAccProvider,
}
}
func TestProvider(t *testing.T) {
- if err := Provider().(*schema.Provider).InternalValidate(); err != nil {
+ if err := New().InternalValidate(); err != nil {
t.Fatalf("err: %s", err)
}
}
func TestProvider_impl(t *testing.T) {
- var _ terraform.ResourceProvider = Provider()
+ var _ *schema.Provider = New()
}
-func testSetValueOnResourceData(t *testing.T) {
Review Comment:
Why were these tests removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
vishesh92 commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2166411819 @fabiomatavelli @poddm I am running a little busy these days. Let me review this PR by next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2155673023 @poddm @rohityadavcloud what is the next step then? Can we merge it? It's all good to be merged so we can continue working on other PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
poddm commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2155146161 > @poddm @fabiomatavelli @rohityadavcloud What are we waiting on to get this updated? I was looking into testing some other stuff and noticed the version of the cloudstack-go version is really old in the terraform provider (2.13.2) and was trying to get that resolved locally for testing things and then remembered this was out here. > >  > >  I approved it awhile back. All of my open PRs are dependent on updating the cloudstack-go SDK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
CodeBleu commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2155132268 @poddm @fabiomatavelli @rohityadavcloud What are we waiting on to get this updated? I was looking into testing some other stuff and noticed the version of the cloudstack-go version is really old in the terraform provider (2.13.2) and was trying to get that resolved locally for testing things and then remembered this was out here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2098846338 @rohityadavcloud thanks, it's working now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
rohityadavcloud commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2098789039 @fabiomatavelli the infra team has enabled the action, can you try again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
rohityadavcloud closed pull request #71: Update SDKs URL: https://github.com/apache/cloudstack-terraform-provider/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2081447173 @rohityadavcloud those are the ones that we are using in the acceptance test CI: - `actions/setup-go@v5` - `hashicorp/setup-terraform@v3` - `opentofu/setup-opentofu@v1` From the error message that we got, the only one not allowed was the `setup-opentofu`, as you can see [here](https://github.com/apache/cloudstack-terraform-provider/actions/runs/8859287862). Meanwhile, I found that the commit hash is allowed to be used (`*/*@[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]+`), instead of the version. I've pushed the `setup-opentofu` with the commit hash instead and it should be able to run now. If you can allow the actions again, we can test it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
rohityadavcloud commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2081392297 @fabiomatavelli the ASF infra doesn't allow any actions to be used, if it's not running, likely it's not allow. Can you send me (list of?) all the GitHub Actions you want to use, I can request ASF infra to add/allow them for use in apache/cloudstack* repos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2080915377 Looks like the `opentofu/setup-opentofu@v1` action is not allowed. Is it possible to allow it @rohityadavcloud ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2080450193 @rohityadavcloud I've added the OpenTofu acceptance test CI also as suggested by @CodeBleu . If you can allow the actions again so we can check the run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1581799304
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLOUDSTACK_API_URL -k $CLOUDSTACK_API_KEY -s
$CLOUDSTACK_SECRET_KEY -o json create project name=terraform
displaytext=terraform
+ - uses: hashicorp/setup-terraform@v2
+with:
+ terraform_version: ${{ matrix.terraform-version }}
+ terraform_wrapper: false
- name: Run acceptance test
run: |
make testacc
services:
cloudstack-simulator:
-image: apache/cloudstack-simulator:${{ matrix.cloudstack_version }}
+image: apache/cloudstack-simulator:${{ matrix.cloudstack-version }}
ports:
- 8080:5050
strategy:
fail-fast: false
matrix:
-cloudstack_version:
+terraform-version:
+ - '0.12.*'
+ - '0.13.*'
+ - '0.14.*'
+ - '0.15.*'
+ - '1.0.*'
+ - '1.1.*'
+ - '1.2.*'
+ - '1.3.*'
+ - '1.4.*'
+ - '1.5.*'
+ - '1.6.*'
+ - '1.7.*'
Review Comment:
good catch @CodeBleu, I've added it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
CodeBleu commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1581168828
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLOUDSTACK_API_URL -k $CLOUDSTACK_API_KEY -s
$CLOUDSTACK_SECRET_KEY -o json create project name=terraform
displaytext=terraform
+ - uses: hashicorp/setup-terraform@v2
+with:
+ terraform_version: ${{ matrix.terraform-version }}
+ terraform_wrapper: false
- name: Run acceptance test
run: |
make testacc
services:
cloudstack-simulator:
-image: apache/cloudstack-simulator:${{ matrix.cloudstack_version }}
+image: apache/cloudstack-simulator:${{ matrix.cloudstack-version }}
ports:
- 8080:5050
strategy:
fail-fast: false
matrix:
-cloudstack_version:
+terraform-version:
+ - '0.12.*'
+ - '0.13.*'
+ - '0.14.*'
+ - '0.15.*'
+ - '1.0.*'
+ - '1.1.*'
+ - '1.2.*'
+ - '1.3.*'
+ - '1.4.*'
+ - '1.5.*'
+ - '1.6.*'
+ - '1.7.*'
Review Comment:
@fabiomatavelli what about Tofu versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
rohityadavcloud commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2078833695 Thanks @fabiomatavelli tests kicked, let's see what Github actions do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2078807528 Done @rohityadavcloud -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1580587876
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLOUDSTACK_API_URL -k $CLOUDSTACK_API_KEY -s
$CLOUDSTACK_SECRET_KEY -o json create project name=terraform
displaytext=terraform
+ - uses: hashicorp/setup-terraform@v2
+with:
+ terraform_version: ${{ matrix.terraform-version }}
+ terraform_wrapper: false
- name: Run acceptance test
run: |
make testacc
services:
cloudstack-simulator:
-image: apache/cloudstack-simulator:${{ matrix.cloudstack_version }}
+image: apache/cloudstack-simulator:${{ matrix.cloudstack-version }}
ports:
- 8080:5050
strategy:
fail-fast: false
matrix:
-cloudstack_version:
+terraform-version:
+ - '0.12.*'
+ - '0.13.*'
+ - '0.14.*'
+ - '0.15.*'
+ - '1.0.*'
+ - '1.1.*'
+ - '1.2.*'
+ - '1.3.*'
+ - '1.4.*'
+ - '1.5.*'
+ - '1.6.*'
+ - '1.7.*'
Review Comment:
Ok, I've removed the `<= 1.6` versions of Terraform then, based on
https://endoflife.date/terraform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
rohityadavcloud commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2078607496 @fabiomatavelli can you resolve the conflicts, thanks. I've approved the Github actions to start running tests, thanks for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
poddm commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1580420791
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLOUDSTACK_API_URL -k $CLOUDSTACK_API_KEY -s
$CLOUDSTACK_SECRET_KEY -o json create project name=terraform
displaytext=terraform
+ - uses: hashicorp/setup-terraform@v2
+with:
+ terraform_version: ${{ matrix.terraform-version }}
+ terraform_wrapper: false
- name: Run acceptance test
run: |
make testacc
services:
cloudstack-simulator:
-image: apache/cloudstack-simulator:${{ matrix.cloudstack_version }}
+image: apache/cloudstack-simulator:${{ matrix.cloudstack-version }}
ports:
- 8080:5050
strategy:
fail-fast: false
matrix:
-cloudstack_version:
+terraform-version:
+ - '0.12.*'
+ - '0.13.*'
+ - '0.14.*'
+ - '0.15.*'
+ - '1.0.*'
+ - '1.1.*'
+ - '1.2.*'
+ - '1.3.*'
+ - '1.4.*'
+ - '1.5.*'
+ - '1.6.*'
+ - '1.7.*'
Review Comment:
only non EOL. I'd like to help/see more iterations pushed out vs.
supporting EOL code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1527183574
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLOUDSTACK_API_URL -k $CLOUDSTACK_API_KEY -s
$CLOUDSTACK_SECRET_KEY -o json create project name=terraform
displaytext=terraform
+ - uses: hashicorp/setup-terraform@v2
+with:
+ terraform_version: ${{ matrix.terraform-version }}
+ terraform_wrapper: false
- name: Run acceptance test
run: |
make testacc
services:
cloudstack-simulator:
-image: apache/cloudstack-simulator:${{ matrix.cloudstack_version }}
+image: apache/cloudstack-simulator:${{ matrix.cloudstack-version }}
ports:
- 8080:5050
strategy:
fail-fast: false
matrix:
-cloudstack_version:
+terraform-version:
+ - '0.12.*'
+ - '0.13.*'
+ - '0.14.*'
+ - '0.15.*'
+ - '1.0.*'
+ - '1.1.*'
+ - '1.2.*'
+ - '1.3.*'
+ - '1.4.*'
+ - '1.5.*'
+ - '1.6.*'
+ - '1.7.*'
Review Comment:
Does it make sense to test all the versions of terraform or only the non
[EOL](https://support.hashicorp.com/hc/en-us/articles/360021185113-Support-Period-and-End-of-Life-EOL-Policy)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on code in PR #71:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1527183574
##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
- name: Create extra resources
run: |
cmk -u $CLOUDSTACK_API_URL -k $CLOUDSTACK_API_KEY -s
$CLOUDSTACK_SECRET_KEY -o json create project name=terraform
displaytext=terraform
+ - uses: hashicorp/setup-terraform@v2
+with:
+ terraform_version: ${{ matrix.terraform-version }}
+ terraform_wrapper: false
- name: Run acceptance test
run: |
make testacc
services:
cloudstack-simulator:
-image: apache/cloudstack-simulator:${{ matrix.cloudstack_version }}
+image: apache/cloudstack-simulator:${{ matrix.cloudstack-version }}
ports:
- 8080:5050
strategy:
fail-fast: false
matrix:
-cloudstack_version:
+terraform-version:
+ - '0.12.*'
+ - '0.13.*'
+ - '0.14.*'
+ - '0.15.*'
+ - '1.0.*'
+ - '1.1.*'
+ - '1.2.*'
+ - '1.3.*'
+ - '1.4.*'
+ - '1.5.*'
+ - '1.6.*'
+ - '1.7.*'
Review Comment:
Does it make sense to test all the versions of terraform or only the non EOL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2002004950 > @fabiomatavelli TF Plugin be a v0.7.0 milestone? Could be. Also with [muxing](https://developer.hashicorp.com/terraform/plugin/framework/migrating#muxing) the migration can be partial, doing few resources/datasources on each release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
CodeBleu commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2000607396 > @CodeBleu I was looking into migrating directly to the terraform plugin framework and it will require a huge effort for that. It will be not as simple as migrating from v1 to v2. So my proposal is to continue the migration to sdkv2 to, at least, have a more recent version of the SDK, then start working on the migration to the plugin framework. > > I've already implemented some new things in my contribution, like muxing the provider and the terraform plugin testing in tests, so then it will be easier to migrate to the plugin framework. @fabiomatavelli TF Plugin be a v0.7.0 milestone? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2000343098 @vishesh92 @rohityadavcloud I've added another matrix to the acceptance test so multiple versions of terraform can be tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2000341643 @CodeBleu I was looking into migrating directly to the terraform plugin framework and it will require a huge effort for that. It will be not as simple as migrating from v1 to v2. So my proposal is to continue the migration to sdkv2 to, at least, have a more recent version of the SDK, then start working on the migration to the plugin framework. I've already implemented some new things in my contribution, like muxing the provider and the terraform plugin testing in tests, so then it will be easier to migrate to the plugin framework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1975257114 Indeed, I haven't seen the Terraform Plugin Framework at the time I did it. If you think it is better to go straight to it, then I can close this one @CodeBleu @poddm as I'm not sure I'll have time to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
vishesh92 closed pull request #71: Update SDKs URL: https://github.com/apache/cloudstack-terraform-provider/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
CodeBleu commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1972063395 > > If there is going to be SDK updates, why not just go to the [Terraform Plugin Framework](https://developer.hashicorp.com/terraform/plugin/framework/migrating) instead? > > I believe when these changes were created Hashcorp was still recommending SDKv2. Yes, that was my understanding. I was just wondering if it's worth still merging this, or move to the Terraform Plugin Framework instead. I figured if there was going to be effort to merge in a "refactor", might as well be the latest method, don't you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
poddm commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1971724096 > If there is going to be SDK updates, why not just go to the [Terraform Plugin Framework](https://developer.hashicorp.com/terraform/plugin/framework/migrating) instead? I believe when these changes were created Hashcorp was still recommending SDKv2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
rohityadavcloud commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1953109896 Rekicking build check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
rohityadavcloud closed pull request #71: Update SDKs URL: https://github.com/apache/cloudstack-terraform-provider/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
CodeBleu commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1947788692 If there is going to be SDK updates, why not just go to the [Terraform Plugin Framework](https://developer.hashicorp.com/terraform/plugin/framework/migrating) instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update SDKs [cloudstack-terraform-provider]
poddm commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-1830638315 resolves https://github.com/apache/cloudstack-terraform-provider/issues/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
