Fwd: New Defects reported by Coverity Scan for cloudstack
Ritu,
Coverity identified a number of issues with the brocade plugin. Could you have
a look at them and post the fixes on the review board?
If you need additional details on the findings you can request coverity access
here : https://scan.coverity.com/projects/943
Cheers,
Hugo
Begin forwarded message:
From: scan-ad...@coverity.com
Subject: New Defects reported by Coverity Scan for cloudstack
Date: 29 juli 2014 15:22:48 CEST
Hi,
Please find the latest report on new defect(s) introduced to cloudstack found
with Coverity Scan.
Defect(s) Reported-by: Coverity Scan
Showing 7 of 7 defect(s)
** CID 1229114: Resource leak (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
509 in
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
513 in
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
** CID 1229113: Resource leak (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
457 in
com.cloud.network.brocade.BrocadeVcsApi.executeRetreiveStatus(java.lang.String)()
** CID 1229115: Dereference before null check (REVERSE_INULL)
/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
6299 in
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.execute(com.cloud.agent.api.CreateVMSnapshotCommand)()
** CID 1229121: UrF: Unread field (FB.URF_UNREAD_FIELD)
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
67 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
71 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
55 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
59 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
63 in ()
** CID 1229120: WMI: Inefficient Map Iterator (FB.WMI_WRONG_MAP_ITERATOR)
/engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java: 478 in
com.cloud.capacity.dao.CapacityDaoImpl.findCapacityBy(java.lang.Integer,
java.lang.Long, java.lang.Long, java.lang.Long)()
** CID 1229119: DLS: Dead local store (FB.DLS_DEAD_LOCAL_STORE)
/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
4438 in
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.initialize()()
** CID 1229116: REC: RuntimeException capture (FB.REC_CATCH_EXCEPTION)
/engine/schema/src/com/cloud/storage/dao/VMTemplatePoolDaoImpl.java: 189 in
com.cloud.storage.dao.VMTemplatePoolDaoImpl.listByTemplateStatus(long, long,
long, com.cloud.storage.VMTemplateStorageResourceAssoc$Status)()
*** CID 1229114: Resource leak (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
509 in
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
503 try {
504
505 BufferedReader rd = new BufferedReader(new
InputStreamReader(response.getEntity().getContent(),
Charset.forName(UTF-8)));
506
507 StringBuffer result = new StringBuffer();
508 String line = ;
CID 1229114: Resource leak (RESOURCE_LEAK)
Variable rd going out of scope leaks the resource it refers to.
509 while ((line = rd.readLine()) != null) {
510 result.append(line);
511 }
512
513 return result.toString();
514 } catch (IOException e) {
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
513 in
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
507 StringBuffer result = new StringBuffer();
508 String line = ;
509 while ((line = rd.readLine()) != null) {
510 result.append(line);
511 }
512
CID 1229114: Resource leak (RESOURCE_LEAK)
Variable rd going out of scope leaks the resource it refers to.
513 return result.toString();
514 } catch (IOException e) {
515 s_logger.debug(Error while loading response body,
e);
516 }
517 }
518 return null;
519 }
520
Fwd: New Defects reported by Coverity Scan for cloudstack
FYI
Begin forwarded message:
From: scan-ad...@coverity.com
Subject: New Defects reported by Coverity Scan for cloudstack
Date: 6 juni 2014 13:40:40 CEST
Hi,
Please find the latest report on new defect(s) introduced to cloudstack found
with Coverity Scan.
Defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1220836: Dereference after null check (FORWARD_NULL)
/server/src/com/cloud/hypervisor/HypervisorGuruBase.java: 116 in
com.cloud.hypervisor.HypervisorGuruBase.toNicTO(com.cloud.vm.NicProfile)()
** CID 1220837: Resource leak (RESOURCE_LEAK)
/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java: 301 in
com.cloud.upgrade.dao.Upgrade430to440.updateVlanUris(java.sql.Connection)()
/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java: 321 in
com.cloud.upgrade.dao.Upgrade430to440.updateVlanUris(java.sql.Connection)()
/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java: 301 in
com.cloud.upgrade.dao.Upgrade430to440.updateVlanUris(java.sql.Connection)()
/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java: 321 in
com.cloud.upgrade.dao.Upgrade430to440.updateVlanUris(java.sql.Connection)()
*** CID 1220836: Dereference after null check (FORWARD_NULL)
/server/src/com/cloud/hypervisor/HypervisorGuruBase.java: 116 in
com.cloud.hypervisor.HypervisorGuruBase.toNicTO(com.cloud.vm.NicProfile)()
110 }
111
112 //check whether the this nic has secondary ip addresses set
113 //set nic secondary ip address in NicTO which are used for
security group
114 // configuration. Use full when vm stop/start
115 ListString secIps = null;
CID 1220836: Dereference after null check (FORWARD_NULL)
Calling a method on null object nicVO.
116 if (nicVO.getSecondaryIp()) {
117 secIps =
_nicSecIpDao.getSecondaryIpAddressesForNic(nicVO.getId());
118 }
119 to.setNicSecIps(secIps);
120 return to;
121 }
*** CID 1220837: Resource leak (RESOURCE_LEAK)
/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java: 301 in
com.cloud.upgrade.dao.Upgrade430to440.updateVlanUris(java.sql.Connection)()
295 long id = rs.getLong(1);
296 String vlan = rs.getString(2);
297 if (vlan == null || .equals(vlan)) {
298 continue;
299 }
300 String vlanUri =
BroadcastDomainType.Vlan.toUri(vlan).toString();
CID 1220837: Resource leak (RESOURCE_LEAK)
Overwriting pstmt in pstmt = conn.prepareStatement(update
`cloud`.`vlan` set vlan_id=? where id=?) leaks the resource that pstmt
refers to.
301 pstmt = conn.prepareStatement(update `cloud`.`vlan`
set vlan_id=? where id=?);
302 pstmt.setString(1, vlanUri);
303 pstmt.setLong(2, id);
304 pstmt.executeUpdate();
305 }
306 } catch (SQLException e) {
/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java: 321 in
com.cloud.upgrade.dao.Upgrade430to440.updateVlanUris(java.sql.Connection)()
315 pstmt.close();
316 }
317 } catch (SQLException e) {
318 }
319 }
320 s_logger.debug(Done updateing vlan URIs);
CID 1220837: Resource leak (RESOURCE_LEAK)
Variable pstmt going out of scope leaks the resource it refers to.
321 }
322
323 @Override
324 public File[] getCleanupScripts() {
325 String script = Script.findScript(,
db/schema-430to440-cleanup.sql);
326 if (script == null) {
/engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java: 301 in
com.cloud.upgrade.dao.Upgrade430to440.updateVlanUris(java.sql.Connection)()
295 long id = rs.getLong(1);
296 String vlan = rs.getString(2);
297 if (vlan == null || .equals(vlan)) {
298 continue;
299 }
300 String vlanUri =
BroadcastDomainType.Vlan.toUri(vlan).toString();
CID 1220837: Resource leak (RESOURCE_LEAK)
Overwriting pstmt in pstmt = conn.prepareStatement(update
`cloud`.`vlan` set vlan_id=? where id=?) leaks the resource that pstmt
refers to.
301 pstmt = conn.prepareStatement(update `cloud`.`vlan`
set vlan_id=? where id=?);
302 pstmt.setString(1, vlanUri);
303 pstmt.setLong(2, id);
304 pstmt.executeUpdate();
305 }
306
Fwd: New Defects reported by Coverity Scan for cloudstack
FYI Sent from my iPhone Begin forwarded message: From: scan-ad...@coverity.com Date: 24 januari 2014 13:22:59 CET Subject: New Defects reported by Coverity Scan for cloudstack Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 20 of 52 defect(s) ** CID 1164002: Logically dead code (DEADCODE) /server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java: 388 in com.cloud.api.query.dao.TemplateJoinDaoImpl.searchByTemplateZonePair(java.lang.Boolean, java.lang.String[])() ** CID 1164018: Explicit null dereferenced (FORWARD_NULL) /server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: 730 in com.cloud.vm.snapshot.VMSnapshotManagerImpl.deleteAllVMSnapshots(long, com.cloud.vm.snapshot.VMSnapshot$Type)() ** CID 1164020: Explicit null dereferenced (FORWARD_NULL) /server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: 478 in com.cloud.vm.snapshot.VMSnapshotManagerImpl.deleteVMSnapshot(java.lang.Long)() ** CID 1164017: Explicit null dereferenced (FORWARD_NULL) /server/src/com/cloud/storage/VolumeApiServiceImpl.java: 1619 in com.cloud.storage.VolumeApiServiceImpl.migrateVolume(org.apache.cloudstack.api.command.user.volume.MigrateVolumeCmd)() ** CID 1164019: Explicit null dereferenced (FORWARD_NULL) /server/src/com/cloud/storage/VolumeApiServiceImpl.java: 1721 in com.cloud.storage.VolumeApiServiceImpl.takeSnapshot(java.lang.Long, java.lang.Long, java.lang.Long, com.cloud.user.Account, boolean)() ** CID 1164016: Dereference after null check (FORWARD_NULL) /server/src/com/cloud/storage/VolumeApiServiceImpl.java: 2033 in com.cloud.storage.VolumeApiServiceImpl.sendAttachVolumeCommand(com.cloud.vm.UserVmVO, com.cloud.storage.VolumeVO, java.lang.Long)() ** CID 1164013: Dereference after null check (FORWARD_NULL) /plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java: 535 in org.apache.cloudstack.network.contrail.model.VirtualNetworkModel.compare(org.apache.cloudstack.network.contrail.model.ModelController, org.apache.cloudstack.network.contrail.model.ModelObject)() ** CID 1164012: Explicit null dereferenced (FORWARD_NULL) /plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java: 1730 in com.cloud.hypervisor.hyperv.resource.HypervDirectConnectResource.postHttpRequest(java.lang.String, java.net.URI)() ** CID 1164009: Explicit null dereferenced (FORWARD_NULL) /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 3321 in com.cloud.vm.VirtualMachineManagerImpl.removeNicFromVm(com.cloud.vm.VirtualMachine, com.cloud.vm.Nic)() ** CID 1164010: Explicit null dereferenced (FORWARD_NULL) /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 3209 in com.cloud.vm.VirtualMachineManagerImpl.addVmToNetwork(com.cloud.vm.VirtualMachine, com.cloud.network.Network, com.cloud.vm.NicProfile)() ** CID 1164015: Explicit null dereferenced (FORWARD_NULL) /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 1308 in com.cloud.vm.VirtualMachineManagerImpl.advanceStop(java.lang.String, boolean)() ** CID 1164011: Explicit null dereferenced (FORWARD_NULL) /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 3830 in com.cloud.vm.VirtualMachineManagerImpl.reConfigureVm(java.lang.String, com.cloud.offering.ServiceOffering, boolean)() ** CID 1164008: Explicit null dereferenced (FORWARD_NULL) /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 1611 in com.cloud.vm.VirtualMachineManagerImpl.storageMigration(java.lang.String, com.cloud.storage.StoragePool)() ** CID 1164014: Explicit null dereferenced (FORWARD_NULL) /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 1985 in com.cloud.vm.VirtualMachineManagerImpl.migrateWithStorage(java.lang.String, long, long, java.util.Map)() ** CID 1164007: Explicit null dereferenced (FORWARD_NULL) /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 2279 in com.cloud.vm.VirtualMachineManagerImpl.advanceReboot(java.lang.String, java.util.Map)() ** CID 1164006: Explicit null dereferenced (FORWARD_NULL) /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 1703 in com.cloud.vm.VirtualMachineManagerImpl.migrate(java.lang.String, long, com.cloud.deploy.DeployDestination)() ** CID 1164005: Explicit null dereferenced (FORWARD_NULL) /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 3571 in com.cloud.vm.VirtualMachineManagerImpl.migrateForScale(java.lang.String, long, com.cloud.deploy.DeployDestination, java.lang.Long)() ** CID 1164004: Explicit null dereferenced (FORWARD_NULL) /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 766 in
Fwd: New Defects reported by Coverity Scan for cloudstack
FYI Sent from my iPhone Begin forwarded message: From: scan-ad...@coverity.com Date: 29 november 2013 14:39:56 CET Subject: New Defects reported by Coverity Scan for cloudstack Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) ** CID 1116269: Nesting level does not match indentation (NESTING_INDENT_MISMATCH) /awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java: 124 in com.cloud.bridge.service.controller.s3.ServiceProvider.getManagementHostId()() ** CID 1133706: Dereference after null check (FORWARD_NULL) /server/src/com/cloud/vm/UserVmManagerImpl.java: 2803 in com.cloud.vm.UserVmManagerImpl$3.doInTransaction(com.cloud.utils.db.TransactionStatus)() ** CID 1133705: Resource leak on an exceptional path (RESOURCE_LEAK) /server/src/com/cloud/server/ConfigurationServerImpl.java: 638 in com.cloud.server.ConfigurationServerImpl.updateSSLKeystore()() ** CID 1133704: SS: Unread field should be static (FB.SS_SHOULD_BE_STATIC) /server/src/com/cloud/uuididentity/UUIDManagerImpl.java: 43 in () ** CID 1133703: Dm: Dubious method used (FB.DM_DEFAULT_ENCODING) /plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java: 197 in org.apache.cloudstack.api.command.LdapImportUsersCmd.generatePassword()() ** CID 1133702: DLS: Dead local store (FB.DLS_DEAD_LOCAL_STORE) /plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java: 119 in org.apache.cloudstack.network.contrail.model.VirtualMachineModel.buildServiceInstance(org.apache.cloudstack.network.contrail.model.ModelController, java.lang.String)() To view the defects in Coverity Scan visit, http://scan.coverity.com To unsubscribe from the email notification for new defects, http://scan5.coverity.com/cgi-bin/unsubscribe.py
Fwd: New Defects reported by Coverity Scan for cloudstack
Forward as the mail to the list is not setup yet. Sent from my iPhone Begin forwarded message: From: scan-ad...@coverity.com Date: 15 november 2013 13:47:59 CET Subject: New Defects reported by Coverity Scan for cloudstack Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. Defect(s) Reported-by: Coverity Scan Showing 7 of 7 defect(s) ** CID 1128965: Missing call to superclass (CALL_SUPER) /services/console-proxy-rdp/rdpconsole/src/main/java/streamer/MockSource.java: 49 in streamer.MockSource.handleEvent(streamer.Event, streamer.Direction)() ** CID 1128964: Missing call to superclass (CALL_SUPER) /services/console-proxy-rdp/rdpconsole/src/main/java/streamer/FakeSink.java: 45 in streamer.FakeSink.handleEvent(streamer.Event, streamer.Direction)() ** CID 1128966: Explicit null dereferenced (FORWARD_NULL) /server/src/com/cloud/network/NetworkServiceImpl.java: 3553 in com.cloud.network.NetworkServiceImpl.addTrafficTypeToPhysicalNetwork(java.lang.Long, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String)() ** CID 1128967: Unguarded write (GUARDED_BY_VIOLATION) /plugins/network-elements/palo-alto/src/com/cloud/network/resource/PaloAltoResource.java: 246 in com.cloud.network.resource.PaloAltoResource.configure(java.lang.String, java.util.Map)() ** CID 1128968: Using invalid iterator (INVALIDATE_ITERATOR) /services/console-proxy-rdp/rdpconsole/src/main/java/streamer/BaseElement.java: 149 in streamer.BaseElement.poll(boolean)() ** CID 1128969: Failure to restore non-local value (MISSING_RESTORE) /server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java: 1194 in com.cloud.network.lb.LoadBalancingRulesManagerImpl.assignCertToLoadBalancer(long, java.lang.Long)() ** CID 1128970: Dereference null return value (NULL_RETURNS) /services/console-proxy-rdp/rdpconsole/src/main/java/streamer/BaseElement.java: 414 in streamer.BaseElement.main(java.lang.String[])() To view the defects in Coverity Scan visit, http://scan.coverity.com To unsubscribe from the email notification for new defects, http://scan5.coverity.com/cgi-bin/unsubscribe.py
