Re: Review Request 16152: added support for 4.2 ldap apis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16152/#review30190 --- Ship it! Ship It! - Abhinandan Prateek On Dec. 10, 2013, 8:15 a.m., Rajani Karuturi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16152/ --- (Updated Dec. 10, 2013, 8:15 a.m.) Review request for cloudstack, Abhinandan Prateek and Ian Duffy. Bugs: CLOUDSTACK-5375 https://issues.apache.org/jira/browse/CLOUDSTACK-5375 Repository: cloudstack-git Description --- Added support for 4.2 ldap apis in the old api, queryfilter and ssl are used which doesnt exist in the new api. they are ignored. Diffs - plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPRemoveCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LDAPConfigResponse.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LDAPRemoveResponse.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java f41bd3a Diff: https://reviews.apache.org/r/16152/diff/ Testing --- manually tested. Thanks, Rajani Karuturi
Re: Review Request 16152: added support for 4.2 ldap apis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16152/ --- (Updated Dec. 11, 2013, 10:29 a.m.) Review request for cloudstack, Abhinandan Prateek and Ian Duffy. Changes --- added the patch for 4.3 branch as there are some space change conflicts. Bugs: CLOUDSTACK-5375 https://issues.apache.org/jira/browse/CLOUDSTACK-5375 Repository: cloudstack-git Description --- Added support for 4.2 ldap apis in the old api, queryfilter and ssl are used which doesnt exist in the new api. they are ignored. Diffs (updated) - plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPRemoveCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LDAPConfigResponse.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LDAPRemoveResponse.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 891d625 Diff: https://reviews.apache.org/r/16152/diff/ Testing --- manually tested. Thanks, Rajani Karuturi
Review Request 16152: added support for 4.2 ldap apis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16152/ --- Review request for cloudstack, Abhinandan Prateek and Ian Duffy. Bugs: CLOUDSTACK-5375 https://issues.apache.org/jira/browse/CLOUDSTACK-5375 Repository: cloudstack-git Description --- Added support for 4.2 ldap apis in the old api, queryfilter and ssl are used which doesnt exist in the new api. they are ignored. Diffs - plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPRemoveCmd.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LDAPConfigResponse.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LDAPRemoveResponse.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java f41bd3a Diff: https://reviews.apache.org/r/16152/diff/ Testing --- manually tested. Thanks, Rajani Karuturi
RE: Ldap APIs
Raised a product issue for this and assigned to IAN. https://issues.apache.org/jira/browse/CLOUDSTACK-5375 regards sadhu -Original Message- From: Abhinandan Prateek [mailto:abhinandan.prat...@citrix.com] Sent: 04 December 2013 10:09 To: dev@cloudstack.apache.org Subject: Re: Ldap APIs We need to have the pre-existing API¹s working. Also I am not sure if we can even mark these depreciated in 4.3. We can move to the new and more flexible APIs completely in 5.0 release and deprecate the current APIs. On 03/12/13 9:28 pm, Rajani Karuturi rajani.karut...@citrix.com wrote: They were removed before i got started on ACS. Ian/abhi should be able to answer. Thanks, - Rajani From: Chip Childers [chipchild...@apache.org] Sent: Tuesday, December 03, 2013 8:48 PM To: dev@cloudstack.apache.org Subject: Re: Ldap APIs Why are they even changing? Once we publish an API, we should stick with it... otherwise we have to bump to version 5.0.0 for our next feature release. On Tue, Dec 3, 2013 at 10:01 AM, Suresh Sadhu suresh.sa...@citrix.com wrote: Rajani, Is there any specific reason for removing existing API's.why don't we show them as deprecated api but still it should work right Regards Sadhu -Original Message- From: Chip Childers [mailto:chip.child...@gmail.com] Sent: 03 December 2013 18:17 To: dev@cloudstack.apache.org; Rajani Karuturi Subject: Re: Ldap APIs So we are breaking API compatibility? On Dec 3, 2013, at 7:42 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+pro vi sioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20 %3 c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
Re: Ldap APIs
Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provisioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
Re: Ldap APIs
So we are breaking API compatibility? On Dec 3, 2013, at 7:42 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provisioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
RE: Ldap APIs
Rajani, Is there any specific reason for removing existing API's.why don't we show them as deprecated api but still it should work right Regards Sadhu -Original Message- From: Chip Childers [mailto:chip.child...@gmail.com] Sent: 03 December 2013 18:17 To: dev@cloudstack.apache.org; Rajani Karuturi Subject: Re: Ldap APIs So we are breaking API compatibility? On Dec 3, 2013, at 7:42 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provi sioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3 c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
Re: Ldap APIs
Why are they even changing? Once we publish an API, we should stick with it... otherwise we have to bump to version 5.0.0 for our next feature release. On Tue, Dec 3, 2013 at 10:01 AM, Suresh Sadhu suresh.sa...@citrix.com wrote: Rajani, Is there any specific reason for removing existing API's.why don't we show them as deprecated api but still it should work right Regards Sadhu -Original Message- From: Chip Childers [mailto:chip.child...@gmail.com] Sent: 03 December 2013 18:17 To: dev@cloudstack.apache.org; Rajani Karuturi Subject: Re: Ldap APIs So we are breaking API compatibility? On Dec 3, 2013, at 7:42 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provi sioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3 c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
RE: Ldap APIs
They were removed before i got started on ACS. Ian/abhi should be able to answer. Thanks, - Rajani From: Chip Childers [chipchild...@apache.org] Sent: Tuesday, December 03, 2013 8:48 PM To: dev@cloudstack.apache.org Subject: Re: Ldap APIs Why are they even changing? Once we publish an API, we should stick with it... otherwise we have to bump to version 5.0.0 for our next feature release. On Tue, Dec 3, 2013 at 10:01 AM, Suresh Sadhu suresh.sa...@citrix.com wrote: Rajani, Is there any specific reason for removing existing API's.why don't we show them as deprecated api but still it should work right Regards Sadhu -Original Message- From: Chip Childers [mailto:chip.child...@gmail.com] Sent: 03 December 2013 18:17 To: dev@cloudstack.apache.org; Rajani Karuturi Subject: Re: Ldap APIs So we are breaking API compatibility? On Dec 3, 2013, at 7:42 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provi sioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3 c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
Re: Ldap APIs
We need to have the pre-existing API¹s working. Also I am not sure if we can even mark these depreciated in 4.3. We can move to the new and more flexible APIs completely in 5.0 release and deprecate the current APIs. On 03/12/13 9:28 pm, Rajani Karuturi rajani.karut...@citrix.com wrote: They were removed before i got started on ACS. Ian/abhi should be able to answer. Thanks, - Rajani From: Chip Childers [chipchild...@apache.org] Sent: Tuesday, December 03, 2013 8:48 PM To: dev@cloudstack.apache.org Subject: Re: Ldap APIs Why are they even changing? Once we publish an API, we should stick with it... otherwise we have to bump to version 5.0.0 for our next feature release. On Tue, Dec 3, 2013 at 10:01 AM, Suresh Sadhu suresh.sa...@citrix.com wrote: Rajani, Is there any specific reason for removing existing API's.why don't we show them as deprecated api but still it should work right Regards Sadhu -Original Message- From: Chip Childers [mailto:chip.child...@gmail.com] Sent: 03 December 2013 18:17 To: dev@cloudstack.apache.org; Rajani Karuturi Subject: Re: Ldap APIs So we are breaking API compatibility? On Dec 3, 2013, at 7:42 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provi sioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3 c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
