RE: [MERGE] affinity_groups branch to master

2013-04-11 Thread Prachi Damle
This is now merged to master.

Thanks,
Prachi

-Original Message-
From: Chip Childers [mailto:chip.child...@sungard.com] 
Sent: Wednesday, April 10, 2013 10:54 AM
To: dev@cloudstack.apache.org
Subject: Re: [MERGE] affinity_groups branch to master

On Fri, Apr 05, 2013 at 05:26:15PM -0700, Prachi Damle wrote:
> Hi all,
> 
> I would like to merge the Affinity/Anti-Affinity feature developed in 
> affinity_groups branch to master.
> 
> 
> -  Functional Specs for this feature can be found here: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+-+Affinity-Anti-affinity+groups
> 
> 
> 
> -  How to use this feature? FS has a 'Use cases' section that 
> outlines this.
> 
> 
> 
> -  Jira ticket for the same is: 
> https://issues.apache.org/jira/browse/CLOUDSTACK-739
> 
> 
> 
> -  Unit tests:  For the new APIs and Service, added a unit test under 
> cloud-server/test/org/apache/loudstack/affinity/AffinityApiUnitTest.java
> 
> 
> 
> -  Integration tests: Added python test using marvin here:  
> cloud-tools/marvin/marvin/sandbox/demo/live/ testDeployVMWithAffinityGroup.py
> 
> 
> 
> -  I have rebased the branch with master Commit hash: 
> 1274d8f68a7d5961d8fc363d8a4952dd6835c252
> 
> 
> 
> -  Attached is the RAT report.
> 
> Thanks,
> -Prachi

+1 to this merge.  Thanks for all the specifics!


Re: [MERGE] affinity_groups branch to master

2013-04-10 Thread Chip Childers
On Fri, Apr 05, 2013 at 05:26:15PM -0700, Prachi Damle wrote:
> Hi all,
> 
> I would like to merge the Affinity/Anti-Affinity feature developed in 
> affinity_groups branch to master.
> 
> 
> -  Functional Specs for this feature can be found here: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+-+Affinity-Anti-affinity+groups
> 
> 
> 
> -  How to use this feature? FS has a 'Use cases' section that 
> outlines this.
> 
> 
> 
> -  Jira ticket for the same is: 
> https://issues.apache.org/jira/browse/CLOUDSTACK-739
> 
> 
> 
> -  Unit tests:  For the new APIs and Service, added a unit test under 
> cloud-server/test/org/apache/loudstack/affinity/AffinityApiUnitTest.java
> 
> 
> 
> -  Integration tests: Added python test using marvin here:  
> cloud-tools/marvin/marvin/sandbox/demo/live/ testDeployVMWithAffinityGroup.py
> 
> 
> 
> -  I have rebased the branch with master Commit hash: 
> 1274d8f68a7d5961d8fc363d8a4952dd6835c252
> 
> 
> 
> -  Attached is the RAT report.
> 
> Thanks,
> -Prachi

+1 to this merge.  Thanks for all the specifics!


Re: [MERGE] affinity_groups branch to master

2013-04-08 Thread David Nalley
On Mon, Apr 8, 2013 at 1:57 PM, prasanna  wrote:
> On 6 April 2013 05:56, Prachi Damle  wrote:
>> Hi all,
>>
>>
>>
>> I would like to merge the Affinity/Anti-Affinity feature developed in
>> affinity_groups branch to master.
>>
>>
>>
>> -  Functional Specs for this feature can be found here:
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+-+Affinity-Anti-affinity+groups
>>
>
>>
>> -  Integration tests: Added python test using marvin here:
>> cloud-tools/marvin/marvin/sandbox/demo/live/
>> testDeployVMWithAffinityGroup.py
>>
>>
> Thanks Prachi for the test. I've modified it in your branch to use
> some library methods from marvin which makes it concise. When I run
> the BVT on the branch I noticed an exception. Perhaps it is related to
> the changes made in the branch, perhaps not:
>
> Can you please take a look?
> https://issues.apache.org/jira/browse/CLOUDSTACK-1968
>
> Thanks,

Prasanna:

Thanks for taking the initiative and running BVT against this.


--David


RE: [MERGE] affinity_groups branch to master

2013-04-08 Thread Prachi Damle
Prasanna,
Its related! Fixed it in the branch

Thanks,
-Prachi

-Original Message-
From: srivatsav.prasa...@gmail.com [mailto:srivatsav.prasa...@gmail.com] On 
Behalf Of prasanna
Sent: Monday, April 08, 2013 10:58 AM
To: dev@cloudstack.apache.org
Subject: Re: [MERGE] affinity_groups branch to master

On 6 April 2013 05:56, Prachi Damle  wrote:
> Hi all,
>
>
>
> I would like to merge the Affinity/Anti-Affinity feature developed in 
> affinity_groups branch to master.
>
>
>
> -  Functional Specs for this feature can be found here:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+-+Affinity-A
> nti-affinity+groups
>

>
> -  Integration tests: Added python test using marvin here:
> cloud-tools/marvin/marvin/sandbox/demo/live/
> testDeployVMWithAffinityGroup.py
>
>
Thanks Prachi for the test. I've modified it in your branch to use some library 
methods from marvin which makes it concise. When I run the BVT on the branch I 
noticed an exception. Perhaps it is related to the changes made in the branch, 
perhaps not:

Can you please take a look?
https://issues.apache.org/jira/browse/CLOUDSTACK-1968

Thanks,


Re: [MERGE] affinity_groups branch to master

2013-04-08 Thread prasanna
On 6 April 2013 05:56, Prachi Damle  wrote:
> Hi all,
>
>
>
> I would like to merge the Affinity/Anti-Affinity feature developed in
> affinity_groups branch to master.
>
>
>
> -  Functional Specs for this feature can be found here:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+-+Affinity-Anti-affinity+groups
>

>
> -  Integration tests: Added python test using marvin here:
> cloud-tools/marvin/marvin/sandbox/demo/live/
> testDeployVMWithAffinityGroup.py
>
>
Thanks Prachi for the test. I've modified it in your branch to use
some library methods from marvin which makes it concise. When I run
the BVT on the branch I noticed an exception. Perhaps it is related to
the changes made in the branch, perhaps not:

Can you please take a look?
https://issues.apache.org/jira/browse/CLOUDSTACK-1968

Thanks,