Re: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared network IP Range
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18683/#review36699
---
Commit 859a78e1d321a936efd18dc6f0a55ab336cd3b70 in cloudstack's branch
refs/heads/4.3 from Marcus Sorensen
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=859a78e ]
CLOUDSTACK-6194: Failed to increase Shared network IP Range
Submitted-by:Saksham Srivastava
(cherry picked from commit 135247afd114c1dfc6dde22184430237e79aafc5)
Signed-off-by: Animesh Chaturvedi
- ASF Subversion and Git Services
On March 3, 2014, 12:53 p.m., Saksham Srivastava wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18683/
> ---
>
> (Updated March 3, 2014, 12:53 p.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6194
> https://issues.apache.org/jira/browse/CLOUDSTACK-6194
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> In case the vlan is passed null to the api or doing it from UI, the new
> changes make vlanId as "vlan://untagged"
>
> The following code in ConfigurationManagerImpl.java
> if (vlans != null && vlans.size() > 0) {
> VlanVO vlan = vlans.get(0);
> if (vlanId == null) {
> vlanId = vlan.getVlanTag();
> } else if
> (!NetUtils.isSameIsolationId(vlan.getVlanTag(), vlanId)) {
> throw new InvalidParameterValueException("there is
> already one vlan " + vlan.getVlanTag()
>
> starts throwing exception.
>
> Fix includes additional check for the modified vlanid.
> The same checks are in NetUtils.isSameIsolationId() for checking untagged.
>
>
> Diffs
> -
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java d2e5aaa
>
> Diff: https://reviews.apache.org/r/18683/diff/
>
>
> Testing
> ---
>
> Adding new guest IP range passes smoothly.
> Adding new public IP ranges passes smoothly.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
RE: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared network IP Range
Thanks, I am still not there :)
-Original Message-
From: Marcus [mailto:shadow...@gmail.com]
Sent: Wednesday, March 5, 2014 10:48 AM
To: Saksham Srivastava
Cc: dev@cloudstack.apache.org; Sateesh Chodapuneedi
Subject: Re: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared
network IP Range
sure, I lose track of who is committer, as many times committers post to
reviewboard as well if the code is unfamiliar.
On Tue, Mar 4, 2014 at 9:46 PM, Saksham Srivastava
wrote:
> Marcus, as a committer can you kindly commit it too.
>
> -Original Message-
> From: Marcus Sorensen [mailto:nore...@reviews.apache.org] On Behalf Of
> Marcus Sorensen
> Sent: Monday, March 3, 2014 10:09 PM
> To: Marcus Sorensen; Sateesh Chodapuneedi
> Cc: Saksham Srivastava; cloudstack
> Subject: Re: Review Request 18683: CLOUDSTACK-6194: Failed to increase
> Shared network IP Range
>
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18683/#review35970
> ---
>
> Ship it!
>
>
> Ship It!
>
> - Marcus Sorensen
>
>
> On March 3, 2014, 12:53 p.m., Saksham Srivastava wrote:
>>
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/18683/
>> ---
>>
>> (Updated March 3, 2014, 12:53 p.m.)
>>
>>
>> Review request for cloudstack, Marcus Sorensen and Sateesh Chodapuneedi.
>>
>>
>> Bugs: CLOUDSTACK-6194
>> https://issues.apache.org/jira/browse/CLOUDSTACK-6194
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> ---
>>
>> In case the vlan is passed null to the api or doing it from UI, the new
>> changes make vlanId as "vlan://untagged"
>>
>> The following code in ConfigurationManagerImpl.java if (vlans !=
>> null && vlans.size() > 0) {
>> VlanVO vlan = vlans.get(0);
>> if (vlanId == null) {
>> vlanId = vlan.getVlanTag();
>> } else if
>> (!NetUtils.isSameIsolationId(vlan.getVlanTag(), vlanId)) {
>> throw new
>> InvalidParameterValueException("there is already one vlan " +
>> vlan.getVlanTag()
>>
>> starts throwing exception.
>>
>> Fix includes additional check for the modified vlanid.
>> The same checks are in NetUtils.isSameIsolationId() for checking untagged.
>>
>>
>> Diffs
>> -
>>
>> server/src/com/cloud/configuration/ConfigurationManagerImpl.java
>> d2e5aaa
>>
>> Diff: https://reviews.apache.org/r/18683/diff/
>>
>>
>> Testing
>> ---
>>
>> Adding new guest IP range passes smoothly.
>> Adding new public IP ranges passes smoothly.
>>
>>
>> Thanks,
>>
>> Saksham Srivastava
>>
>>
>
Re: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared network IP Range
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18683/#review36210
---
Commit cd0d16f05a2be02e3de1a327bba9a5acd112e4f2 in cloudstack's branch
refs/heads/4.3-forward from Marcus Sorensen
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=cd0d16f ]
CLOUDSTACK-6194: Failed to increase Shared network IP Range
Submitted-by:Saksham Srivastava
- ASF Subversion and Git Services
On March 3, 2014, 12:53 p.m., Saksham Srivastava wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18683/
> ---
>
> (Updated March 3, 2014, 12:53 p.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6194
> https://issues.apache.org/jira/browse/CLOUDSTACK-6194
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> In case the vlan is passed null to the api or doing it from UI, the new
> changes make vlanId as "vlan://untagged"
>
> The following code in ConfigurationManagerImpl.java
> if (vlans != null && vlans.size() > 0) {
> VlanVO vlan = vlans.get(0);
> if (vlanId == null) {
> vlanId = vlan.getVlanTag();
> } else if
> (!NetUtils.isSameIsolationId(vlan.getVlanTag(), vlanId)) {
> throw new InvalidParameterValueException("there is
> already one vlan " + vlan.getVlanTag()
>
> starts throwing exception.
>
> Fix includes additional check for the modified vlanid.
> The same checks are in NetUtils.isSameIsolationId() for checking untagged.
>
>
> Diffs
> -
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java d2e5aaa
>
> Diff: https://reviews.apache.org/r/18683/diff/
>
>
> Testing
> ---
>
> Adding new guest IP range passes smoothly.
> Adding new public IP ranges passes smoothly.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared network IP Range
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18683/#review36209
---
Commit b8413b9413eb39053c378309195469a4d5d4fec0 in cloudstack's branch
refs/heads/master from Marcus Sorensen
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b8413b9 ]
CLOUDSTACK-6194: Failed to increase Shared network IP Range
Submitted-by:Saksham Srivastava
- ASF Subversion and Git Services
On March 3, 2014, 12:53 p.m., Saksham Srivastava wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18683/
> ---
>
> (Updated March 3, 2014, 12:53 p.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6194
> https://issues.apache.org/jira/browse/CLOUDSTACK-6194
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> In case the vlan is passed null to the api or doing it from UI, the new
> changes make vlanId as "vlan://untagged"
>
> The following code in ConfigurationManagerImpl.java
> if (vlans != null && vlans.size() > 0) {
> VlanVO vlan = vlans.get(0);
> if (vlanId == null) {
> vlanId = vlan.getVlanTag();
> } else if
> (!NetUtils.isSameIsolationId(vlan.getVlanTag(), vlanId)) {
> throw new InvalidParameterValueException("there is
> already one vlan " + vlan.getVlanTag()
>
> starts throwing exception.
>
> Fix includes additional check for the modified vlanid.
> The same checks are in NetUtils.isSameIsolationId() for checking untagged.
>
>
> Diffs
> -
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java d2e5aaa
>
> Diff: https://reviews.apache.org/r/18683/diff/
>
>
> Testing
> ---
>
> Adding new guest IP range passes smoothly.
> Adding new public IP ranges passes smoothly.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared network IP Range
sure, I lose track of who is committer, as many times committers post
to reviewboard as well if the code is unfamiliar.
On Tue, Mar 4, 2014 at 9:46 PM, Saksham Srivastava
wrote:
> Marcus, as a committer can you kindly commit it too.
>
> -Original Message-
> From: Marcus Sorensen [mailto:nore...@reviews.apache.org] On Behalf Of Marcus
> Sorensen
> Sent: Monday, March 3, 2014 10:09 PM
> To: Marcus Sorensen; Sateesh Chodapuneedi
> Cc: Saksham Srivastava; cloudstack
> Subject: Re: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared
> network IP Range
>
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18683/#review35970
> ---
>
> Ship it!
>
>
> Ship It!
>
> - Marcus Sorensen
>
>
> On March 3, 2014, 12:53 p.m., Saksham Srivastava wrote:
>>
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/18683/
>> ---
>>
>> (Updated March 3, 2014, 12:53 p.m.)
>>
>>
>> Review request for cloudstack, Marcus Sorensen and Sateesh Chodapuneedi.
>>
>>
>> Bugs: CLOUDSTACK-6194
>> https://issues.apache.org/jira/browse/CLOUDSTACK-6194
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> ---
>>
>> In case the vlan is passed null to the api or doing it from UI, the new
>> changes make vlanId as "vlan://untagged"
>>
>> The following code in ConfigurationManagerImpl.java if (vlans != null
>> && vlans.size() > 0) {
>> VlanVO vlan = vlans.get(0);
>> if (vlanId == null) {
>> vlanId = vlan.getVlanTag();
>> } else if
>> (!NetUtils.isSameIsolationId(vlan.getVlanTag(), vlanId)) {
>> throw new
>> InvalidParameterValueException("there is already one vlan " +
>> vlan.getVlanTag()
>>
>> starts throwing exception.
>>
>> Fix includes additional check for the modified vlanid.
>> The same checks are in NetUtils.isSameIsolationId() for checking untagged.
>>
>>
>> Diffs
>> -
>>
>> server/src/com/cloud/configuration/ConfigurationManagerImpl.java
>> d2e5aaa
>>
>> Diff: https://reviews.apache.org/r/18683/diff/
>>
>>
>> Testing
>> ---
>>
>> Adding new guest IP range passes smoothly.
>> Adding new public IP ranges passes smoothly.
>>
>>
>> Thanks,
>>
>> Saksham Srivastava
>>
>>
>
RE: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared network IP Range
Marcus, as a committer can you kindly commit it too.
-Original Message-
From: Marcus Sorensen [mailto:nore...@reviews.apache.org] On Behalf Of Marcus
Sorensen
Sent: Monday, March 3, 2014 10:09 PM
To: Marcus Sorensen; Sateesh Chodapuneedi
Cc: Saksham Srivastava; cloudstack
Subject: Re: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared
network IP Range
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18683/#review35970
---
Ship it!
Ship It!
- Marcus Sorensen
On March 3, 2014, 12:53 p.m., Saksham Srivastava wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18683/
> ---
>
> (Updated March 3, 2014, 12:53 p.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6194
> https://issues.apache.org/jira/browse/CLOUDSTACK-6194
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> In case the vlan is passed null to the api or doing it from UI, the new
> changes make vlanId as "vlan://untagged"
>
> The following code in ConfigurationManagerImpl.java if (vlans != null
> && vlans.size() > 0) {
> VlanVO vlan = vlans.get(0);
> if (vlanId == null) {
> vlanId = vlan.getVlanTag();
> } else if
> (!NetUtils.isSameIsolationId(vlan.getVlanTag(), vlanId)) {
> throw new
> InvalidParameterValueException("there is already one vlan " +
> vlan.getVlanTag()
>
> starts throwing exception.
>
> Fix includes additional check for the modified vlanid.
> The same checks are in NetUtils.isSameIsolationId() for checking untagged.
>
>
> Diffs
> -
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java
> d2e5aaa
>
> Diff: https://reviews.apache.org/r/18683/diff/
>
>
> Testing
> ---
>
> Adding new guest IP range passes smoothly.
> Adding new public IP ranges passes smoothly.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared network IP Range
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18683/#review35970
---
Ship it!
Ship It!
- Marcus Sorensen
On March 3, 2014, 12:53 p.m., Saksham Srivastava wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18683/
> ---
>
> (Updated March 3, 2014, 12:53 p.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6194
> https://issues.apache.org/jira/browse/CLOUDSTACK-6194
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> In case the vlan is passed null to the api or doing it from UI, the new
> changes make vlanId as "vlan://untagged"
>
> The following code in ConfigurationManagerImpl.java
> if (vlans != null && vlans.size() > 0) {
> VlanVO vlan = vlans.get(0);
> if (vlanId == null) {
> vlanId = vlan.getVlanTag();
> } else if
> (!NetUtils.isSameIsolationId(vlan.getVlanTag(), vlanId)) {
> throw new InvalidParameterValueException("there is
> already one vlan " + vlan.getVlanTag()
>
> starts throwing exception.
>
> Fix includes additional check for the modified vlanid.
> The same checks are in NetUtils.isSameIsolationId() for checking untagged.
>
>
> Diffs
> -
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java d2e5aaa
>
> Diff: https://reviews.apache.org/r/18683/diff/
>
>
> Testing
> ---
>
> Adding new guest IP range passes smoothly.
> Adding new public IP ranges passes smoothly.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
