Re: [ACS4.4] cherry pick commit dc22566c642e400014332045a224e5545d33a11c and 48646ae186eb75052da3da385404a823bd785444
One question Sanjay, The second commit changes a check of .isEmpty() to .size() >1 and then does some checks on element 0. So what is the significance of this. It is not intuitive what happens here. Can you explain? I gave it the benefit of the doubt and cherry-picked both, btw. On Fri, Jun 27, 2014 at 8:28 AM, Sanjay Tripathi wrote: > Hi Daan, > > Could you please cherry-pick following commits to 4.4 branch. > > Commit: dc22566c642e400014332045a224e5545d33a11c > CLOUDSTACK-6453: [GPU] Windows 2012 Server instance created with vGPU > offering is not coming up after installing PV drivers. > > Commit: 48646ae186eb75052da3da385404a823bd785444 > CLOUDSTACK-6884: List Capacity API always returns GPU capacity also even if > type is different. > > > --Sanjay -- Daan
RE: [ACS4.4] cherry pick commit dc22566c642e400014332045a224e5545d33a11c and 48646ae186eb75052da3da385404a823bd785444
Hi Daan, The first part is to check if user is not passing "type" field to query only one resource type so that in result, we'll have more than one elements; and the second part of the check fetching the zoneId, podId and clusterId from the existing result to get the GPU resource capacity details. And, thanks for pushing the patch :) . --Sanjay -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Friday, June 27, 2014 1:15 PM To: Sanjay Tripathi Cc: dev@cloudstack.apache.org Subject: Re: [ACS4.4] cherry pick commit dc22566c642e400014332045a224e5545d33a11c and 48646ae186eb75052da3da385404a823bd785444 One question Sanjay, The second commit changes a check of .isEmpty() to .size() >1 and then does some checks on element 0. So what is the significance of this. It is not intuitive what happens here. Can you explain? I gave it the benefit of the doubt and cherry-picked both, btw. On Fri, Jun 27, 2014 at 8:28 AM, Sanjay Tripathi wrote: > Hi Daan, > > Could you please cherry-pick following commits to 4.4 branch. > > Commit: dc22566c642e400014332045a224e5545d33a11c > CLOUDSTACK-6453: [GPU] Windows 2012 Server instance created with vGPU > offering is not coming up after installing PV drivers. > > Commit: 48646ae186eb75052da3da385404a823bd785444 > CLOUDSTACK-6884: List Capacity API always returns GPU capacity also even if > type is different. > > > --Sanjay -- Daan
Re: [ACS4.4] cherry pick commit dc22566c642e400014332045a224e5545d33a11c and 48646ae186eb75052da3da385404a823bd785444
So, if the user is not passing the type as second parameter, we don't need to check GPU values? On Fri, Jun 27, 2014 at 10:01 AM, Sanjay Tripathi wrote: > Hi Daan, > > The first part is to check if user is not passing "type" field to query only > one resource type so that in result, we'll have more than one elements; and > the second part of the check fetching the zoneId, podId and clusterId from > the existing result to get the GPU resource capacity details. > > And, thanks for pushing the patch :) . > > --Sanjay > > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Friday, June 27, 2014 1:15 PM > To: Sanjay Tripathi > Cc: dev@cloudstack.apache.org > Subject: Re: [ACS4.4] cherry pick commit > dc22566c642e400014332045a224e5545d33a11c and > 48646ae186eb75052da3da385404a823bd785444 > > One question Sanjay, > > The second commit changes a check of .isEmpty() to .size() >1 and then does > some checks on element 0. So what is the significance of this. It is not > intuitive what happens here. Can you explain? > > I gave it the benefit of the doubt and cherry-picked both, btw. > > On Fri, Jun 27, 2014 at 8:28 AM, Sanjay Tripathi > wrote: >> Hi Daan, >> >> Could you please cherry-pick following commits to 4.4 branch. >> >> Commit: dc22566c642e400014332045a224e5545d33a11c >> CLOUDSTACK-6453: [GPU] Windows 2012 Server instance created with vGPU >> offering is not coming up after installing PV drivers. >> >> Commit: 48646ae186eb75052da3da385404a823bd785444 >> CLOUDSTACK-6884: List Capacity API always returns GPU capacity also even if >> type is different. >> >> >> --Sanjay > > > > -- > Daan -- Daan
RE: [ACS4.4] cherry pick commit dc22566c642e400014332045a224e5545d33a11c and 48646ae186eb75052da3da385404a823bd785444
If the use is not passing "type" parameter then capacityResponse will return all the resource capacities including GPU resource capacity. --Sanjay -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Friday, June 27, 2014 1:49 PM To: Sanjay Tripathi Cc: dev@cloudstack.apache.org Subject: Re: [ACS4.4] cherry pick commit dc22566c642e400014332045a224e5545d33a11c and 48646ae186eb75052da3da385404a823bd785444 So, if the user is not passing the type as second parameter, we don't need to check GPU values? On Fri, Jun 27, 2014 at 10:01 AM, Sanjay Tripathi wrote: > Hi Daan, > > The first part is to check if user is not passing "type" field to query only > one resource type so that in result, we'll have more than one elements; and > the second part of the check fetching the zoneId, podId and clusterId from > the existing result to get the GPU resource capacity details. > > And, thanks for pushing the patch :) . > > --Sanjay > > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Friday, June 27, 2014 1:15 PM > To: Sanjay Tripathi > Cc: dev@cloudstack.apache.org > Subject: Re: [ACS4.4] cherry pick commit > dc22566c642e400014332045a224e5545d33a11c and > 48646ae186eb75052da3da385404a823bd785444 > > One question Sanjay, > > The second commit changes a check of .isEmpty() to .size() >1 and then does > some checks on element 0. So what is the significance of this. It is not > intuitive what happens here. Can you explain? > > I gave it the benefit of the doubt and cherry-picked both, btw. > > On Fri, Jun 27, 2014 at 8:28 AM, Sanjay Tripathi > wrote: >> Hi Daan, >> >> Could you please cherry-pick following commits to 4.4 branch. >> >> Commit: dc22566c642e400014332045a224e5545d33a11c >> CLOUDSTACK-6453: [GPU] Windows 2012 Server instance created with vGPU >> offering is not coming up after installing PV drivers. >> >> Commit: 48646ae186eb75052da3da385404a823bd785444 >> CLOUDSTACK-6884: List Capacity API always returns GPU capacity also even if >> type is different. >> >> >> --Sanjay > > > > -- > Daan -- Daan
Re: [ACS4.4] cherry pick commit dc22566c642e400014332045a224e5545d33a11c and 48646ae186eb75052da3da385404a823bd785444
Ok, I didn't get that from the diff or the nearby code, so I probably need to study the code more to get that from it that's why I would like you to add a descriptive comment (or ref to the relevant code in a comment). This way future generation will understand the snippit more easily. ok? On Fri, Jun 27, 2014 at 11:59 AM, Sanjay Tripathi wrote: > If the use is not passing "type" parameter then capacityResponse will return > all the resource capacities including GPU resource capacity. > > --Sanjay > > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Friday, June 27, 2014 1:49 PM > To: Sanjay Tripathi > Cc: dev@cloudstack.apache.org > Subject: Re: [ACS4.4] cherry pick commit > dc22566c642e400014332045a224e5545d33a11c and > 48646ae186eb75052da3da385404a823bd785444 > > So, if the user is not passing the type as second parameter, we don't need to > check GPU values? > > On Fri, Jun 27, 2014 at 10:01 AM, Sanjay Tripathi > wrote: >> Hi Daan, >> >> The first part is to check if user is not passing "type" field to query only >> one resource type so that in result, we'll have more than one elements; and >> the second part of the check fetching the zoneId, podId and clusterId from >> the existing result to get the GPU resource capacity details. >> >> And, thanks for pushing the patch :) . >> >> --Sanjay >> >> -Original Message----- >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] >> Sent: Friday, June 27, 2014 1:15 PM >> To: Sanjay Tripathi >> Cc: dev@cloudstack.apache.org >> Subject: Re: [ACS4.4] cherry pick commit >> dc22566c642e400014332045a224e5545d33a11c and >> 48646ae186eb75052da3da385404a823bd785444 >> >> One question Sanjay, >> >> The second commit changes a check of .isEmpty() to .size() >1 and then does >> some checks on element 0. So what is the significance of this. It is not >> intuitive what happens here. Can you explain? >> >> I gave it the benefit of the doubt and cherry-picked both, btw. >> >> On Fri, Jun 27, 2014 at 8:28 AM, Sanjay Tripathi >> wrote: >>> Hi Daan, >>> >>> Could you please cherry-pick following commits to 4.4 branch. >>> >>> Commit: dc22566c642e400014332045a224e5545d33a11c >>> CLOUDSTACK-6453: [GPU] Windows 2012 Server instance created with vGPU >>> offering is not coming up after installing PV drivers. >>> >>> Commit: 48646ae186eb75052da3da385404a823bd785444 >>> CLOUDSTACK-6884: List Capacity API always returns GPU capacity also even if >>> type is different. >>> >>> >>> --Sanjay >> >> >> >> -- >> Daan > > > > -- > Daan -- Daan
