Re: [PR] Add github action to generate docs preview on PRs [cloudstack-documentation]

2023-12-04 Thread via GitHub


vishesh92 commented on code in PR #360:
URL: 
https://github.com/apache/cloudstack-documentation/pull/360#discussion_r1414058672


##
.github/workflows/gen-docs.yaml:
##
@@ -0,0 +1,15 @@
+name: readthedocs/actions

Review Comment:
   Missed that. Let me create another PR for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add github action to generate docs preview on PRs [cloudstack-documentation]

2023-12-04 Thread via GitHub


rohityadavcloud commented on code in PR #360:
URL: 
https://github.com/apache/cloudstack-documentation/pull/360#discussion_r1414054273


##
.github/workflows/gen-docs.yaml:
##
@@ -0,0 +1,15 @@
+name: readthedocs/actions

Review Comment:
   We probably should add license in header to all new files (wherever 
possible) cc @vishesh92 @DaanHoogland 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add github action to generate docs preview on PRs [cloudstack-documentation]

2023-12-03 Thread via GitHub


DaanHoogland merged PR #360:
URL: https://github.com/apache/cloudstack-documentation/pull/360


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add github action to generate docs preview on PRs [cloudstack-documentation]

2023-12-03 Thread via GitHub


vishesh92 closed pull request #360: Add github action to generate docs preview 
on PRs
URL: https://github.com/apache/cloudstack-documentation/pull/360


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org