Re: [PR] restore methods with 4.19 optional API params [cloudstack-go]
shwstppr closed pull request #77: restore methods with 4.19 optional API params URL: https://github.com/apache/cloudstack-go/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] restore methods with 4.19 optional API params [cloudstack-go]
weizhouapache commented on PR #77: URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1976309995 > Another alternative approach I can think of is generating multiple modules as per the ACS version. Every release of cloudstack-go will have multiple modules for different ACS versions which are being supported at the time. (e.g. 4.18, 4.19, etc.). We can ignore minor version for this and ensure that we are backward compatible for all major versions. This would still require a code change, but can be easily done my a simple "Find & Replace" of the module. > > e.g. `"github.com/apache/cloudstack-go/v2/cloudstack"` will need to be replaced with `"github.com/apache/cloudstack-go/v2/cloudstack/4.19"` @vishesh92 good opinion :thumbsup: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] restore methods with 4.19 optional API params [cloudstack-go]
vishesh92 commented on PR #77: URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1976261911 If someone upgrades their cloudstack-go SDK and builds their project, the build will fail only if some method which is now changed is being used. Any good IDE should be able to list down the parts of code where a change needs to be done. IMO, we should mention the methods in the release notes instead of ensuring backward compatibility for cloudstack-go. Another alternative approach I can think of is generating multiple modules as per the ACS version. Every release of cloudstack-go will have multiple modules for different ACS versions which are being supported at the time. (e.g. 4.18, 4.19, etc.). We can ignore minor version for this and ensure that we are backward compatible for all major versions. This would still require a code change, but can be easily done my a simple "Find & Replace" of the module. e.g. `"github.com/apache/cloudstack-go/v2/cloudstack"` will need to be replaced with `"github.com/apache/cloudstack-go/v2/cloudstack/4.19"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] restore methods with 4.19 optional API params [cloudstack-go]
weizhouapache commented on PR #77: URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1956977692 > Next time we generate the code, we will have to do these changes again. If we plan to support this for next release only, then it's fine. Otherwise it would be better to make it part of the code generation itself. @vishesh92 yes, that's what have agreed. we need to look for a permanant fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] restore methods with 4.19 optional API params [cloudstack-go]
vishesh92 commented on PR #77: URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1956808293 Next time we generate the code, we will have to do these changes again. If we plan to support this for next release only, then it's fine. Otherwise it would be better to make it part of the code generation itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] restore methods with 4.19 optional API params [cloudstack-go]
weizhouapache commented on PR #77: URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1956139850 looks ok to me @hrak @rohityadavcloud what's your opinion ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org