Re: Review Request: Change unit of network statistics from 1000 to 1024 for KVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11195/#review20641 --- Is there a bug ID for this? And is there a branch target(s) for the patch? - Chip Childers On May 16, 2013, 10:17 a.m., Wei Zhou wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11195/ --- (Updated May 16, 2013, 10:17 a.m.) Review request for cloudstack. Description --- As the unit of network statistics ui/scripts/instances.js and ui/scripts/sharedFunctions.js are 1024, the corresponding unit in LibvirtComputingResource.java also need to be changed to 1024. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java b44e8b7 Diff: https://reviews.apache.org/r/11195/diff/ Testing --- Testing ok. Thanks, Wei Zhou
Re: Review Request: Change unit of network statistics from 1000 to 1024 for KVM
On Thu, May 16, 2013 at 01:42:39PM +, Wei Zhou wrote: On May 16, 2013, 1:39 p.m., Chip Childers wrote: Is there a bug ID for this? And is there a branch target(s) for the patch? Chip, no Bug ID. The target branch are master and 4.1. Mind putting a bug into the system for it first then please? - Wei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11195/#review20641 --- On May 16, 2013, 10:17 a.m., Wei Zhou wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11195/ --- (Updated May 16, 2013, 10:17 a.m.) Review request for cloudstack. Description --- As the unit of network statistics ui/scripts/instances.js and ui/scripts/sharedFunctions.js are 1024, the corresponding unit in LibvirtComputingResource.java also need to be changed to 1024. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java b44e8b7 Diff: https://reviews.apache.org/r/11195/diff/ Testing --- Testing ok. Thanks, Wei Zhou
Re: Review Request: Change unit of network statistics from 1000 to 1024 for KVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11195/ --- (Updated May 16, 2013, 1:57 p.m.) Review request for cloudstack. Changes --- add branch(master, 4.1) , and bug ID: CS-2545 Description --- As the unit of network statistics ui/scripts/instances.js and ui/scripts/sharedFunctions.js are 1024, the corresponding unit in LibvirtComputingResource.java also need to be changed to 1024. This addresses bug CLOUDSTACK-2545. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java b44e8b7 Diff: https://reviews.apache.org/r/11195/diff/ Testing --- Testing ok. Thanks, Wei Zhou
Re: Review Request: Change unit of network statistics from 1000 to 1024 for KVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11195/#review20657 --- Ship it! Ship It! - Chip Childers On May 16, 2013, 1:57 p.m., Wei Zhou wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11195/ --- (Updated May 16, 2013, 1:57 p.m.) Review request for cloudstack. Description --- As the unit of network statistics ui/scripts/instances.js and ui/scripts/sharedFunctions.js are 1024, the corresponding unit in LibvirtComputingResource.java also need to be changed to 1024. This addresses bug CLOUDSTACK-2545. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java b44e8b7 Diff: https://reviews.apache.org/r/11195/diff/ Testing --- Testing ok. Thanks, Wei Zhou
