Re: Review Request 15722: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (4.2.0)

2013-12-03 Thread Murali Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15722/#review29655
---

Ship it!


commit 03ba659ae7263ca4fdb7c1c0eaccbecdf45594e8

- Murali Reddy


On Nov. 20, 2013, 7:54 p.m., David Grizzanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15722/
> ---
> 
> (Updated Nov. 20, 2013, 7:54 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-5022
> https://issues.apache.org/jira/browse/CLOUDSTACK-5022
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-5022: NullPointerException when invalid zone is passed into 
> UsageEventUtils
> 
> Updated UsageEventUtils code to not blow up when an invalid zone ID is passed 
> in. Now will still generate usage event but leaving out zone UUID.
> 
> UsageEventUtils has been moved on master, so a separate review will be 
> submitted for that fix.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/event/UsageEventUtils.java 2e42229 
> 
> Diff: https://reviews.apache.org/r/15722/diff/
> 
> 
> Testing
> ---
> 
> Tested on 4.2.0
> 
> 
> Thanks,
> 
> David Grizzanti
> 
>



Re: Review Request 15722: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (4.2.0)

2013-11-20 Thread David Grizzanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15722/
---

(Updated Nov. 20, 2013, 7:54 p.m.)


Review request for cloudstack.


Summary (updated)
-

CLOUDSTACK-5022: NullPointerException when invalid zone is passed into 
UsageEventUtils (4.2.0)


Bugs: CLOUDSTACK-5022
https://issues.apache.org/jira/browse/CLOUDSTACK-5022


Repository: cloudstack-git


Description
---

CLOUDSTACK-5022: NullPointerException when invalid zone is passed into 
UsageEventUtils

Updated UsageEventUtils code to not blow up when an invalid zone ID is passed 
in. Now will still generate usage event but leaving out zone UUID.

UsageEventUtils has been moved on master, so a separate review will be 
submitted for that fix.


Diffs
-

  server/src/com/cloud/event/UsageEventUtils.java 2e42229 

Diff: https://reviews.apache.org/r/15722/diff/


Testing
---

Tested on 4.2.0


Thanks,

David Grizzanti