Re: Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter

2013-12-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16044/#review29895
---


Commit 90cc00df462f9b566575ef6c961cff1667b4243c in branch 
refs/heads/ui-wip-cs5388-review from Chris Suich
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=90cc00d ]

Added quiescevm option to volume snapshot dialog when storage supports it

CLOUDSTACK-5388


- ASF Subversion and Git Services


On Dec. 5, 2013, 9:28 p.m., Chris Suich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16044/
 ---
 
 (Updated Dec. 5, 2013, 9:28 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Volume Snapshot UI does not provide option of adding quiesce vm parameter 
 when the underlying storage does support the option.
 
 
 Diffs
 -
 
   ui/scripts/storage.js 4875662 
 
 Diff: https://reviews.apache.org/r/16044/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Chris Suich
 




Re: Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter

2013-12-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16044/#review29896
---


Commit 14dcd803fa17d688db1a990bb23bdcff1d013da4 in branch 
refs/heads/ui-wip-cs5388-review from Chris Suich
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=14dcd80 ]

Fixed issue with quiescevm param on snapshot UI

CLOUDSTACK-5388


- ASF Subversion and Git Services


On Dec. 5, 2013, 9:28 p.m., Chris Suich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16044/
 ---
 
 (Updated Dec. 5, 2013, 9:28 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Volume Snapshot UI does not provide option of adding quiesce vm parameter 
 when the underlying storage does support the option.
 
 
 Diffs
 -
 
   ui/scripts/storage.js 4875662 
 
 Diff: https://reviews.apache.org/r/16044/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Chris Suich
 




Re: Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter

2013-12-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16044/#review29912
---


Commit a2c0abe98b52b9ee02cc17536731dc04fe3c67d6 in branch refs/heads/4.3 from 
Chris Suich
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a2c0abe ]

Fixed issue with quiescevm param on snapshot UI

CLOUDSTACK-5388


- ASF Subversion and Git Services


On Dec. 5, 2013, 9:28 p.m., Chris Suich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16044/
 ---
 
 (Updated Dec. 5, 2013, 9:28 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Volume Snapshot UI does not provide option of adding quiesce vm parameter 
 when the underlying storage does support the option.
 
 
 Diffs
 -
 
   ui/scripts/storage.js 4875662 
 
 Diff: https://reviews.apache.org/r/16044/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Chris Suich
 




Re: Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter

2013-12-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16044/#review29911
---


Commit 6ac7811274aa31eeef8eead4c7fc4e808af0a147 in branch refs/heads/4.3 from 
Chris Suich
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6ac7811 ]

Added quiescevm option to volume snapshot dialog when storage supports it

CLOUDSTACK-5388


- ASF Subversion and Git Services


On Dec. 5, 2013, 9:28 p.m., Chris Suich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16044/
 ---
 
 (Updated Dec. 5, 2013, 9:28 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Volume Snapshot UI does not provide option of adding quiesce vm parameter 
 when the underlying storage does support the option.
 
 
 Diffs
 -
 
   ui/scripts/storage.js 4875662 
 
 Diff: https://reviews.apache.org/r/16044/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Chris Suich
 




Re: Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter

2013-12-06 Thread Brian Federle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16044/#review29910
---

Ship it!


Ship It!

- Brian Federle


On Dec. 5, 2013, 9:28 p.m., Chris Suich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16044/
 ---
 
 (Updated Dec. 5, 2013, 9:28 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Volume Snapshot UI does not provide option of adding quiesce vm parameter 
 when the underlying storage does support the option.
 
 
 Diffs
 -
 
   ui/scripts/storage.js 4875662 
 
 Diff: https://reviews.apache.org/r/16044/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Chris Suich
 




Re: Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter

2013-12-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16044/#review29914
---


Commit 782bd4d9bcb1606ccd6d09d4c480dea529618c5d in branch refs/heads/master 
from Chris Suich
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=782bd4d ]

Fixed issue with quiescevm param on snapshot UI

CLOUDSTACK-5388


- ASF Subversion and Git Services


On Dec. 5, 2013, 9:28 p.m., Chris Suich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16044/
 ---
 
 (Updated Dec. 5, 2013, 9:28 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Volume Snapshot UI does not provide option of adding quiesce vm parameter 
 when the underlying storage does support the option.
 
 
 Diffs
 -
 
   ui/scripts/storage.js 4875662 
 
 Diff: https://reviews.apache.org/r/16044/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Chris Suich
 




Re: Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter

2013-12-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16044/#review29913
---


Commit 06344db330f6121855a0c8460f8771f7d6c6054a in branch refs/heads/master 
from Chris Suich
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=06344db ]

Added quiescevm option to volume snapshot dialog when storage supports it

CLOUDSTACK-5388


- ASF Subversion and Git Services


On Dec. 5, 2013, 9:28 p.m., Chris Suich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16044/
 ---
 
 (Updated Dec. 5, 2013, 9:28 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Volume Snapshot UI does not provide option of adding quiesce vm parameter 
 when the underlying storage does support the option.
 
 
 Diffs
 -
 
   ui/scripts/storage.js 4875662 
 
 Diff: https://reviews.apache.org/r/16044/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Chris Suich
 




Re: Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter

2013-12-05 Thread Chris Suich

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16044/
---

(Updated Dec. 5, 2013, 9:28 p.m.)


Review request for cloudstack, Brian Federle and Jessica Wang.


Repository: cloudstack-git


Description
---

Volume Snapshot UI does not provide option of adding quiesce vm parameter when 
the underlying storage does support the option.


Diffs (updated)
-

  ui/scripts/storage.js 4875662 

Diff: https://reviews.apache.org/r/16044/diff/


Testing
---


Thanks,

Chris Suich