Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17116/#review34857 --- Commit 47c5b638817784c68c77e4f2dcbfb9ae5d3d6ae9 in cloudstack's branch refs/heads/marvin from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=47c5b63 ] CLOUDSTACK-5674: Fixed all BVTs and some marvin functions - ASF Subversion and Git Services On Jan. 22, 2014, 10:54 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17116/ > --- > > (Updated Jan. 22, 2014, 10:54 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Repository: cloudstack-git > > > Description > --- > > Fixed few issues including pep8 in previous submitted patch ( 17113 ). Tested > Deploying a DC. > > > Diffs > - > > setup/dev/advanced.cfg 23981f0 > setup/dev/basic.cfg 3e39d6d > test/integration/component/test_add_remove_network.py 8ec2971 > test/integration/component/test_affinity_groups.py 7e4fabe > test/integration/component/test_cpu_domain_limits.py c427e4f > test/integration/component/test_cpu_limits.py bdf2869 > test/integration/component/test_cpu_max_limits.py 317df16 > test/integration/component/test_cpu_project_limits.py a8a1b3c > test/integration/component/test_memory_limits.py 7921e4b > test/integration/component/test_mm_domain_limits.py 68660c1 > test/integration/component/test_mm_max_limits.py e10c119 > test/integration/component/test_mm_project_limits.py c314011 > test/integration/component/test_portable_ip.py b09daf9 > test/integration/component/test_vpc.py 1af8d81 > test/integration/component/test_vpn_users.py 02dd026 > test/integration/smoke/test_affinity_groups.py c96a580 > test/integration/smoke/test_deploy_vm.py 425aeb7 > test/integration/smoke/test_deploy_vm_with_userdata.py e3788cf > tools/marvin/marvin/asyncJobMgr.py ee0e891 > tools/marvin/marvin/cloudstackConnection.py fb03e3b > tools/marvin/marvin/cloudstackException.py 623 > tools/marvin/marvin/cloudstackTestClient.py 4ac510b > tools/marvin/marvin/codegenerator.py e0f056f > tools/marvin/marvin/codes.py 74fb05d > tools/marvin/marvin/config/test_data.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 0d79e8e > tools/marvin/marvin/dbConnection.py 99014ab > tools/marvin/marvin/deployDataCenter.py c4f6e1e > tools/marvin/marvin/integration/lib/common.py 550de1a > tools/marvin/marvin/jsonHelper.py ae40b8d > tools/marvin/marvin/marvinInit.py f722058 > tools/marvin/marvin/marvinLog.py 76de185 > tools/marvin/marvin/marvinPlugin.py df7d7a3 > tools/marvin/marvin/tcExecuteEngine.py f959e7e > > Diff: https://reviews.apache.org/r/17116/diff/ > > > Testing > --- > > > File Attachments > > > New Patch File > > https://reviews.apache.org/media/uploaded/files/2014/01/22/1759bdd3-40f9-4462-81b5-e44df20774dc__new_diff.patch > > > Thanks, > > Santhosh Edukulla > >
Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17116/#review34278 --- Commit f3364ca6a465e3ffd645d858eabe05b29442dfe6 in branch refs/heads/marvin from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f3364ca ] CLOUDSTACK-5674: Add missing test_data.py - ASF Subversion and Git Services On Jan. 22, 2014, 10:54 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17116/ > --- > > (Updated Jan. 22, 2014, 10:54 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Repository: cloudstack-git > > > Description > --- > > Fixed few issues including pep8 in previous submitted patch ( 17113 ). Tested > Deploying a DC. > > > Diffs > - > > setup/dev/advanced.cfg 23981f0 > setup/dev/basic.cfg 3e39d6d > test/integration/component/test_add_remove_network.py 8ec2971 > test/integration/component/test_affinity_groups.py 7e4fabe > test/integration/component/test_cpu_domain_limits.py c427e4f > test/integration/component/test_cpu_limits.py bdf2869 > test/integration/component/test_cpu_max_limits.py 317df16 > test/integration/component/test_cpu_project_limits.py a8a1b3c > test/integration/component/test_memory_limits.py 7921e4b > test/integration/component/test_mm_domain_limits.py 68660c1 > test/integration/component/test_mm_max_limits.py e10c119 > test/integration/component/test_mm_project_limits.py c314011 > test/integration/component/test_portable_ip.py b09daf9 > test/integration/component/test_vpc.py 1af8d81 > test/integration/component/test_vpn_users.py 02dd026 > test/integration/smoke/test_affinity_groups.py c96a580 > test/integration/smoke/test_deploy_vm.py 425aeb7 > test/integration/smoke/test_deploy_vm_with_userdata.py e3788cf > tools/marvin/marvin/asyncJobMgr.py ee0e891 > tools/marvin/marvin/cloudstackConnection.py fb03e3b > tools/marvin/marvin/cloudstackException.py 623 > tools/marvin/marvin/cloudstackTestClient.py 4ac510b > tools/marvin/marvin/codegenerator.py e0f056f > tools/marvin/marvin/codes.py 74fb05d > tools/marvin/marvin/config/test_data.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 0d79e8e > tools/marvin/marvin/dbConnection.py 99014ab > tools/marvin/marvin/deployDataCenter.py c4f6e1e > tools/marvin/marvin/integration/lib/common.py 550de1a > tools/marvin/marvin/jsonHelper.py ae40b8d > tools/marvin/marvin/marvinInit.py f722058 > tools/marvin/marvin/marvinLog.py 76de185 > tools/marvin/marvin/marvinPlugin.py df7d7a3 > tools/marvin/marvin/tcExecuteEngine.py f959e7e > > Diff: https://reviews.apache.org/r/17116/diff/ > > > Testing > --- > > > File Attachments > > > New Patch File > > https://reviews.apache.org/media/uploaded/files/2014/01/22/1759bdd3-40f9-4462-81b5-e44df20774dc__new_diff.patch > > > Thanks, > > Santhosh Edukulla > >
Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17116/#review34274 --- Commit 3dbb2ae48819bfae6cfa17637fe23752e3906de7 in branch refs/heads/marvin from Santhosh Edukulla [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3dbb2ae ] CLOUDSTACk-5674: Added fix for CLOUDSTACK-5674 - ASF Subversion and Git Services On Jan. 22, 2014, 10:54 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17116/ > --- > > (Updated Jan. 22, 2014, 10:54 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Repository: cloudstack-git > > > Description > --- > > Fixed few issues including pep8 in previous submitted patch ( 17113 ). Tested > Deploying a DC. > > > Diffs > - > > setup/dev/advanced.cfg 23981f0 > setup/dev/basic.cfg 3e39d6d > test/integration/component/test_add_remove_network.py 8ec2971 > test/integration/component/test_affinity_groups.py 7e4fabe > test/integration/component/test_cpu_domain_limits.py c427e4f > test/integration/component/test_cpu_limits.py bdf2869 > test/integration/component/test_cpu_max_limits.py 317df16 > test/integration/component/test_cpu_project_limits.py a8a1b3c > test/integration/component/test_memory_limits.py 7921e4b > test/integration/component/test_mm_domain_limits.py 68660c1 > test/integration/component/test_mm_max_limits.py e10c119 > test/integration/component/test_mm_project_limits.py c314011 > test/integration/component/test_portable_ip.py b09daf9 > test/integration/component/test_vpc.py 1af8d81 > test/integration/component/test_vpn_users.py 02dd026 > test/integration/smoke/test_affinity_groups.py c96a580 > test/integration/smoke/test_deploy_vm.py 425aeb7 > test/integration/smoke/test_deploy_vm_with_userdata.py e3788cf > tools/marvin/marvin/asyncJobMgr.py ee0e891 > tools/marvin/marvin/cloudstackConnection.py fb03e3b > tools/marvin/marvin/cloudstackException.py 623 > tools/marvin/marvin/cloudstackTestClient.py 4ac510b > tools/marvin/marvin/codegenerator.py e0f056f > tools/marvin/marvin/codes.py 74fb05d > tools/marvin/marvin/config/test_data.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 0d79e8e > tools/marvin/marvin/dbConnection.py 99014ab > tools/marvin/marvin/deployDataCenter.py c4f6e1e > tools/marvin/marvin/integration/lib/common.py 550de1a > tools/marvin/marvin/jsonHelper.py ae40b8d > tools/marvin/marvin/marvinInit.py f722058 > tools/marvin/marvin/marvinLog.py 76de185 > tools/marvin/marvin/marvinPlugin.py df7d7a3 > tools/marvin/marvin/tcExecuteEngine.py f959e7e > > Diff: https://reviews.apache.org/r/17116/diff/ > > > Testing > --- > > > File Attachments > > > New Patch File > > https://reviews.apache.org/media/uploaded/files/2014/01/22/1759bdd3-40f9-4462-81b5-e44df20774dc__new_diff.patch > > > Thanks, > > Santhosh Edukulla > >
Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17116/#review34272 --- Commit c1d34369aa44e06be5909b823d73063f34be0f86 in branch refs/heads/marvin from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c1d3436 ] Revert "CLOUDSTACK-5674: Few fixes" This reverts commit e6b93b0a6824a3f2845fb42596c04b348ae147e2. - ASF Subversion and Git Services On Jan. 22, 2014, 10:54 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17116/ > --- > > (Updated Jan. 22, 2014, 10:54 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Repository: cloudstack-git > > > Description > --- > > Fixed few issues including pep8 in previous submitted patch ( 17113 ). Tested > Deploying a DC. > > > Diffs > - > > setup/dev/advanced.cfg 23981f0 > setup/dev/basic.cfg 3e39d6d > test/integration/component/test_add_remove_network.py 8ec2971 > test/integration/component/test_affinity_groups.py 7e4fabe > test/integration/component/test_cpu_domain_limits.py c427e4f > test/integration/component/test_cpu_limits.py bdf2869 > test/integration/component/test_cpu_max_limits.py 317df16 > test/integration/component/test_cpu_project_limits.py a8a1b3c > test/integration/component/test_memory_limits.py 7921e4b > test/integration/component/test_mm_domain_limits.py 68660c1 > test/integration/component/test_mm_max_limits.py e10c119 > test/integration/component/test_mm_project_limits.py c314011 > test/integration/component/test_portable_ip.py b09daf9 > test/integration/component/test_vpc.py 1af8d81 > test/integration/component/test_vpn_users.py 02dd026 > test/integration/smoke/test_affinity_groups.py c96a580 > test/integration/smoke/test_deploy_vm.py 425aeb7 > test/integration/smoke/test_deploy_vm_with_userdata.py e3788cf > tools/marvin/marvin/asyncJobMgr.py ee0e891 > tools/marvin/marvin/cloudstackConnection.py fb03e3b > tools/marvin/marvin/cloudstackException.py 623 > tools/marvin/marvin/cloudstackTestClient.py 4ac510b > tools/marvin/marvin/codegenerator.py e0f056f > tools/marvin/marvin/codes.py 74fb05d > tools/marvin/marvin/config/test_data.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 0d79e8e > tools/marvin/marvin/dbConnection.py 99014ab > tools/marvin/marvin/deployDataCenter.py c4f6e1e > tools/marvin/marvin/integration/lib/common.py 550de1a > tools/marvin/marvin/jsonHelper.py ae40b8d > tools/marvin/marvin/marvinInit.py f722058 > tools/marvin/marvin/marvinLog.py 76de185 > tools/marvin/marvin/marvinPlugin.py df7d7a3 > tools/marvin/marvin/tcExecuteEngine.py f959e7e > > Diff: https://reviews.apache.org/r/17116/diff/ > > > Testing > --- > > > File Attachments > > > New Patch File > > https://reviews.apache.org/media/uploaded/files/2014/01/22/1759bdd3-40f9-4462-81b5-e44df20774dc__new_diff.patch > > > Thanks, > > Santhosh Edukulla > >
Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17116/#review34264 --- Commit e6b93b0a6824a3f2845fb42596c04b348ae147e2 in branch refs/heads/marvin from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e6b93b0 ] CLOUDSTACK-5674: Few fixes - ASF Subversion and Git Services On Jan. 22, 2014, 10:54 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17116/ > --- > > (Updated Jan. 22, 2014, 10:54 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Repository: cloudstack-git > > > Description > --- > > Fixed few issues including pep8 in previous submitted patch ( 17113 ). Tested > Deploying a DC. > > > Diffs > - > > setup/dev/advanced.cfg 23981f0 > setup/dev/basic.cfg 3e39d6d > test/integration/component/test_add_remove_network.py 8ec2971 > test/integration/component/test_affinity_groups.py 7e4fabe > test/integration/component/test_cpu_domain_limits.py c427e4f > test/integration/component/test_cpu_limits.py bdf2869 > test/integration/component/test_cpu_max_limits.py 317df16 > test/integration/component/test_cpu_project_limits.py a8a1b3c > test/integration/component/test_memory_limits.py 7921e4b > test/integration/component/test_mm_domain_limits.py 68660c1 > test/integration/component/test_mm_max_limits.py e10c119 > test/integration/component/test_mm_project_limits.py c314011 > test/integration/component/test_portable_ip.py b09daf9 > test/integration/component/test_vpc.py 1af8d81 > test/integration/component/test_vpn_users.py 02dd026 > test/integration/smoke/test_affinity_groups.py c96a580 > test/integration/smoke/test_deploy_vm.py 425aeb7 > test/integration/smoke/test_deploy_vm_with_userdata.py e3788cf > tools/marvin/marvin/asyncJobMgr.py ee0e891 > tools/marvin/marvin/cloudstackConnection.py fb03e3b > tools/marvin/marvin/cloudstackException.py 623 > tools/marvin/marvin/cloudstackTestClient.py 4ac510b > tools/marvin/marvin/codegenerator.py e0f056f > tools/marvin/marvin/codes.py 74fb05d > tools/marvin/marvin/config/test_data.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 0d79e8e > tools/marvin/marvin/dbConnection.py 99014ab > tools/marvin/marvin/deployDataCenter.py c4f6e1e > tools/marvin/marvin/integration/lib/common.py 550de1a > tools/marvin/marvin/jsonHelper.py ae40b8d > tools/marvin/marvin/marvinInit.py f722058 > tools/marvin/marvin/marvinLog.py 76de185 > tools/marvin/marvin/marvinPlugin.py df7d7a3 > tools/marvin/marvin/tcExecuteEngine.py f959e7e > > Diff: https://reviews.apache.org/r/17116/diff/ > > > Testing > --- > > > File Attachments > > > New Patch File > > https://reviews.apache.org/media/uploaded/files/2014/01/22/1759bdd3-40f9-4462-81b5-e44df20774dc__new_diff.patch > > > Thanks, > > Santhosh Edukulla > >
Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17116/#review34171 --- Commit 995e3f5b5d71d5f52d18e0c3260b8624e6b6251c in branch refs/heads/marvin from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=995e3f5 ] Revert "CLOUDSTACK-5674: Few new fixes" This reverts commit 3493f17bad3b8b57778b62d464c5e7f910351cc0. - ASF Subversion and Git Services On Jan. 22, 2014, 10:54 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17116/ > --- > > (Updated Jan. 22, 2014, 10:54 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Repository: cloudstack-git > > > Description > --- > > Fixed few issues including pep8 in previous submitted patch ( 17113 ). Tested > Deploying a DC. > > > Diffs > - > > setup/dev/advanced.cfg 23981f0 > setup/dev/basic.cfg 3e39d6d > test/integration/component/test_add_remove_network.py 8ec2971 > test/integration/component/test_affinity_groups.py 7e4fabe > test/integration/component/test_cpu_domain_limits.py c427e4f > test/integration/component/test_cpu_limits.py bdf2869 > test/integration/component/test_cpu_max_limits.py 317df16 > test/integration/component/test_cpu_project_limits.py a8a1b3c > test/integration/component/test_memory_limits.py 7921e4b > test/integration/component/test_mm_domain_limits.py 68660c1 > test/integration/component/test_mm_max_limits.py e10c119 > test/integration/component/test_mm_project_limits.py c314011 > test/integration/component/test_portable_ip.py b09daf9 > test/integration/component/test_vpc.py 1af8d81 > test/integration/component/test_vpn_users.py 02dd026 > test/integration/smoke/test_affinity_groups.py c96a580 > test/integration/smoke/test_deploy_vm.py 425aeb7 > test/integration/smoke/test_deploy_vm_with_userdata.py e3788cf > tools/marvin/marvin/asyncJobMgr.py ee0e891 > tools/marvin/marvin/cloudstackConnection.py fb03e3b > tools/marvin/marvin/cloudstackException.py 623 > tools/marvin/marvin/cloudstackTestClient.py 4ac510b > tools/marvin/marvin/codegenerator.py e0f056f > tools/marvin/marvin/codes.py 74fb05d > tools/marvin/marvin/config/test_data.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 0d79e8e > tools/marvin/marvin/dbConnection.py 99014ab > tools/marvin/marvin/deployDataCenter.py c4f6e1e > tools/marvin/marvin/integration/lib/common.py 550de1a > tools/marvin/marvin/jsonHelper.py ae40b8d > tools/marvin/marvin/marvinInit.py f722058 > tools/marvin/marvin/marvinLog.py 76de185 > tools/marvin/marvin/marvinPlugin.py df7d7a3 > tools/marvin/marvin/tcExecuteEngine.py f959e7e > > Diff: https://reviews.apache.org/r/17116/diff/ > > > Testing > --- > > > File Attachments > > > New Patch File > > https://reviews.apache.org/media/uploaded/files/2014/01/22/1759bdd3-40f9-4462-81b5-e44df20774dc__new_diff.patch > > > Thanks, > > Santhosh Edukulla > >
Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17116/#review34045 --- Commit 3493f17bad3b8b57778b62d464c5e7f910351cc0 in branch refs/heads/marvin from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3493f17 ] CLOUDSTACK-5674: Few new fixes - ASF Subversion and Git Services On Jan. 22, 2014, 10:54 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17116/ > --- > > (Updated Jan. 22, 2014, 10:54 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Repository: cloudstack-git > > > Description > --- > > Fixed few issues including pep8 in previous submitted patch ( 17113 ). Tested > Deploying a DC. > > > Diffs > - > > setup/dev/advanced.cfg 23981f0 > setup/dev/basic.cfg 3e39d6d > test/integration/component/test_add_remove_network.py 8ec2971 > test/integration/component/test_affinity_groups.py 7e4fabe > test/integration/component/test_cpu_domain_limits.py c427e4f > test/integration/component/test_cpu_limits.py bdf2869 > test/integration/component/test_cpu_max_limits.py 317df16 > test/integration/component/test_cpu_project_limits.py a8a1b3c > test/integration/component/test_memory_limits.py 7921e4b > test/integration/component/test_mm_domain_limits.py 68660c1 > test/integration/component/test_mm_max_limits.py e10c119 > test/integration/component/test_mm_project_limits.py c314011 > test/integration/component/test_portable_ip.py b09daf9 > test/integration/component/test_vpc.py 1af8d81 > test/integration/component/test_vpn_users.py 02dd026 > test/integration/smoke/test_affinity_groups.py c96a580 > test/integration/smoke/test_deploy_vm.py 425aeb7 > test/integration/smoke/test_deploy_vm_with_userdata.py e3788cf > tools/marvin/marvin/asyncJobMgr.py ee0e891 > tools/marvin/marvin/cloudstackConnection.py fb03e3b > tools/marvin/marvin/cloudstackException.py 623 > tools/marvin/marvin/cloudstackTestClient.py 4ac510b > tools/marvin/marvin/codegenerator.py e0f056f > tools/marvin/marvin/codes.py 74fb05d > tools/marvin/marvin/config/test_data.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 0d79e8e > tools/marvin/marvin/dbConnection.py 99014ab > tools/marvin/marvin/deployDataCenter.py c4f6e1e > tools/marvin/marvin/integration/lib/common.py 550de1a > tools/marvin/marvin/jsonHelper.py ae40b8d > tools/marvin/marvin/marvinInit.py f722058 > tools/marvin/marvin/marvinLog.py 76de185 > tools/marvin/marvin/marvinPlugin.py df7d7a3 > tools/marvin/marvin/tcExecuteEngine.py f959e7e > > Diff: https://reviews.apache.org/r/17116/diff/ > > > Testing > --- > > > File Attachments > > > New Patch File > > https://reviews.apache.org/media/uploaded/files/2014/01/22/1759bdd3-40f9-4462-81b5-e44df20774dc__new_diff.patch > > > Thanks, > > Santhosh Edukulla > >
Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17116/#review32987 --- Commit 226df296d0fe98fbaba328eaa7d24546c42f36d2 in branch refs/heads/marvin from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=226df29 ] CLOUDSTACK-5674: Some fixes to marvin and resultant changes to tests. - ASF Subversion and Git Services On Jan. 22, 2014, 10:54 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17116/ > --- > > (Updated Jan. 22, 2014, 10:54 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Repository: cloudstack-git > > > Description > --- > > Fixed few issues including pep8 in previous submitted patch ( 17113 ). Tested > Deploying a DC. > > > Diffs > - > > setup/dev/advanced.cfg 23981f0 > setup/dev/basic.cfg 3e39d6d > test/integration/component/test_add_remove_network.py 8ec2971 > test/integration/component/test_affinity_groups.py 7e4fabe > test/integration/component/test_cpu_domain_limits.py c427e4f > test/integration/component/test_cpu_limits.py bdf2869 > test/integration/component/test_cpu_max_limits.py 317df16 > test/integration/component/test_cpu_project_limits.py a8a1b3c > test/integration/component/test_memory_limits.py 7921e4b > test/integration/component/test_mm_domain_limits.py 68660c1 > test/integration/component/test_mm_max_limits.py e10c119 > test/integration/component/test_mm_project_limits.py c314011 > test/integration/component/test_portable_ip.py b09daf9 > test/integration/component/test_vpc.py 1af8d81 > test/integration/component/test_vpn_users.py 02dd026 > test/integration/smoke/test_affinity_groups.py c96a580 > test/integration/smoke/test_deploy_vm.py 425aeb7 > test/integration/smoke/test_deploy_vm_with_userdata.py e3788cf > tools/marvin/marvin/asyncJobMgr.py ee0e891 > tools/marvin/marvin/cloudstackConnection.py fb03e3b > tools/marvin/marvin/cloudstackException.py 623 > tools/marvin/marvin/cloudstackTestClient.py 4ac510b > tools/marvin/marvin/codegenerator.py e0f056f > tools/marvin/marvin/codes.py 74fb05d > tools/marvin/marvin/config/test_data.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 0d79e8e > tools/marvin/marvin/dbConnection.py 99014ab > tools/marvin/marvin/deployDataCenter.py c4f6e1e > tools/marvin/marvin/integration/lib/common.py 550de1a > tools/marvin/marvin/jsonHelper.py ae40b8d > tools/marvin/marvin/marvinInit.py f722058 > tools/marvin/marvin/marvinLog.py 76de185 > tools/marvin/marvin/marvinPlugin.py df7d7a3 > tools/marvin/marvin/tcExecuteEngine.py f959e7e > > Diff: https://reviews.apache.org/r/17116/diff/ > > > Testing > --- > > > File Attachments > > > New Patch File > > https://reviews.apache.org/media/uploaded/files/2014/01/22/1759bdd3-40f9-4462-81b5-e44df20774dc__new_diff.patch > > > Thanks, > > Santhosh Edukulla > >
Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17116/ --- (Updated Jan. 22, 2014, 10:54 a.m.) Review request for cloudstack and Girish Shilamkar. Changes --- Attaching the new patch file as discussed. Tested to apply locally and it worked. Repository: cloudstack-git Description --- Fixed few issues including pep8 in previous submitted patch ( 17113 ). Tested Deploying a DC. Diffs - setup/dev/advanced.cfg 23981f0 setup/dev/basic.cfg 3e39d6d test/integration/component/test_add_remove_network.py 8ec2971 test/integration/component/test_affinity_groups.py 7e4fabe test/integration/component/test_cpu_domain_limits.py c427e4f test/integration/component/test_cpu_limits.py bdf2869 test/integration/component/test_cpu_max_limits.py 317df16 test/integration/component/test_cpu_project_limits.py a8a1b3c test/integration/component/test_memory_limits.py 7921e4b test/integration/component/test_mm_domain_limits.py 68660c1 test/integration/component/test_mm_max_limits.py e10c119 test/integration/component/test_mm_project_limits.py c314011 test/integration/component/test_portable_ip.py b09daf9 test/integration/component/test_vpc.py 1af8d81 test/integration/component/test_vpn_users.py 02dd026 test/integration/smoke/test_affinity_groups.py c96a580 test/integration/smoke/test_deploy_vm.py 425aeb7 test/integration/smoke/test_deploy_vm_with_userdata.py e3788cf tools/marvin/marvin/asyncJobMgr.py ee0e891 tools/marvin/marvin/cloudstackConnection.py fb03e3b tools/marvin/marvin/cloudstackException.py 623 tools/marvin/marvin/cloudstackTestClient.py 4ac510b tools/marvin/marvin/codegenerator.py e0f056f tools/marvin/marvin/codes.py 74fb05d tools/marvin/marvin/config/test_data.cfg PRE-CREATION tools/marvin/marvin/configGenerator.py 0d79e8e tools/marvin/marvin/dbConnection.py 99014ab tools/marvin/marvin/deployDataCenter.py c4f6e1e tools/marvin/marvin/integration/lib/common.py 550de1a tools/marvin/marvin/jsonHelper.py ae40b8d tools/marvin/marvin/marvinInit.py f722058 tools/marvin/marvin/marvinLog.py 76de185 tools/marvin/marvin/marvinPlugin.py df7d7a3 tools/marvin/marvin/tcExecuteEngine.py f959e7e Diff: https://reviews.apache.org/r/17116/diff/ Testing --- File Attachments (updated) New Patch File https://reviews.apache.org/media/uploaded/files/2014/01/22/1759bdd3-40f9-4462-81b5-e44df20774dc__new_diff.patch Thanks, Santhosh Edukulla
Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17116/#review32480 --- Santhosh, This patch seems to be the updated version of 17113. We will need a patch which will apply on top of 17113. Could you please fetch the marvin branch and create the patch. Thanks, Girish - Girish Shilamkar On Jan. 20, 2014, 9:26 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17116/ > --- > > (Updated Jan. 20, 2014, 9:26 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Repository: cloudstack-git > > > Description > --- > > Fixed few issues including pep8 in previous submitted patch ( 17113 ). Tested > Deploying a DC. > > > Diffs > - > > setup/dev/advanced.cfg 23981f0 > setup/dev/basic.cfg 3e39d6d > test/integration/component/test_add_remove_network.py 8ec2971 > test/integration/component/test_affinity_groups.py 7e4fabe > test/integration/component/test_cpu_domain_limits.py c427e4f > test/integration/component/test_cpu_limits.py bdf2869 > test/integration/component/test_cpu_max_limits.py 317df16 > test/integration/component/test_cpu_project_limits.py a8a1b3c > test/integration/component/test_memory_limits.py 7921e4b > test/integration/component/test_mm_domain_limits.py 68660c1 > test/integration/component/test_mm_max_limits.py e10c119 > test/integration/component/test_mm_project_limits.py c314011 > test/integration/component/test_portable_ip.py b09daf9 > test/integration/component/test_vpc.py 1af8d81 > test/integration/component/test_vpn_users.py 02dd026 > test/integration/smoke/test_affinity_groups.py c96a580 > test/integration/smoke/test_deploy_vm.py 425aeb7 > test/integration/smoke/test_deploy_vm_with_userdata.py e3788cf > tools/marvin/marvin/asyncJobMgr.py ee0e891 > tools/marvin/marvin/cloudstackConnection.py fb03e3b > tools/marvin/marvin/cloudstackException.py 623 > tools/marvin/marvin/cloudstackTestClient.py 4ac510b > tools/marvin/marvin/codegenerator.py e0f056f > tools/marvin/marvin/codes.py 74fb05d > tools/marvin/marvin/config/test_data.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 0d79e8e > tools/marvin/marvin/dbConnection.py 99014ab > tools/marvin/marvin/deployDataCenter.py c4f6e1e > tools/marvin/marvin/integration/lib/common.py 550de1a > tools/marvin/marvin/jsonHelper.py ae40b8d > tools/marvin/marvin/marvinInit.py f722058 > tools/marvin/marvin/marvinLog.py 76de185 > tools/marvin/marvin/marvinPlugin.py df7d7a3 > tools/marvin/marvin/tcExecuteEngine.py f959e7e > > Diff: https://reviews.apache.org/r/17116/diff/ > > > Testing > --- > > > Thanks, > > Santhosh Edukulla > >
