Re: Review Request 25017: Disabling VPC tests on Hyper-v

2014-08-26 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25017/
---

(Updated Aug. 26, 2014, 10 a.m.)


Review request for cloudstack, John Dilley, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

skipping VPC tests on Hyper-v. Made changes to following test scripts to skip 
VPC tests on Hyper-v :
/test/integration/smoke/test_network_acl.py 
b/test/integration/smoke/test_network_acl.py
/test/integration/smoke/test_privategw_acl.py 
b/test/integration/smoke/test_privategw_acl.py
test/integration/smoke/test_vpc_vpn.py b/test/integration/smoke/test_vpc_vpn.py


Diffs
-

  test/integration/smoke/test_network_acl.py 015ebab 
  test/integration/smoke/test_privategw_acl.py cf0f8e3 
  test/integration/smoke/test_vpc_vpn.py 9e8f97f 

Diff: https://reviews.apache.org/r/25017/diff/


Testing
---

Yes


Thanks,

sanjeev n



Re: Review Request 25017: Disabling VPC tests on Hyper-v

2014-08-26 Thread John Dilley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25017/#review51526
---


VPC is supported for Hyper-V in ACS

- John Dilley


On Aug. 26, 2014, 10 a.m., sanjeev n wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25017/
 ---
 
 (Updated Aug. 26, 2014, 10 a.m.)
 
 
 Review request for cloudstack, John Dilley, Santhosh Edukulla, and 
 SrikanteswaraRao Talluri.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 skipping VPC tests on Hyper-v. Made changes to following test scripts to skip 
 VPC tests on Hyper-v :
 /test/integration/smoke/test_network_acl.py 
 b/test/integration/smoke/test_network_acl.py
 /test/integration/smoke/test_privategw_acl.py 
 b/test/integration/smoke/test_privategw_acl.py
 test/integration/smoke/test_vpc_vpn.py 
 b/test/integration/smoke/test_vpc_vpn.py
 
 
 Diffs
 -
 
   test/integration/smoke/test_network_acl.py 015ebab 
   test/integration/smoke/test_privategw_acl.py cf0f8e3 
   test/integration/smoke/test_vpc_vpn.py 9e8f97f 
 
 Diff: https://reviews.apache.org/r/25017/diff/
 
 
 Testing
 ---
 
 Yes
 
 
 Thanks,
 
 sanjeev n
 




Re: Review Request 25017: Disabling VPC tests on Hyper-v

2014-08-26 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25017/#review51532
---

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Aug. 26, 2014, 10 a.m., sanjeev n wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25017/
 ---
 
 (Updated Aug. 26, 2014, 10 a.m.)
 
 
 Review request for cloudstack, John Dilley, Santhosh Edukulla, and 
 SrikanteswaraRao Talluri.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 skipping VPC tests on Hyper-v. Made changes to following test scripts to skip 
 VPC tests on Hyper-v :
 /test/integration/smoke/test_network_acl.py 
 b/test/integration/smoke/test_network_acl.py
 /test/integration/smoke/test_privategw_acl.py 
 b/test/integration/smoke/test_privategw_acl.py
 test/integration/smoke/test_vpc_vpn.py 
 b/test/integration/smoke/test_vpc_vpn.py
 
 
 Diffs
 -
 
   test/integration/smoke/test_network_acl.py 015ebab 
   test/integration/smoke/test_privategw_acl.py cf0f8e3 
   test/integration/smoke/test_vpc_vpn.py 9e8f97f 
 
 Diff: https://reviews.apache.org/r/25017/diff/
 
 
 Testing
 ---
 
 Yes
 
 
 Thanks,
 
 sanjeev n
 




Re: Review Request 25017: Disabling VPC tests on Hyper-v

2014-08-26 Thread Chip Childers


 On Aug. 26, 2014, 3:50 p.m., SrikanteswaraRao Talluri wrote:
  Ship It!

Why are you saying Ship It! if John's point is valid?  Shouldn't the tests be 
functional if VPC is supported for Hyper-V?


- Chip


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25017/#review51532
---


On Aug. 26, 2014, 10 a.m., sanjeev n wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25017/
 ---
 
 (Updated Aug. 26, 2014, 10 a.m.)
 
 
 Review request for cloudstack, John Dilley, Santhosh Edukulla, and 
 SrikanteswaraRao Talluri.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 skipping VPC tests on Hyper-v. Made changes to following test scripts to skip 
 VPC tests on Hyper-v :
 /test/integration/smoke/test_network_acl.py 
 b/test/integration/smoke/test_network_acl.py
 /test/integration/smoke/test_privategw_acl.py 
 b/test/integration/smoke/test_privategw_acl.py
 test/integration/smoke/test_vpc_vpn.py 
 b/test/integration/smoke/test_vpc_vpn.py
 
 
 Diffs
 -
 
   test/integration/smoke/test_network_acl.py 015ebab 
   test/integration/smoke/test_privategw_acl.py cf0f8e3 
   test/integration/smoke/test_vpc_vpn.py 9e8f97f 
 
 Diff: https://reviews.apache.org/r/25017/diff/
 
 
 Testing
 ---
 
 Yes
 
 
 Thanks,
 
 sanjeev n