RE: Review Request: CLOUDSTACK-2178 : Add guest network button is not responding
Pranav Can you review the updated patch and submit if it is good to go Animesh -Original Message- From: Isaac Chiang [mailto:nore...@reviews.apache.org] On Behalf Of Isaac Chiang Sent: Friday, May 10, 2013 12:37 AM To: Pranav Saxena Cc: cloudstack; Isaac Chiang Subject: Re: Review Request: CLOUDSTACK-2178 : Add guest network button is not responding --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10882/ --- (Updated May 10, 2013, 7:37 a.m.) Review request for cloudstack and Pranav Saxena. Changes --- Patch updated Description --- The root cause of the issue is that the makeForm function in dialog.js cannot work with dependsOn field correctly. Changed : 1. Dialog.js : Modify makeForm function in Dialog.js to work correctly with dependsOn field. 2. Network.js : Add checking for response in the call back function. This addresses bug CLOUDSTACK-2178. Diffs (updated) - ui/scripts/network.js 6b310ce ui/scripts/ui/dialog.js bb372fb Diff: https://reviews.apache.org/r/10882/diff/ Testing --- Test from ui ans work well Thanks, Isaac Chiang
Re: Review Request: CLOUDSTACK-2178 : Add guest network button is not responding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10882/#review20169 --- Review comment on the corresponding JIRA ticket to verify if its actually a valid bug . If yes , then we'll definitely proceed with validating the fix . Thanks ! - Pranav Saxena On May 1, 2013, 3:49 p.m., Isaac Chiang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10882/ --- (Updated May 1, 2013, 3:49 p.m.) Review request for cloudstack and Pranav Saxena. Description --- The root cause of the issue is that the makeForm function in dialog.js cannot work with dependsOn field correctly. Changed : 1. Dialog.js : Modify makeForm function in Dialog.js to work correctly with dependsOn field. 2. Network.js : Add checking for response in the call back function. This addresses bug CLOUDSTACK-2178. Diffs - ui/scripts/network.js 9ba725a ui/scripts/ui/dialog.js bb372fb Diff: https://reviews.apache.org/r/10882/diff/ Testing --- Test from ui ans work well Thanks, Isaac Chiang
Review Request: CLOUDSTACK-2178 : Add guest network button is not responding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10882/ --- Review request for cloudstack and Pranav Saxena. Description --- The root cause of the issue is that the makeForm function in dialog.js cannot work with dependsOn field correctly. Changed : 1. Dialog.js : Modify makeForm function in Dialog.js to work correctly with dependsOn field. 2. Network.js : Add checking for response in the call back function. This addresses bug CLOUDSTACK-2178. Diffs - ui/scripts/network.js 9ba725a ui/scripts/ui/dialog.js bb372fb Diff: https://reviews.apache.org/r/10882/diff/ Testing --- Test from ui ans work well Thanks, Isaac Chiang
