Re: Review Request: CLOUDSTACK-741 global granular parameters and CLOUDSTACK-2036 router template Id

2013-05-02 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10862/#review20107
---


Commit 4a40f3f6dade062c7996611d4b8918d3fbd59d73 in branch refs/heads/master 
from Abhinandan Prateek 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4a40f3f ]

CLOUDSTACK-741: Granular Global Parameters fixing network.throttling.rate to 
work per zone in vmware

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On April 30, 2013, 1:42 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10862/
> ---
> 
> (Updated April 30, 2013, 1:42 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-741: Granular Global Parameters Added parameters
>  to cluster level
>  cluster.storage.allocated.capacity.notificationthreshold
>  cluster.storage.capacity.notificationthreshold
> 
> CLOUDSTACK-2036
> global parameter for Router Template ID functionality added
> We use 5 parameters to set the router template name for each hypervisor
> 
> Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able 
> to update/list using update/list configuration API at cluster level
> 
> 
> This addresses bugs CLOUDSTACK-2036 and CLOUDSTACK-741.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 6839d44 
>   server/src/com/cloud/configuration/Config.java af6adcf 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 068a586 
>   server/src/com/cloud/dc/ClusterDetailsDaoImpl.java 4c85918 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 4c7bc75 
>   server/src/com/cloud/storage/dao/VMTemplateDao.java 3f1fe93 
>   server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 3b37f24 
>   test/integration/smoke/test_global_settings.py ec18cea 
> 
> Diff: https://reviews.apache.org/r/10862/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: CLOUDSTACK-741 global granular parameters and CLOUDSTACK-2036 router template Id

2013-05-01 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10862/#review20027
---


Commit 807ad0a39ab272a4af2de3156b0b367570acccea in branch refs/heads/internallb 
from Nitin Mehta 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=807ad0a ]

CLOUDSTACK-741 - Making storage disable thresholds configurable at zone level.


- ASF Subversion and Git Services


On April 30, 2013, 1:42 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10862/
> ---
> 
> (Updated April 30, 2013, 1:42 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-741: Granular Global Parameters Added parameters
>  to cluster level
>  cluster.storage.allocated.capacity.notificationthreshold
>  cluster.storage.capacity.notificationthreshold
> 
> CLOUDSTACK-2036
> global parameter for Router Template ID functionality added
> We use 5 parameters to set the router template name for each hypervisor
> 
> Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able 
> to update/list using update/list configuration API at cluster level
> 
> 
> This addresses bugs CLOUDSTACK-2036 and CLOUDSTACK-741.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 6839d44 
>   server/src/com/cloud/configuration/Config.java af6adcf 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 068a586 
>   server/src/com/cloud/dc/ClusterDetailsDaoImpl.java 4c85918 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 4c7bc75 
>   server/src/com/cloud/storage/dao/VMTemplateDao.java 3f1fe93 
>   server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 3b37f24 
>   test/integration/smoke/test_global_settings.py ec18cea 
> 
> Diff: https://reviews.apache.org/r/10862/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: CLOUDSTACK-741 global granular parameters and CLOUDSTACK-2036 router template Id

2013-05-01 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10862/#review2
---


Commit 807ad0a39ab272a4af2de3156b0b367570acccea in branch refs/heads/master 
from Nitin Mehta 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=807ad0a ]

CLOUDSTACK-741 - Making storage disable thresholds configurable at zone level.


- ASF Subversion and Git Services


On April 30, 2013, 1:42 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10862/
> ---
> 
> (Updated April 30, 2013, 1:42 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-741: Granular Global Parameters Added parameters
>  to cluster level
>  cluster.storage.allocated.capacity.notificationthreshold
>  cluster.storage.capacity.notificationthreshold
> 
> CLOUDSTACK-2036
> global parameter for Router Template ID functionality added
> We use 5 parameters to set the router template name for each hypervisor
> 
> Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able 
> to update/list using update/list configuration API at cluster level
> 
> 
> This addresses bugs CLOUDSTACK-2036 and CLOUDSTACK-741.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 6839d44 
>   server/src/com/cloud/configuration/Config.java af6adcf 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 068a586 
>   server/src/com/cloud/dc/ClusterDetailsDaoImpl.java 4c85918 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 4c7bc75 
>   server/src/com/cloud/storage/dao/VMTemplateDao.java 3f1fe93 
>   server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 3b37f24 
>   test/integration/smoke/test_global_settings.py ec18cea 
> 
> Diff: https://reviews.apache.org/r/10862/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: CLOUDSTACK-741 global granular parameters and CLOUDSTACK-2036 router template Id

2013-05-01 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10862/#review19998
---


Commit b16ccc9fa6c5dd05a3016e3b2e22ecdc3f06b1ef in branch refs/heads/master 
from Nitin Mehta 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b16ccc9 ]

CLOUDSTACK-2036 - Adding storage storage.overprovisioning.factor configurable 
at zone level.


- ASF Subversion and Git Services


On April 30, 2013, 1:42 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10862/
> ---
> 
> (Updated April 30, 2013, 1:42 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-741: Granular Global Parameters Added parameters
>  to cluster level
>  cluster.storage.allocated.capacity.notificationthreshold
>  cluster.storage.capacity.notificationthreshold
> 
> CLOUDSTACK-2036
> global parameter for Router Template ID functionality added
> We use 5 parameters to set the router template name for each hypervisor
> 
> Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able 
> to update/list using update/list configuration API at cluster level
> 
> 
> This addresses bugs CLOUDSTACK-2036 and CLOUDSTACK-741.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 6839d44 
>   server/src/com/cloud/configuration/Config.java af6adcf 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 068a586 
>   server/src/com/cloud/dc/ClusterDetailsDaoImpl.java 4c85918 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 4c7bc75 
>   server/src/com/cloud/storage/dao/VMTemplateDao.java 3f1fe93 
>   server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 3b37f24 
>   test/integration/smoke/test_global_settings.py ec18cea 
> 
> Diff: https://reviews.apache.org/r/10862/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: CLOUDSTACK-741 global granular parameters and CLOUDSTACK-2036 router template Id

2013-04-30 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10862/#review19993
---


Commit 10b6c1c6c8f8c2ec49145a901fb083e7f362f3a1 in branch refs/heads/master 
from Abhinandan Prateek 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=10b6c1c ]

CLOUDSTACK-741: Granular Global Parameters Added parameters to cluster level 
cluster.storage.allocated.capacity.notificationthreshold 
cluster.storage.capacity.notificationthreshold

CLOUDSTACK-2036
global parameter for Router Template ID functionality added
We use 5 parameters to set the router template name for each hypervisor

Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able to 
update/list using update/list configuration API at cluster level.

Signed-off-by: Abhinandan Prateek 


- ASF Subversion and Git Services


On April 30, 2013, 1:42 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10862/
> ---
> 
> (Updated April 30, 2013, 1:42 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-741: Granular Global Parameters Added parameters
>  to cluster level
>  cluster.storage.allocated.capacity.notificationthreshold
>  cluster.storage.capacity.notificationthreshold
> 
> CLOUDSTACK-2036
> global parameter for Router Template ID functionality added
> We use 5 parameters to set the router template name for each hypervisor
> 
> Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able 
> to update/list using update/list configuration API at cluster level
> 
> 
> This addresses bugs CLOUDSTACK-2036 and CLOUDSTACK-741.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 6839d44 
>   server/src/com/cloud/configuration/Config.java af6adcf 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 068a586 
>   server/src/com/cloud/dc/ClusterDetailsDaoImpl.java 4c85918 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 4c7bc75 
>   server/src/com/cloud/storage/dao/VMTemplateDao.java 3f1fe93 
>   server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 3b37f24 
>   test/integration/smoke/test_global_settings.py ec18cea 
> 
> Diff: https://reviews.apache.org/r/10862/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: CLOUDSTACK-741 global granular parameters and CLOUDSTACK-2036 router template Id

2013-04-30 Thread Abhinandan Prateek 


> On May 1, 2013, 6:21 a.m., Abhinandan Prateek wrote:
> > Ship It!

Waiting for nitin's review.


- Abhinandan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10862/#review19991
---


On April 30, 2013, 1:42 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10862/
> ---
> 
> (Updated April 30, 2013, 1:42 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-741: Granular Global Parameters Added parameters
>  to cluster level
>  cluster.storage.allocated.capacity.notificationthreshold
>  cluster.storage.capacity.notificationthreshold
> 
> CLOUDSTACK-2036
> global parameter for Router Template ID functionality added
> We use 5 parameters to set the router template name for each hypervisor
> 
> Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able 
> to update/list using update/list configuration API at cluster level
> 
> 
> This addresses bugs CLOUDSTACK-2036 and CLOUDSTACK-741.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 6839d44 
>   server/src/com/cloud/configuration/Config.java af6adcf 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 068a586 
>   server/src/com/cloud/dc/ClusterDetailsDaoImpl.java 4c85918 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 4c7bc75 
>   server/src/com/cloud/storage/dao/VMTemplateDao.java 3f1fe93 
>   server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 3b37f24 
>   test/integration/smoke/test_global_settings.py ec18cea 
> 
> Diff: https://reviews.apache.org/r/10862/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: CLOUDSTACK-741 global granular parameters and CLOUDSTACK-2036 router template Id

2013-04-30 Thread Nitin Mehta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10862/#review19990
---

Ship it!



server/src/com/cloud/configuration/Config.java


Name is not unique.  Its a TO DO item.
Please create a bug to make it unique if you are going down this path.



server/src/com/cloud/dc/ClusterDetailsDaoImpl.java


Can you please create a bug to fix this in future ?


- Nitin Mehta


On April 30, 2013, 1:42 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10862/
> ---
> 
> (Updated April 30, 2013, 1:42 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-741: Granular Global Parameters Added parameters
>  to cluster level
>  cluster.storage.allocated.capacity.notificationthreshold
>  cluster.storage.capacity.notificationthreshold
> 
> CLOUDSTACK-2036
> global parameter for Router Template ID functionality added
> We use 5 parameters to set the router template name for each hypervisor
> 
> Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able 
> to update/list using update/list configuration API at cluster level
> 
> 
> This addresses bugs CLOUDSTACK-2036 and CLOUDSTACK-741.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 6839d44 
>   server/src/com/cloud/configuration/Config.java af6adcf 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 068a586 
>   server/src/com/cloud/dc/ClusterDetailsDaoImpl.java 4c85918 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 4c7bc75 
>   server/src/com/cloud/storage/dao/VMTemplateDao.java 3f1fe93 
>   server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 3b37f24 
>   test/integration/smoke/test_global_settings.py ec18cea 
> 
> Diff: https://reviews.apache.org/r/10862/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request: CLOUDSTACK-741 global granular parameters and CLOUDSTACK-2036 router template Id

2013-04-30 Thread Abhinandan Prateek 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10862/#review19991
---

Ship it!


Ship It!

- Abhinandan Prateek


On April 30, 2013, 1:42 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10862/
> ---
> 
> (Updated April 30, 2013, 1:42 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-741: Granular Global Parameters Added parameters
>  to cluster level
>  cluster.storage.allocated.capacity.notificationthreshold
>  cluster.storage.capacity.notificationthreshold
> 
> CLOUDSTACK-2036
> global parameter for Router Template ID functionality added
> We use 5 parameters to set the router template name for each hypervisor
> 
> Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able 
> to update/list using update/list configuration API at cluster level
> 
> 
> This addresses bugs CLOUDSTACK-2036 and CLOUDSTACK-741.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 6839d44 
>   server/src/com/cloud/configuration/Config.java af6adcf 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 068a586 
>   server/src/com/cloud/dc/ClusterDetailsDaoImpl.java 4c85918 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 4c7bc75 
>   server/src/com/cloud/storage/dao/VMTemplateDao.java 3f1fe93 
>   server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 3b37f24 
>   test/integration/smoke/test_global_settings.py ec18cea 
> 
> Diff: https://reviews.apache.org/r/10862/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Review Request: CLOUDSTACK-741 global granular parameters and CLOUDSTACK-2036 router template Id

2013-04-30 Thread Harikrishna Patnala 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10862/
---

Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.


Description
---

CLOUDSTACK-741: Granular Global Parameters Added parameters
 to cluster level
 cluster.storage.allocated.capacity.notificationthreshold
 cluster.storage.capacity.notificationthreshold

CLOUDSTACK-2036
global parameter for Router Template ID functionality added
We use 5 parameters to set the router template name for each hypervisor

Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able to 
update/list using update/list configuration API at cluster level


This addresses bugs CLOUDSTACK-2036 and CLOUDSTACK-741.


Diffs
-

  server/src/com/cloud/alert/AlertManagerImpl.java 6839d44 
  server/src/com/cloud/configuration/Config.java af6adcf 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 068a586 
  server/src/com/cloud/dc/ClusterDetailsDaoImpl.java 4c85918 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
4c7bc75 
  server/src/com/cloud/storage/dao/VMTemplateDao.java 3f1fe93 
  server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 3b37f24 
  test/integration/smoke/test_global_settings.py ec18cea 

Diff: https://reviews.apache.org/r/10862/diff/


Testing
---

Tested locally


Thanks,

Harikrishna Patnala