Review Request: CLOUDSTACK -2297 : Delete Account/Domain is not updating the resources usage of the parent domain

2013-05-12 Thread Sanjay Tripathi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11081/
---

Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min 
Chen.


Description
---

CLOUDSTACK-2297 : Delete Account/Domain is not updating the resources usage of 
the parent domain


This addresses bug CLOUDSTACK-2297.


Diffs
-

  server/src/com/cloud/user/AccountManagerImpl.java 4088f64 

Diff: https://reviews.apache.org/r/11081/diff/


Testing
---

Tests:

1. Create Child domains under ROOT domain
2. Create user/admin accounts under this child domain
3. Deploy one instance as the child Domain user & other instance as one more 
account.
4. Delete the Account

Verify the resources usage

5. Delete the Domain

Verify the resources usage

Observation:
Delete Account/Domain is updating the resources usage of the parent domain 


Thanks,

Sanjay Tripathi



Re: Review Request: CLOUDSTACK -2297 : Delete Account/Domain is not updating the resources usage of the parent domain

2013-05-13 Thread Sanjay Tripathi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11081/
---

(Updated May 14, 2013, 6:50 a.m.)


Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min 
Chen.


Changes
---

Updated patch.


Description
---

CLOUDSTACK-2297 : Delete Account/Domain is not updating the resources usage of 
the parent domain


This addresses bug CLOUDSTACK-2297.


Diffs (updated)
-

  engine/schema/src/com/cloud/configuration/dao/ResourceCountDao.java 111bcb1 
  engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java 
52bc746 
  engine/schema/src/com/cloud/configuration/dao/ResourceLimitDao.java 5fd79b3 
  engine/schema/src/com/cloud/configuration/dao/ResourceLimitDaoImpl.java 
d337070 
  server/src/com/cloud/user/AccountManagerImpl.java 4088f64 
  server/src/com/cloud/user/DomainManagerImpl.java dbcbe4e 

Diff: https://reviews.apache.org/r/11081/diff/


Testing
---

Tests:

1. Create Child domains under ROOT domain
2. Create user/admin accounts under this child domain
3. Deploy one instance as the child Domain user & other instance as one more 
account.
4. Delete the Account

Verify the resources usage

5. Delete the Domain

Verify the resources usage

Observation:
Delete Account/Domain is updating the resources usage of the parent domain 


Thanks,

Sanjay Tripathi



Re: Review Request: CLOUDSTACK -2297 : Delete Account/Domain is not updating the resources usage of the parent domain

2013-05-13 Thread Sanjay Tripathi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11081/
---

(Updated May 14, 2013, 6:55 a.m.)


Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min 
Chen.


Description
---

CLOUDSTACK-2297 : Delete Account/Domain is not updating the resources usage of 
the parent domain


This addresses bug CLOUDSTACK-2297.


Diffs (updated)
-

  engine/schema/src/com/cloud/configuration/dao/ResourceCountDao.java 111bcb1 
  engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java 
52bc746 
  engine/schema/src/com/cloud/configuration/dao/ResourceLimitDao.java 5fd79b3 
  engine/schema/src/com/cloud/configuration/dao/ResourceLimitDaoImpl.java 
d337070 
  server/src/com/cloud/user/AccountManagerImpl.java 4088f64 
  server/src/com/cloud/user/DomainManagerImpl.java dbcbe4e 

Diff: https://reviews.apache.org/r/11081/diff/


Testing
---

Tests:

1. Create Child domains under ROOT domain
2. Create user/admin accounts under this child domain
3. Deploy one instance as the child Domain user & other instance as one more 
account.
4. Delete the Account

Verify the resources usage

5. Delete the Domain

Verify the resources usage

Observation:
Delete Account/Domain is updating the resources usage of the parent domain 


Thanks,

Sanjay Tripathi



Re: Review Request: CLOUDSTACK -2297 : Delete Account/Domain is not updating the resources usage of the parent domain

2013-05-20 Thread Devdeep Singh


> On May 20, 2013, 8:53 a.m., Devdeep Singh wrote:
> > Ship It!

Committed in commid-id a2fea4d4499a963a7bb5aed73b4ee03016684529. Kindly close 
the request.


- Devdeep


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11081/#review20754
---


On May 14, 2013, 6:55 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11081/
> ---
> 
> (Updated May 14, 2013, 6:55 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min 
> Chen.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2297 : Delete Account/Domain is not updating the resources usage 
> of the parent domain
> 
> 
> This addresses bug CLOUDSTACK-2297.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/configuration/dao/ResourceCountDao.java 111bcb1 
>   engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java 
> 52bc746 
>   engine/schema/src/com/cloud/configuration/dao/ResourceLimitDao.java 5fd79b3 
>   engine/schema/src/com/cloud/configuration/dao/ResourceLimitDaoImpl.java 
> d337070 
>   server/src/com/cloud/user/AccountManagerImpl.java 4088f64 
>   server/src/com/cloud/user/DomainManagerImpl.java dbcbe4e 
> 
> Diff: https://reviews.apache.org/r/11081/diff/
> 
> 
> Testing
> ---
> 
> Tests:
> 
> 1. Create Child domains under ROOT domain
> 2. Create user/admin accounts under this child domain
> 3. Deploy one instance as the child Domain user & other instance as one more 
> account.
> 4. Delete the Account
> 
> Verify the resources usage
> 
> 5. Delete the Domain
> 
> Verify the resources usage
> 
> Observation:
> Delete Account/Domain is updating the resources usage of the parent domain 
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: Review Request: CLOUDSTACK -2297 : Delete Account/Domain is not updating the resources usage of the parent domain

2013-05-20 Thread Devdeep Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11081/#review20754
---

Ship it!


Ship It!

- Devdeep Singh


On May 14, 2013, 6:55 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11081/
> ---
> 
> (Updated May 14, 2013, 6:55 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min 
> Chen.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2297 : Delete Account/Domain is not updating the resources usage 
> of the parent domain
> 
> 
> This addresses bug CLOUDSTACK-2297.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/configuration/dao/ResourceCountDao.java 111bcb1 
>   engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java 
> 52bc746 
>   engine/schema/src/com/cloud/configuration/dao/ResourceLimitDao.java 5fd79b3 
>   engine/schema/src/com/cloud/configuration/dao/ResourceLimitDaoImpl.java 
> d337070 
>   server/src/com/cloud/user/AccountManagerImpl.java 4088f64 
>   server/src/com/cloud/user/DomainManagerImpl.java dbcbe4e 
> 
> Diff: https://reviews.apache.org/r/11081/diff/
> 
> 
> Testing
> ---
> 
> Tests:
> 
> 1. Create Child domains under ROOT domain
> 2. Create user/admin accounts under this child domain
> 3. Deploy one instance as the child Domain user & other instance as one more 
> account.
> 4. Delete the Account
> 
> Verify the resources usage
> 
> 5. Delete the Domain
> 
> Verify the resources usage
> 
> Observation:
> Delete Account/Domain is updating the resources usage of the parent domain 
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>