Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
The cool thing about this merge was that Sanjeev put in the tests for this feature much before the feature landed in master. It's a demonstration of how tests can proceed in parallel with feature development provided the FS is clear on use cases and API documentation Great work Sanjeev! I just ran the tests using the mvn + marvin + simulator integration and it already discovers a couple of failures which will be filed as bugs :) https://gist.github.com/vogxn/5575005 On Mon, May 13, 2013 at 11:40:02AM -, Koushik Das wrote: On May 13, 2013, 11:37 a.m., Koushik Das wrote: Ship It! Committed to master commit 052c24c4d1c881f791b804dbb9c2fc083af7da36 - Koushik Powered by BigRock.com
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
Good initiative Sanjeev. It would be really cool if we can follow this model as much as possible going fwd for feature development. Not to say that the feature dev shouldn't submit the integration tests :). On 14/05/13 3:58 PM, Prasanna Santhanam t...@apache.org wrote: The cool thing about this merge was that Sanjeev put in the tests for this feature much before the feature landed in master. It's a demonstration of how tests can proceed in parallel with feature development provided the FS is clear on use cases and API documentation Great work Sanjeev! I just ran the tests using the mvn + marvin + simulator integration and it already discovers a couple of failures which will be filed as bugs :) https://gist.github.com/vogxn/5575005 On Mon, May 13, 2013 at 11:40:02AM -, Koushik Das wrote: On May 13, 2013, 11:37 a.m., Koushik Das wrote: Ship It! Committed to master commit 052c24c4d1c881f791b804dbb9c2fc083af7da36 - Koushik Powered by BigRock.com
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
On Tue, May 14, 2013 at 10:42:48AM +, Nitin Mehta wrote: Good initiative Sanjeev. It would be really cool if we can follow this model as much as possible going fwd for feature development. Not to say that the feature dev shouldn't submit the integration tests :). Working together with others on a feature is a good thing! On 14/05/13 3:58 PM, Prasanna Santhanam t...@apache.org wrote: The cool thing about this merge was that Sanjeev put in the tests for this feature much before the feature landed in master. It's a demonstration of how tests can proceed in parallel with feature development provided the FS is clear on use cases and API documentation Great work Sanjeev! I just ran the tests using the mvn + marvin + simulator integration and it already discovers a couple of failures which will be filed as bugs :) https://gist.github.com/vogxn/5575005 On Mon, May 13, 2013 at 11:40:02AM -, Koushik Das wrote: On May 13, 2013, 11:37 a.m., Koushik Das wrote: Ship It! Committed to master commit 052c24c4d1c881f791b804dbb9c2fc083af7da36 - Koushik Powered by BigRock.com
RE: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
-Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Tuesday, May 14, 2013 7:00 AM To: dev@cloudstack.apache.org Cc: Sanjeev Neelarapu Subject: Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets On Tue, May 14, 2013 at 10:42:48AM +, Nitin Mehta wrote: Good initiative Sanjeev. It would be really cool if we can follow this model as much as possible going fwd for feature development. Not to say that the feature dev shouldn't submit the integration tests :). Working together with others on a feature is a good thing! [Animesh] Test Driven Development helps clarify requirements early on and results in better quality code and this is the only way you can guarantee that you have full automation coverage. Good job Sanjeev On 14/05/13 3:58 PM, Prasanna Santhanam t...@apache.org wrote: The cool thing about this merge was that Sanjeev put in the tests for this feature much before the feature landed in master. It's a demonstration of how tests can proceed in parallel with feature development provided the FS is clear on use cases and API documentation Great work Sanjeev! I just ran the tests using the mvn + marvin + simulator integration and it already discovers a couple of failures which will be filed as bugs :) https://gist.github.com/vogxn/5575005 On Mon, May 13, 2013 at 11:40:02AM -, Koushik Das wrote: On May 13, 2013, 11:37 a.m., Koushik Das wrote: Ship It! Committed to master commit 052c24c4d1c881f791b804dbb9c2fc083af7da36 - Koushik Powered by BigRock.com
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 13, 2013, 9:34 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Changes --- removed white space changes in bash scripts. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Marvin tests are at https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This feature supports only ipv4 This addresses bug Cloudstack-702. Diffs (updated) - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in a41797e core/src/com/cloud/agent/api/routing/CreateIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f engine/schema/src/com/cloud/vm/dao/NicDao.java 12efe08 engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java fa30168 patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java b72d1c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 6d7e0e7 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 804e4a6 scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/vmops 30b5300 scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 server/src/com/cloud/configuration/ConfigurationManager.java d2f8319 server/src/com/cloud/configuration/ConfigurationManagerImpl.java fdc0ffb server/src/com/cloud/network/NetworkManager.java 34a092a server/src/com/cloud/network/NetworkManagerImpl.java 29c04ed server/src/com/cloud/network/addr/PublicIp.java 25e9d30 server/src/com/cloud/network/element/VirtualRouterElement.java 28473cc server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java fcf650f server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java e3dd06b server/src/com/cloud/vm/dao/NicIpAliasDao.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasVO.java PRE-CREATION server/test/com/cloud/configuration/ValidateIpRangeTest.java PRE-CREATION
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/#review20481 --- Ship it! Ship It! - Koushik Das On May 13, 2013, 9:34 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 13, 2013, 9:34 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Marvin tests are at https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This feature supports only ipv4 This addresses bug Cloudstack-702. Diffs - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in a41797e core/src/com/cloud/agent/api/routing/CreateIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f engine/schema/src/com/cloud/vm/dao/NicDao.java 12efe08 engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java fa30168 patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java b72d1c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 6d7e0e7 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 804e4a6 scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/vmops 30b5300 scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 server/src/com/cloud/configuration/ConfigurationManager.java d2f8319 server/src/com/cloud/configuration/ConfigurationManagerImpl.java fdc0ffb server/src/com/cloud/network/NetworkManager.java 34a092a server/src/com/cloud/network/NetworkManagerImpl.java 29c04ed server/src/com/cloud/network/addr/PublicIp.java 25e9d30 server/src/com/cloud/network/element/VirtualRouterElement.java 28473cc server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java fcf650f
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 6:54 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Changes --- removed the stars in import statements from citrixResourceBase. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This addresses bug Cloudstack-702. Diffs (updated) - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 36f232c core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION core/src/com/cloud/agent/api/routing/createIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f engine/schema/src/com/cloud/vm/dao/NicDao.java 67c1e07 engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java c70d194 patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java b72d1c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java d87da64 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 804e4a6 scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/vmops 30b5300 scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 server/src/com/cloud/configuration/ConfigurationManager.java bce1776 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793 server/src/com/cloud/network/NetworkManager.java 4af716c server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1 server/src/com/cloud/network/addr/PublicIp.java 25e9d30 server/src/com/cloud/network/element/VirtualRouterElement.java f601f4f server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java f49ab79 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6620e0a server/src/com/cloud/vm/dao/NicIpAliasDao.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasVO.java PRE-CREATION server/test/com/cloud/configuration/ValidateIpRangeTest.java PRE-CREATION server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8 server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 83b1924
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/#review20416 --- core/src/com/cloud/agent/api/routing/createIpAliasCommand.java https://reviews.apache.org/r/11027/#comment42065 Start of class name should be in caps. Same for file name. core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java https://reviews.apache.org/r/11027/#comment42067 createIpAliasCmd-CreateIpAliasCmd core/src/com/cloud/network/DnsMasqConfigurator.java https://reviews.apache.org/r/11027/#comment42064 It is better to move this to a separate file so that any changes to the content doesn't require a compilation core/src/com/cloud/network/DnsMasqConfigurator.java https://reviews.apache.org/r/11027/#comment42066 You are appending all the dns entries without any separators engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java https://reviews.apache.org/r/11027/#comment42063 Fix spacing patches/systemvm/debian/config/root/createIpAlias.sh https://reviews.apache.org/r/11027/#comment42060 Whats this comemnt about? patches/systemvm/debian/config/root/createIpAlias.sh https://reviews.apache.org/r/11027/#comment42061 Make the logs useful ir remove them patches/systemvm/debian/config/root/deleteIpAlias.sh https://reviews.apache.org/r/11027/#comment42059 Remove unwanted whitespaces patches/systemvm/debian/config/root/deleteIpAlias.sh https://reviews.apache.org/r/11027/#comment42062 Some comment explaining why createIpAlias.sh is required would help patches/systemvm/debian/config/root/dnsmasq.sh https://reviews.apache.org/r/11027/#comment42057 paqth - path patches/systemvm/debian/config/root/dnsmasq.sh https://reviews.apache.org/r/11027/#comment42058 This needs to be uncommented. Also remove unwanted whitespaces scripts/vm/hypervisor/xenserver/createipAlias.sh https://reviews.apache.org/r/11027/#comment42068 Unwanted comment scripts/vm/hypervisor/xenserver/createipAlias.sh https://reviews.apache.org/r/11027/#comment42069 Remove whitespaces server/src/com/cloud/configuration/ConfigurationManager.java https://reviews.apache.org/r/11027/#comment42070 Is this file required to be modified? server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java https://reviews.apache.org/r/11027/#comment42071 configDhcp - configDhcpForSubnet server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java https://reviews.apache.org/r/11027/#comment42073 Again configDhcp, change it to correct name. - Koushik Das On May 10, 2013, 6:54 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 6:54 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This addresses bug Cloudstack-702. Diffs - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 36f232c core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 11:18 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This addresses bug Cloudstack-702. Diffs (updated) - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 36f232c core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION core/src/com/cloud/agent/api/routing/createIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f engine/schema/src/com/cloud/vm/dao/NicDao.java 67c1e07 engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java c70d194 patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java b72d1c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java d87da64 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 804e4a6 scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/vmops 30b5300 scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 server/src/com/cloud/configuration/ConfigurationManager.java bce1776 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793 server/src/com/cloud/network/NetworkManager.java 4af716c server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1 server/src/com/cloud/network/addr/PublicIp.java 25e9d30 server/src/com/cloud/network/element/VirtualRouterElement.java f601f4f server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java f49ab79 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6620e0a server/src/com/cloud/vm/dao/NicIpAliasDao.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasVO.java PRE-CREATION server/test/com/cloud/configuration/ValidateIpRangeTest.java PRE-CREATION server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8 server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 83b1924 server/test/com/cloud/vpc/MockNetworkManagerImpl.java f884ba1
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 11:51 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Changes --- Jira ticket https://issues.apache.org/jira/browse/CLOUDSTACK-702 FS https://cwiki.apache.org/confluence/display/CLOUDSTACK/Multiple+Ip+ranges+FS Unit tests server/test/com/cloud/configuration/ValidateIpRangeTest.java RAT build is successful. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This addresses bug Cloudstack-702. Diffs (updated) - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 36f232c core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION core/src/com/cloud/agent/api/routing/createIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f engine/schema/src/com/cloud/vm/dao/NicDao.java 67c1e07 engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java c70d194 patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java b72d1c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java d87da64 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 804e4a6 scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/vmops 30b5300 scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 server/src/com/cloud/configuration/ConfigurationManager.java bce1776 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793 server/src/com/cloud/network/NetworkManager.java 4af716c server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1 server/src/com/cloud/network/addr/PublicIp.java 25e9d30 server/src/com/cloud/network/element/VirtualRouterElement.java f601f4f server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java f49ab79 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6620e0a server/src/com/cloud/vm/dao/NicIpAliasDao.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasVO.java PRE-CREATION
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
On May 10, 2013, 10:49 a.m., Koushik Das wrote: core/src/com/cloud/network/DnsMasqConfigurator.java, line 47 https://reviews.apache.org/r/11027/diff/2/?file=289890#file289890line47 It is better to move this to a separate file so that any changes to the content doesn't require a compilation created an enhancement bug for doing this https://issues.apache.org/jira/browse/CLOUDSTACK-2438 - bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/#review20416 --- On May 10, 2013, 11:51 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 11:51 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This addresses bug Cloudstack-702. Diffs - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 36f232c core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION core/src/com/cloud/agent/api/routing/createIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f engine/schema/src/com/cloud/vm/dao/NicDao.java 67c1e07 engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java c70d194 patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java b72d1c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java d87da64 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 804e4a6 scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/vmops 30b5300 scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 server/src/com/cloud/configuration/ConfigurationManager.java bce1776 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793 server/src/com/cloud/network/NetworkManager.java 4af716c server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 12:08 p.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Changes --- Marvin tests are at https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 This feature is implemented only for ipv4. Description (updated) --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Marvin tests are at https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This feature supports only ipv4 This addresses bug Cloudstack-702. Diffs - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 36f232c core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION core/src/com/cloud/agent/api/routing/createIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f engine/schema/src/com/cloud/vm/dao/NicDao.java 67c1e07 engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java c70d194 patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java b72d1c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java d87da64 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 804e4a6 scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/vmops 30b5300 scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 server/src/com/cloud/configuration/ConfigurationManager.java bce1776 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793 server/src/com/cloud/network/NetworkManager.java 4af716c server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1 server/src/com/cloud/network/addr/PublicIp.java 25e9d30 server/src/com/cloud/network/element/VirtualRouterElement.java f601f4f server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java f49ab79 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6620e0a server/src/com/cloud/vm/dao/NicIpAliasDao.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasVO.java PRE-CREATION
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 1:50 p.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Changes --- Rebased with latest master. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Marvin tests are at https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This feature supports only ipv4 This addresses bug Cloudstack-702. Diffs (updated) - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 67c8ccf core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION core/src/com/cloud/agent/api/routing/createIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f engine/schema/src/com/cloud/vm/dao/NicDao.java 12efe08 engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java fa30168 patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java b72d1c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 6d7e0e7 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 804e4a6 scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/vmops 30b5300 scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 server/src/com/cloud/configuration/ConfigurationManager.java d2f8319 server/src/com/cloud/configuration/ConfigurationManagerImpl.java fdc0ffb server/src/com/cloud/network/NetworkManager.java 34a092a server/src/com/cloud/network/NetworkManagerImpl.java c912430 server/src/com/cloud/network/addr/PublicIp.java 25e9d30 server/src/com/cloud/network/element/VirtualRouterElement.java 28473cc server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java fcf650f server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java e3dd06b server/src/com/cloud/vm/dao/NicIpAliasDao.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasVO.java PRE-CREATION server/test/com/cloud/configuration/ValidateIpRangeTest.java PRE-CREATION
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 2:23 p.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Marvin tests are at https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This feature supports only ipv4 This addresses bug Cloudstack-702. Diffs (updated) - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 67c8ccf core/src/com/cloud/agent/api/routing/CreateIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f engine/schema/src/com/cloud/vm/dao/NicDao.java 12efe08 engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java fa30168 patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java b72d1c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 6d7e0e7 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 804e4a6 scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/vmops 30b5300 scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 server/src/com/cloud/configuration/ConfigurationManager.java d2f8319 server/src/com/cloud/configuration/ConfigurationManagerImpl.java fdc0ffb server/src/com/cloud/network/NetworkManager.java 34a092a server/src/com/cloud/network/NetworkManagerImpl.java c912430 server/src/com/cloud/network/addr/PublicIp.java 25e9d30 server/src/com/cloud/network/element/VirtualRouterElement.java 28473cc server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java fcf650f server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java e3dd06b server/src/com/cloud/vm/dao/NicIpAliasDao.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasVO.java PRE-CREATION server/test/com/cloud/configuration/ValidateIpRangeTest.java PRE-CREATION server/test/com/cloud/network/MockNetworkManagerImpl.java eb5fc25
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 2:30 p.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Marvin tests are at https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This feature supports only ipv4 This addresses bug Cloudstack-702. Diffs (updated) - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 67c8ccf core/src/com/cloud/agent/api/routing/CreateIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f engine/schema/src/com/cloud/vm/dao/NicDao.java 12efe08 engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java fa30168 patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java b72d1c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 6d7e0e7 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 804e4a6 scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/vmops 30b5300 scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 server/src/com/cloud/configuration/ConfigurationManager.java d2f8319 server/src/com/cloud/configuration/ConfigurationManagerImpl.java fdc0ffb server/src/com/cloud/network/NetworkManager.java 34a092a server/src/com/cloud/network/NetworkManagerImpl.java c912430 server/src/com/cloud/network/addr/PublicIp.java 25e9d30 server/src/com/cloud/network/element/VirtualRouterElement.java 28473cc server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java fcf650f server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java e3dd06b server/src/com/cloud/vm/dao/NicIpAliasDao.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasVO.java PRE-CREATION server/test/com/cloud/configuration/ValidateIpRangeTest.java PRE-CREATION server/test/com/cloud/network/MockNetworkManagerImpl.java eb5fc25
Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. This is duplicate of the pervious review request https://reviews.apache.org/r/10948/. please ignore it. I have added the unit test Also accomodated some of the changes suggested by koushik. corrected the import statements. renamed the IpAlias command to createIpAlias command. This addresses bug Cloudstack-702. Diffs - api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 36f232c core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION core/src/com/cloud/agent/api/routing/createIpAliasCommand.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f engine/schema/src/com/cloud/vm/dao/NicDao.java 67c1e07 engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java c70d194 patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java b72d1c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java d87da64 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 804e4a6 scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION scripts/vm/hypervisor/xenserver/vmops 30b5300 scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 server/src/com/cloud/configuration/ConfigurationManager.java bce1776 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793 server/src/com/cloud/network/NetworkManager.java 4af716c server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1 server/src/com/cloud/network/addr/PublicIp.java 25e9d30 server/src/com/cloud/network/element/VirtualRouterElement.java f601f4f server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java f49ab79 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6620e0a server/src/com/cloud/vm/dao/NicIpAliasDao.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java PRE-CREATION server/src/com/cloud/vm/dao/NicIpAliasVO.java PRE-CREATION server/test/com/cloud/configuration/ValidateIpRangeTest.java PRE-CREATION server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8 server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 83b1924 server/test/com/cloud/vpc/MockNetworkManagerImpl.java f884ba1
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10948/#review20307 --- Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch refs/heads/master from Prasanna Santhanam t...@apache.org [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 ] CLOUDSTACK-702: Tests for Multiple IP Ranges-R4 Add ip range overlapped with two ip ranges in the exiting cidr Signed-off-by: sanjeevneelarapu sanjeev.neelar...@citrix.com Signed-off-by: Prasanna Santhanam t...@apache.org - ASF Subversion and Git Services On May 6, 2013, 4:42 p.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10948/ --- (Updated May 6, 2013, 4:42 p.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to github https://github.com/bvbharatk/cloud-stack/commit/052ebe7fc7dea5ece99cadc23b306c5f8d6e0ea9 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. The code dose not include any unit tests as of now. will add them asap. This addresses bug Cloudstack-702. https://issues.apache.org/jira/browse/Cloudstack-702 Diffs - Diff: https://reviews.apache.org/r/10948/diff/ Testing --- Tested this with xenserver in basic zone. Thanks, bharat kumar
Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10948/ --- Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description --- Cloudstack-702. Multiple ip ranges in different subnets. This feature enables adding of guest ip ranges (public ips) form different subnets. In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router. The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias. I have pushed the code to github https://github.com/bvbharatk/cloud-stack/commit/052ebe7fc7dea5ece99cadc23b306c5f8d6e0ea9 , also rebased the code with master. I need to test the code for advanced sg enabled network using kvm. The code dose not include any unit tests as of now. will add them asap. This addresses bug Cloudstack-702. https://issues.apache.org/jira/browse/Cloudstack-702 Diffs - Diff: https://reviews.apache.org/r/10948/diff/ Testing --- Tested this with xenserver in basic zone. Thanks, bharat kumar
