Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11380/ --- Review request for cloudstack, Devdeep Singh and Prachi Damle. Description --- Patch 2 for https://reviews.apache.org/r/11379/ Created for files server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java, server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java This addresses bug CLOUDSTACK-681. Diffs - server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java e3b7d31 server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 484b044 Diff: https://reviews.apache.org/r/11380/diff/ Testing --- Unittest: For the new APIs and Service, added unit tests under : plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava
Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11380/ --- (Updated May 28, 2013, 1:47 a.m.) Review request for cloudstack, Devdeep Singh and Prachi Damle. Description --- Patch 2 for https://reviews.apache.org/r/11379/ Created for files server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java, server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java This addresses bug CLOUDSTACK-681. Diffs (updated) - server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java e3b7d31 server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 484b044 Diff: https://reviews.apache.org/r/11380/diff/ Testing --- Unittest: For the new APIs and Service, added unit tests under : plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava
Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11380/ --- (Updated May 28, 2013, 1:07 p.m.) Review request for cloudstack, Devdeep Singh and Prachi Damle. Changes --- Updated Patch. Description --- Patch 2 for https://reviews.apache.org/r/11379/ Created for files server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java, server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java This addresses bug CLOUDSTACK-681. Diffs (updated) - server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java e3b7d31 server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 484b044 Diff: https://reviews.apache.org/r/11380/diff/ Testing --- Unittest: For the new APIs and Service, added unit tests under : plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava
Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11380/#review21179 --- Ship it! Ship It! - Prachi Damle On May 28, 2013, 1:07 p.m., Saksham Srivastava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11380/ > --- > > (Updated May 28, 2013, 1:07 p.m.) > > > Review request for cloudstack, Devdeep Singh and Prachi Damle. > > > Description > --- > > Patch 2 for https://reviews.apache.org/r/11379/ > Created for files > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java, > server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, > server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java > > > This addresses bug CLOUDSTACK-681. > > > Diffs > - > > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 > server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java e3b7d31 > server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 484b044 > > Diff: https://reviews.apache.org/r/11380/diff/ > > > Testing > --- > > Unittest: For the new APIs and Service, added unit tests under : > plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java > Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm > is deployed on the dedicated host. > Rat Build Successful. > > > Thanks, > > Saksham Srivastava > >
Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11380/ --- (Updated May 30, 2013, 7:23 a.m.) Review request for cloudstack, Devdeep Singh and Prachi Damle. Changes --- Resolving merge conflicts. Description --- Patch 2 for https://reviews.apache.org/r/11379/ Created for files server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java, server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java This addresses bug CLOUDSTACK-681. Diffs (updated) - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 79375f9 server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java e3b7d31 server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 24c5d3d Diff: https://reviews.apache.org/r/11380/diff/ Testing --- Unittest: For the new APIs and Service, added unit tests under : plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava
Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11380/#review21185 --- Commit 965c7b9c35fc5680b2f35a8c8fed35c1232a643b in branch refs/heads/master from Prachi Damle [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=965c7b9 ] Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host Patch 2 for https://reviews.apache.org/r/11379/ Created for files server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java, server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java - ASF Subversion and Git Services On May 30, 2013, 7:23 a.m., Saksham Srivastava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11380/ > --- > > (Updated May 30, 2013, 7:23 a.m.) > > > Review request for cloudstack, Devdeep Singh and Prachi Damle. > > > Description > --- > > Patch 2 for https://reviews.apache.org/r/11379/ > Created for files > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java, > server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, > server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java > > > This addresses bug CLOUDSTACK-681. > > > Diffs > - > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 79375f9 > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 > server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java e3b7d31 > server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 24c5d3d > > Diff: https://reviews.apache.org/r/11380/diff/ > > > Testing > --- > > Unittest: For the new APIs and Service, added unit tests under : > plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java > Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm > is deployed on the dedicated host. > Rat Build Successful. > > > Thanks, > > Saksham Srivastava > >
Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11380/#review21190 --- Commit 17267794adb2bab923fb20515a7b943780d61921 in branch refs/heads/master from Prachi Damle [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1726779 ] CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host. This feature allows a user to deploy VMs only in the resources dedicated to his account or domain. 1. Resources(Zones, Pods, Clusters or hosts) can be dedicated to an account or domain. Implemented 12 new APIs to dedicate/list/release resources: - dedicateZone, listDedicatedZones, releaseDedicatedZone for a Zone. - dedicatePod, listDedicatedPods, releaseDedicatedPod for a Pod. - dedicateCluster, listDedicatedClusters, releaseDedicatedCluster for a Cluster - dedicateHost, listDedicatedHosts, releaseDedicatedHost for a Host. 2. Once a resource(eg. pod) is dedicated to an account, other resources(eg. clusters/hosts) inside that cannot be further dedicated. 3. Once a resource is dedicated to a domain, other resources inside that can be further dedicated to its sub-domain or account. 4. If any resource (eg.cluster) is dedicated to a account/domain, then resources(eg. Pod) above that cannot be dedicated to different accounts/domain (not belonging to the same domain) 5. To use Explicit dedication, user needs to create an Affinity Group of type 'ExplicitDedication' 6. A VM can be deployed with the above affinity group parameter as an input. 7. A new ExplicitDedicationProcessor has been added which will process the affinity group of type 'Explicit Dedication' for a deployment of a VM that demands dedicated resources. This processor implements the AffinityGroupProcessor adapter. This processor will update the avoid list. 8. A VM requesting dedication will be deployed on dedicatd resources if available with the user account. 9. A VM requesting dedication can also be deployed on the dedicated resources available with the parent domains iff no dedicated resources are available with the current user's account or domain. 10. A VM (without dedication) can be deployed on shared host but not on dedicated hosts. 11. To modify the dedication, the resource has to be released first. 12. Existing Private zone functionality has been redirected to Explicit dedication of zones. 13. Updated the db upgrade schema script. A new table "dedicated_resources" has been added. 14. Added the right permissions in commands.properties 15. Unit tests: For the new APIs and Service, added unit tests under : plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java 16. Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is deployed on the dedicated host. - ASF Subversion and Git Services On May 30, 2013, 7:23 a.m., Saksham Srivastava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11380/ > --- > > (Updated May 30, 2013, 7:23 a.m.) > > > Review request for cloudstack, Devdeep Singh and Prachi Damle. > > > Description > --- > > Patch 2 for https://reviews.apache.org/r/11379/ > Created for files > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java, > server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, > server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java > > > This addresses bug CLOUDSTACK-681. > > > Diffs > - > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 79375f9 > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 > server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java e3b7d31 > server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 24c5d3d > > Diff: https://reviews.apache.org/r/11380/diff/ > > > Testing > --- > > Unittest: For the new APIs and Service, added unit tests under : > plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java > Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm > is deployed on the dedicated host. > Rat Build Successful. > > > Thanks, > > Saksham Srivastava > >
Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11380/#review21212 --- Commit 8ece25c1f2bd6d0126c2a22b42e1c4da65fc2856 in branch refs/heads/master from Jessica Wang [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8ece25c ] CLOUDSTACK-681: deployment planner - create compute offering dialog - deployment planner dropdown - add blank option and make it as default option. Not pass anything to API call when blank option is selected. - ASF Subversion and Git Services On May 30, 2013, 7:23 a.m., Saksham Srivastava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11380/ > --- > > (Updated May 30, 2013, 7:23 a.m.) > > > Review request for cloudstack, Devdeep Singh and Prachi Damle. > > > Description > --- > > Patch 2 for https://reviews.apache.org/r/11379/ > Created for files > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java, > server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, > server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java > > > This addresses bug CLOUDSTACK-681. > > > Diffs > - > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 79375f9 > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 > server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java e3b7d31 > server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 24c5d3d > > Diff: https://reviews.apache.org/r/11380/diff/ > > > Testing > --- > > Unittest: For the new APIs and Service, added unit tests under : > plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java > Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm > is deployed on the dedicated host. > Rat Build Successful. > > > Thanks, > > Saksham Srivastava > >
