Re: Review Request: Storage motion changes for xenserver
On Sat, Apr 20, 2013 at 10:17:46AM +, Nitin Mehta wrote: > Best would be sending a mail to the PPMC @ > cloudstack-priv...@incubator.apache.org > Also one shouldn't feel shy in self nomination oneself as well :). > > More reading @ > http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201302.mb > ox/%3ccd52433a.3%25nitin.me...@citrix.com%3E > > On 20/04/13 8:55 AM, "Abhinandan Prateek" wrote: > > >Yes, I think you should propose Devdeep and few others to be a committer. > >The others I will discuss with Alex when he is in Hyd on Monday. Nitin's suggestion is the right one. Talking off-line with Alex or others will only initiate the same process of discussion on private@cs.a.o. You can feel free to just do that yourself. -chip
Re: Review Request: Storage motion changes for xenserver
Best would be sending a mail to the PPMC @ cloudstack-priv...@incubator.apache.org Also one shouldn't feel shy in self nomination oneself as well :). More reading @ http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201302.mb ox/%3ccd52433a.3%25nitin.me...@citrix.com%3E On 20/04/13 8:55 AM, "Abhinandan Prateek" wrote: >Yes, I think you should propose Devdeep and few others to be a committer. >The others I will discuss with Alex when he is in Hyd on Monday. > >On 19/04/13 10:40 PM, "Edison Su" wrote: > >>Sorry, I don't realize you are not a committer yet. BTW, let me nominate >>you as a commiter. >> >>> -Original Message- >>> From: Devdeep Singh [mailto:devdeep.si...@citrix.com] >>> Sent: Thursday, April 18, 2013 2:44 AM >>> To: Edison Su; Anthony Xu; Abhinandan Prateek (aprat...@apache.org); >>> Alex Huang; dev@cloudstack.apache.org >>> Subject: RE: Review Request: Storage motion changes for xenserver >>> >>> Hi, >>> >>> The feature was given a ³Ship It² after the review comments were >>>addressed. >>> Can someone apply and commit these changes to the master branch. I have >>> verified that the patch applies cleanly to the latest master. >>> >>> Regards, >>> Devdeep >>> >>> From: edison su [mailto:nore...@reviews.apache.org] On Behalf Of edison >>> su >>> Sent: Wednesday, April 17, 2013 11:53 AM >>> To: Anthony Xu; Edison Su; Abhinandan Prateek; Alex Huang >>> Cc: cloudstack; Devdeep Singh >>> Subject: Re: Review Request: Storage motion changes for xenserver >>> >>> This is an automatically generated e-mail. To reply, visit: >>> https://reviews.apache.org/r/10196/ >>> >>> >>> >>> Ship it! >>> >>> Ship It! >>> >>> >>> - edison >>> >>> >>> On April 15th, 2013, 7:24 a.m., Devdeep Singh wrote: >>> Review request for cloudstack, Abhinandan Prateek, edison su, Alex >>>Huang, >>> and anthony xu. >>> By Devdeep Singh. >>> >>> Updated April 15, 2013, 7:24 a.m. >>> >>> Description >>> >>> Storage motion for Xenserver. FS for the feature >>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enabling+Storag >>> e+XenMotion+for+XenServer >>> >>> 1. Implemented Api findStoragePoolsForMigration. Added a new >>>response >>> objects to list storage pools available for migration. >>> >>> 2. Updated migrateVolume api for allowing migrating volumes of >>>running >>> vms. These changes are integrated into the latest storage refactoring >>> changes. >>> >>> 3. Added the implementation for findHostsForMigration api. It lists >>>the >>> hosts to which an instance can be migrated, including hosts from within >>>and >>> across clusters to which an instance may be migrated with storage >>>motion. >>> The work of migrating a volume of a running vm is also done in >>>copyAsync. >>> >>> 4. Updated the listHosts api for backward compatibility. >>> >>> 5. Added the implementation for migrateVirtualMachineWithVolume >>>api. It >>> migrates an instance with its volumes within a cluster and also across >>>clusters. >>> Also introduced a new XenServerStorageMotionStrategy for migrating >>> volumes of a vm. When a vm is being migrated with its volumes, the vm >>>is >>> put in migrating state and a request is send to the volume manager to >>> migrate the vm and its volumes. Volume manager calls into the volume >>> service which forwards the request to data motion service after moving >>>all >>> the volumes to migrating state. Data motion service enumerates the >>> strategies and the request reaches the XenServerStorageMotionStrategy. >>>It >>> calls in to the resource to complete the operation. >>> >>> 6. Resolved an issue where storage xenmotion of 2nd VM created from >>>the >>> same template to a host was failing with duplicate_vm exception. Made >>> changes to remove the mac_seed key value pair from other_config when >>> vms are created. This is was storage motion to fail. >>> >>> 7. Updated the db upgrade schema script. >>> >>> 8. Added the right permissions in commands.properties >>> >>> 9. Marvin tests for
Re: Review Request: Storage motion changes for xenserver
Yes, I think you should propose Devdeep and few others to be a committer. The others I will discuss with Alex when he is in Hyd on Monday. On 19/04/13 10:40 PM, "Edison Su" wrote: >Sorry, I don't realize you are not a committer yet. BTW, let me nominate >you as a commiter. > >> -Original Message- >> From: Devdeep Singh [mailto:devdeep.si...@citrix.com] >> Sent: Thursday, April 18, 2013 2:44 AM >> To: Edison Su; Anthony Xu; Abhinandan Prateek (aprat...@apache.org); >> Alex Huang; dev@cloudstack.apache.org >> Subject: RE: Review Request: Storage motion changes for xenserver >> >> Hi, >> >> The feature was given a ³Ship It² after the review comments were >>addressed. >> Can someone apply and commit these changes to the master branch. I have >> verified that the patch applies cleanly to the latest master. >> >> Regards, >> Devdeep >> >> From: edison su [mailto:nore...@reviews.apache.org] On Behalf Of edison >> su >> Sent: Wednesday, April 17, 2013 11:53 AM >> To: Anthony Xu; Edison Su; Abhinandan Prateek; Alex Huang >> Cc: cloudstack; Devdeep Singh >> Subject: Re: Review Request: Storage motion changes for xenserver >> >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/10196/ >> >> >> >> Ship it! >> >> Ship It! >> >> >> - edison >> >> >> On April 15th, 2013, 7:24 a.m., Devdeep Singh wrote: >> Review request for cloudstack, Abhinandan Prateek, edison su, Alex >>Huang, >> and anthony xu. >> By Devdeep Singh. >> >> Updated April 15, 2013, 7:24 a.m. >> >> Description >> >> Storage motion for Xenserver. FS for the feature >> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enabling+Storag >> e+XenMotion+for+XenServer >> >> 1. Implemented Api findStoragePoolsForMigration. Added a new >>response >> objects to list storage pools available for migration. >> >> 2. Updated migrateVolume api for allowing migrating volumes of >>running >> vms. These changes are integrated into the latest storage refactoring >> changes. >> >> 3. Added the implementation for findHostsForMigration api. It lists >>the >> hosts to which an instance can be migrated, including hosts from within >>and >> across clusters to which an instance may be migrated with storage >>motion. >> The work of migrating a volume of a running vm is also done in >>copyAsync. >> >> 4. Updated the listHosts api for backward compatibility. >> >> 5. Added the implementation for migrateVirtualMachineWithVolume >>api. It >> migrates an instance with its volumes within a cluster and also across >>clusters. >> Also introduced a new XenServerStorageMotionStrategy for migrating >> volumes of a vm. When a vm is being migrated with its volumes, the vm is >> put in migrating state and a request is send to the volume manager to >> migrate the vm and its volumes. Volume manager calls into the volume >> service which forwards the request to data motion service after moving >>all >> the volumes to migrating state. Data motion service enumerates the >> strategies and the request reaches the XenServerStorageMotionStrategy. >>It >> calls in to the resource to complete the operation. >> >> 6. Resolved an issue where storage xenmotion of 2nd VM created from >>the >> same template to a host was failing with duplicate_vm exception. Made >> changes to remove the mac_seed key value pair from other_config when >> vms are created. This is was storage motion to fail. >> >> 7. Updated the db upgrade schema script. >> >> 8. Added the right permissions in commands.properties >> >> 9. Marvin tests for testing storage motion. Following scenarios are >>tested. >> >> 9.1. A virtual machine is migrated to another host. Its volumes are >>also >> migrated to another storage pool. >> >> 9.2. Just the volumes of a vm are migrated to another storage pool >>while >> the vm continues to run on the same host. >> >> 10. Unit tests for testing migration of a vm with its volumes. >> >> >> Testing >> >> 1. Unit tests for testing vm migration with volume. They test when a vm >>is >> migrated within a cluster or across cluster. Also added negative tests >>for the >> scenrios. >> >> 2. Marvin tests to do functional testing. Including tests to varify vm
RE: Review Request: Storage motion changes for xenserver
Sorry, I don't realize you are not a committer yet. BTW, let me nominate you as a commiter. > -Original Message- > From: Devdeep Singh [mailto:devdeep.si...@citrix.com] > Sent: Thursday, April 18, 2013 2:44 AM > To: Edison Su; Anthony Xu; Abhinandan Prateek (aprat...@apache.org); > Alex Huang; dev@cloudstack.apache.org > Subject: RE: Review Request: Storage motion changes for xenserver > > Hi, > > The feature was given a “Ship It” after the review comments were addressed. > Can someone apply and commit these changes to the master branch. I have > verified that the patch applies cleanly to the latest master. > > Regards, > Devdeep > > From: edison su [mailto:nore...@reviews.apache.org] On Behalf Of edison > su > Sent: Wednesday, April 17, 2013 11:53 AM > To: Anthony Xu; Edison Su; Abhinandan Prateek; Alex Huang > Cc: cloudstack; Devdeep Singh > Subject: Re: Review Request: Storage motion changes for xenserver > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10196/ > > > > Ship it! > > Ship It! > > > - edison > > > On April 15th, 2013, 7:24 a.m., Devdeep Singh wrote: > Review request for cloudstack, Abhinandan Prateek, edison su, Alex Huang, > and anthony xu. > By Devdeep Singh. > > Updated April 15, 2013, 7:24 a.m. > > Description > > Storage motion for Xenserver. FS for the feature > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enabling+Storag > e+XenMotion+for+XenServer > > 1. Implemented Api findStoragePoolsForMigration. Added a new response > objects to list storage pools available for migration. > > 2. Updated migrateVolume api for allowing migrating volumes of running > vms. These changes are integrated into the latest storage refactoring > changes. > > 3. Added the implementation for findHostsForMigration api. It lists the > hosts to which an instance can be migrated, including hosts from within and > across clusters to which an instance may be migrated with storage motion. > The work of migrating a volume of a running vm is also done in copyAsync. > > 4. Updated the listHosts api for backward compatibility. > > 5. Added the implementation for migrateVirtualMachineWithVolume api. It > migrates an instance with its volumes within a cluster and also across > clusters. > Also introduced a new XenServerStorageMotionStrategy for migrating > volumes of a vm. When a vm is being migrated with its volumes, the vm is > put in migrating state and a request is send to the volume manager to > migrate the vm and its volumes. Volume manager calls into the volume > service which forwards the request to data motion service after moving all > the volumes to migrating state. Data motion service enumerates the > strategies and the request reaches the XenServerStorageMotionStrategy. It > calls in to the resource to complete the operation. > > 6. Resolved an issue where storage xenmotion of 2nd VM created from the > same template to a host was failing with duplicate_vm exception. Made > changes to remove the mac_seed key value pair from other_config when > vms are created. This is was storage motion to fail. > > 7. Updated the db upgrade schema script. > > 8. Added the right permissions in commands.properties > > 9. Marvin tests for testing storage motion. Following scenarios are > tested. > > 9.1. A virtual machine is migrated to another host. Its volumes are also > migrated to another storage pool. > > 9.2. Just the volumes of a vm are migrated to another storage pool while > the vm continues to run on the same host. > > 10. Unit tests for testing migration of a vm with its volumes. > > > Testing > > 1. Unit tests for testing vm migration with volume. They test when a vm is > migrated within a cluster or across cluster. Also added negative tests for the > scenrios. > > 2. Marvin tests to do functional testing. Including tests to varify vm > migration > with volume across cluster. > > 3. Marvin test for volume migration to another storage pool in the cluster > while the vm continues to run on the same host. > > 4. Also did additional manual testing for the following scenarios: > > 4.1 VM migration with volumes within and across cluster. > > 4.2 Tested both the scenarios when 'migrateto' optional parameter is passed > to the migrate vm with volume api. When it isn't passed, cloudstack picks up > a storage pool for migration. When it is passed, the volume is migrated to the > pool passed in the parameter. > > 4.3 Tested that storage tags are honored when a vm is migrated with its > volumes. >
Re: Review Request: Storage motion changes for xenserver
> On April 19, 2013, 6:05 a.m., Abhinandan Prateek wrote: > > Ship It! commit 21ce3befc8ea9e1a6de449a21499a50ff141a183 Author: Devdeep Singh Date: Mon Apr 15 11:42:18 2013 +0530 - Abhinandan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10196/#review19441 --- On April 15, 2013, 7:24 a.m., Devdeep Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10196/ > --- > > (Updated April 15, 2013, 7:24 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, edison su, Alex Huang, and > anthony xu. > > > Description > --- > > Storage motion for Xenserver. FS for the feature > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enabling+Storage+XenMotion+for+XenServer > 1. Implemented Api findStoragePoolsForMigration. Added a new response > objects to list storage pools available for migration. > 2. Updated migrateVolume api for allowing migrating volumes of running > vms. These changes are integrated into the latest storage refactoring changes. > 3. Added the implementation for findHostsForMigration api. It lists the > hosts to which an instance can be migrated, including hosts from within and > across clusters to which an instance may be migrated with storage motion. The > work of migrating a volume of a running vm is also done in copyAsync. > 4. Updated the listHosts api for backward compatibility. > 5. Added the implementation for migrateVirtualMachineWithVolume api. It > migrates an instance with its volumes within a cluster and also across > clusters. Also introduced a new XenServerStorageMotionStrategy for migrating > volumes of a vm. When a vm is being migrated with its volumes, the vm is put > in migrating state and a request is send to the volume manager to migrate the > vm and its volumes. Volume manager calls into the volume service which > forwards the request to data motion service after moving all the volumes to > migrating state. Data motion service enumerates the strategies and the > request reaches the XenServerStorageMotionStrategy. It calls in to the > resource to complete the operation. > 6. Resolved an issue where storage xenmotion of 2nd VM created from the > same template to a host was failing with duplicate_vm exception. Made changes > to remove the mac_seed key value pair from other_config when vms are created. > This is was storage motion to fail. > 7. Updated the db upgrade schema script. > 8. Added the right permissions in commands.properties > 9. Marvin tests for testing storage motion. Following scenarios are > tested. > 9.1. A virtual machine is migrated to another host. Its volumes are also > migrated to another storage pool. > 9.2. Just the volumes of a vm are migrated to another storage pool while > the vm continues to run on the same host. > 10. Unit tests for testing migration of a vm with its volumes. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-659. > > > Diffs > - > > api/src/com/cloud/agent/api/MigrateWithStorageAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageCommand.java PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageCompleteAnswer.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageCompleteCommand.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageReceiveAnswer.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageReceiveCommand.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageSendAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageSendCommand.java PRE-CREATION > api/src/com/cloud/agent/api/storage/MigrateVolumeAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/storage/MigrateVolumeCommand.java PRE-CREATION > api/src/com/cloud/hypervisor/HypervisorCapabilities.java aff81b0 > api/src/com/cloud/server/ManagementService.java 6e6dbc3 > api/src/com/cloud/vm/UserVmService.java d963b74 > api/src/org/apache/cloudstack/api/ApiConstants.java b08e992 > api/src/org/apache/cloudstack/api/ResponseGenerator.java c0dd57e > > api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java > 29844c3 > > api/src/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/user/volume/MigrateVolumeCmd.java > 287241a > api/src/org/apach
Re: Review Request: Storage motion changes for xenserver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10196/#review19441 --- Ship it! Ship It! - Abhinandan Prateek On April 15, 2013, 7:24 a.m., Devdeep Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10196/ > --- > > (Updated April 15, 2013, 7:24 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, edison su, Alex Huang, and > anthony xu. > > > Description > --- > > Storage motion for Xenserver. FS for the feature > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enabling+Storage+XenMotion+for+XenServer > 1. Implemented Api findStoragePoolsForMigration. Added a new response > objects to list storage pools available for migration. > 2. Updated migrateVolume api for allowing migrating volumes of running > vms. These changes are integrated into the latest storage refactoring changes. > 3. Added the implementation for findHostsForMigration api. It lists the > hosts to which an instance can be migrated, including hosts from within and > across clusters to which an instance may be migrated with storage motion. The > work of migrating a volume of a running vm is also done in copyAsync. > 4. Updated the listHosts api for backward compatibility. > 5. Added the implementation for migrateVirtualMachineWithVolume api. It > migrates an instance with its volumes within a cluster and also across > clusters. Also introduced a new XenServerStorageMotionStrategy for migrating > volumes of a vm. When a vm is being migrated with its volumes, the vm is put > in migrating state and a request is send to the volume manager to migrate the > vm and its volumes. Volume manager calls into the volume service which > forwards the request to data motion service after moving all the volumes to > migrating state. Data motion service enumerates the strategies and the > request reaches the XenServerStorageMotionStrategy. It calls in to the > resource to complete the operation. > 6. Resolved an issue where storage xenmotion of 2nd VM created from the > same template to a host was failing with duplicate_vm exception. Made changes > to remove the mac_seed key value pair from other_config when vms are created. > This is was storage motion to fail. > 7. Updated the db upgrade schema script. > 8. Added the right permissions in commands.properties > 9. Marvin tests for testing storage motion. Following scenarios are > tested. > 9.1. A virtual machine is migrated to another host. Its volumes are also > migrated to another storage pool. > 9.2. Just the volumes of a vm are migrated to another storage pool while > the vm continues to run on the same host. > 10. Unit tests for testing migration of a vm with its volumes. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-659. > > > Diffs > - > > api/src/com/cloud/agent/api/MigrateWithStorageAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageCommand.java PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageCompleteAnswer.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageCompleteCommand.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageReceiveAnswer.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageReceiveCommand.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageSendAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageSendCommand.java PRE-CREATION > api/src/com/cloud/agent/api/storage/MigrateVolumeAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/storage/MigrateVolumeCommand.java PRE-CREATION > api/src/com/cloud/hypervisor/HypervisorCapabilities.java aff81b0 > api/src/com/cloud/server/ManagementService.java 6e6dbc3 > api/src/com/cloud/vm/UserVmService.java d963b74 > api/src/org/apache/cloudstack/api/ApiConstants.java b08e992 > api/src/org/apache/cloudstack/api/ResponseGenerator.java c0dd57e > > api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java > 29844c3 > > api/src/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/user/volume/MigrateVolumeCmd.java > 287241a > api/src/org/apache/cloudstack/api/response/HostForMigrationResponse.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/HostResponse.java f5aa8f9 > > api
RE: Review Request: Storage motion changes for xenserver
Hi, The feature was given a “Ship It” after the review comments were addressed. Can someone apply and commit these changes to the master branch. I have verified that the patch applies cleanly to the latest master. Regards, Devdeep From: edison su [mailto:nore...@reviews.apache.org] On Behalf Of edison su Sent: Wednesday, April 17, 2013 11:53 AM To: Anthony Xu; Edison Su; Abhinandan Prateek; Alex Huang Cc: cloudstack; Devdeep Singh Subject: Re: Review Request: Storage motion changes for xenserver This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10196/ Ship it! Ship It! - edison On April 15th, 2013, 7:24 a.m., Devdeep Singh wrote: Review request for cloudstack, Abhinandan Prateek, edison su, Alex Huang, and anthony xu. By Devdeep Singh. Updated April 15, 2013, 7:24 a.m. Description Storage motion for Xenserver. FS for the feature https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enabling+Storage+XenMotion+for+XenServer 1. Implemented Api findStoragePoolsForMigration. Added a new response objects to list storage pools available for migration. 2. Updated migrateVolume api for allowing migrating volumes of running vms. These changes are integrated into the latest storage refactoring changes. 3. Added the implementation for findHostsForMigration api. It lists the hosts to which an instance can be migrated, including hosts from within and across clusters to which an instance may be migrated with storage motion. The work of migrating a volume of a running vm is also done in copyAsync. 4. Updated the listHosts api for backward compatibility. 5. Added the implementation for migrateVirtualMachineWithVolume api. It migrates an instance with its volumes within a cluster and also across clusters. Also introduced a new XenServerStorageMotionStrategy for migrating volumes of a vm. When a vm is being migrated with its volumes, the vm is put in migrating state and a request is send to the volume manager to migrate the vm and its volumes. Volume manager calls into the volume service which forwards the request to data motion service after moving all the volumes to migrating state. Data motion service enumerates the strategies and the request reaches the XenServerStorageMotionStrategy. It calls in to the resource to complete the operation. 6. Resolved an issue where storage xenmotion of 2nd VM created from the same template to a host was failing with duplicate_vm exception. Made changes to remove the mac_seed key value pair from other_config when vms are created. This is was storage motion to fail. 7. Updated the db upgrade schema script. 8. Added the right permissions in commands.properties 9. Marvin tests for testing storage motion. Following scenarios are tested. 9.1. A virtual machine is migrated to another host. Its volumes are also migrated to another storage pool. 9.2. Just the volumes of a vm are migrated to another storage pool while the vm continues to run on the same host. 10. Unit tests for testing migration of a vm with its volumes. Testing 1. Unit tests for testing vm migration with volume. They test when a vm is migrated within a cluster or across cluster. Also added negative tests for the scenrios. 2. Marvin tests to do functional testing. Including tests to varify vm migration with volume across cluster. 3. Marvin test for volume migration to another storage pool in the cluster while the vm continues to run on the same host. 4. Also did additional manual testing for the following scenarios: 4.1 VM migration with volumes within and across cluster. 4.2 Tested both the scenarios when 'migrateto' optional parameter is passed to the migrate vm with volume api. When it isn't passed, cloudstack picks up a storage pool for migration. When it is passed, the volume is migrated to the pool passed in the parameter. 4.3 Tested that storage tags are honored when a vm is migrated with its volumes. 4.4 Tested volume migration when the vm stays on the same host. 4.5 For volume migration verified that storage tags are honored. Other tests done to verify patch: 1. Verified that there are no rat failures. 2. Applied the patch to verify it applies cleanly. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-659 Diffs * api/src/com/cloud/agent/api/MigrateWithStorageAnswer.java (PRE-CREATION) * api/src/com/cloud/agent/api/MigrateWithStorageCommand.java (PRE-CREATION) * api/src/com/cloud/agent/api/MigrateWithStorageCompleteAnswer.java (PRE-CREATION) * api/src/com/cloud/agent/api/MigrateWithStorageCompleteCommand.java (PRE-CREATION) * api/src/com/cloud/agent/api/MigrateWithStorageReceiveAnswer.java (PRE-CREATION) * api/src/com/cloud/agent/api/MigrateWithStorageReceiveCommand.java (PRE-CREATION) * api/src/com/cloud/agent/api/MigrateWithStorageSendAnswer.java (PRE-CREATION) * api/src/com/
Re: Review Request: Storage motion changes for xenserver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10196/#review19306 --- Ship it! Ship It! - edison su On April 15, 2013, 7:24 a.m., Devdeep Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10196/ > --- > > (Updated April 15, 2013, 7:24 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, edison su, Alex Huang, and > anthony xu. > > > Description > --- > > Storage motion for Xenserver. FS for the feature > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enabling+Storage+XenMotion+for+XenServer > 1. Implemented Api findStoragePoolsForMigration. Added a new response > objects to list storage pools available for migration. > 2. Updated migrateVolume api for allowing migrating volumes of running > vms. These changes are integrated into the latest storage refactoring changes. > 3. Added the implementation for findHostsForMigration api. It lists the > hosts to which an instance can be migrated, including hosts from within and > across clusters to which an instance may be migrated with storage motion. The > work of migrating a volume of a running vm is also done in copyAsync. > 4. Updated the listHosts api for backward compatibility. > 5. Added the implementation for migrateVirtualMachineWithVolume api. It > migrates an instance with its volumes within a cluster and also across > clusters. Also introduced a new XenServerStorageMotionStrategy for migrating > volumes of a vm. When a vm is being migrated with its volumes, the vm is put > in migrating state and a request is send to the volume manager to migrate the > vm and its volumes. Volume manager calls into the volume service which > forwards the request to data motion service after moving all the volumes to > migrating state. Data motion service enumerates the strategies and the > request reaches the XenServerStorageMotionStrategy. It calls in to the > resource to complete the operation. > 6. Resolved an issue where storage xenmotion of 2nd VM created from the > same template to a host was failing with duplicate_vm exception. Made changes > to remove the mac_seed key value pair from other_config when vms are created. > This is was storage motion to fail. > 7. Updated the db upgrade schema script. > 8. Added the right permissions in commands.properties > 9. Marvin tests for testing storage motion. Following scenarios are > tested. > 9.1. A virtual machine is migrated to another host. Its volumes are also > migrated to another storage pool. > 9.2. Just the volumes of a vm are migrated to another storage pool while > the vm continues to run on the same host. > 10. Unit tests for testing migration of a vm with its volumes. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-659. > > > Diffs > - > > api/src/com/cloud/agent/api/MigrateWithStorageAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageCommand.java PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageCompleteAnswer.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageCompleteCommand.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageReceiveAnswer.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageReceiveCommand.java > PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageSendAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/MigrateWithStorageSendCommand.java PRE-CREATION > api/src/com/cloud/agent/api/storage/MigrateVolumeAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/storage/MigrateVolumeCommand.java PRE-CREATION > api/src/com/cloud/hypervisor/HypervisorCapabilities.java aff81b0 > api/src/com/cloud/server/ManagementService.java 6e6dbc3 > api/src/com/cloud/vm/UserVmService.java d963b74 > api/src/org/apache/cloudstack/api/ApiConstants.java b08e992 > api/src/org/apache/cloudstack/api/ResponseGenerator.java c0dd57e > > api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java > 29844c3 > > api/src/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/user/volume/MigrateVolumeCmd.java > 287241a > api/src/org/apache/cloudstack/api/response/HostForMigrationResponse.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/HostResponse.java f5aa8f9 > > api/src/org/
Re: Review Request: Storage motion changes for xenserver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10196/ --- (Updated April 15, 2013, 7:24 a.m.) Review request for cloudstack, Abhinandan Prateek, edison su, Alex Huang, and anthony xu. Changes --- Updated the patch after merging with the latest master. Description --- Storage motion for Xenserver. FS for the feature https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enabling+Storage+XenMotion+for+XenServer 1. Implemented Api findStoragePoolsForMigration. Added a new response objects to list storage pools available for migration. 2. Updated migrateVolume api for allowing migrating volumes of running vms. These changes are integrated into the latest storage refactoring changes. 3. Added the implementation for findHostsForMigration api. It lists the hosts to which an instance can be migrated, including hosts from within and across clusters to which an instance may be migrated with storage motion. The work of migrating a volume of a running vm is also done in copyAsync. 4. Updated the listHosts api for backward compatibility. 5. Added the implementation for migrateVirtualMachineWithVolume api. It migrates an instance with its volumes within a cluster and also across clusters. Also introduced a new XenServerStorageMotionStrategy for migrating volumes of a vm. When a vm is being migrated with its volumes, the vm is put in migrating state and a request is send to the volume manager to migrate the vm and its volumes. Volume manager calls into the volume service which forwards the request to data motion service after moving all the volumes to migrating state. Data motion service enumerates the strategies and the request reaches the XenServerStorageMotionStrategy. It calls in to the resource to complete the operation. 6. Resolved an issue where storage xenmotion of 2nd VM created from the same template to a host was failing with duplicate_vm exception. Made changes to remove the mac_seed key value pair from other_config when vms are created. This is was storage motion to fail. 7. Updated the db upgrade schema script. 8. Added the right permissions in commands.properties 9. Marvin tests for testing storage motion. Following scenarios are tested. 9.1. A virtual machine is migrated to another host. Its volumes are also migrated to another storage pool. 9.2. Just the volumes of a vm are migrated to another storage pool while the vm continues to run on the same host. 10. Unit tests for testing migration of a vm with its volumes. This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-659. Diffs (updated) - api/src/com/cloud/agent/api/MigrateWithStorageAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageCommand.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageCompleteAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageCompleteCommand.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageReceiveAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageReceiveCommand.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageSendAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageSendCommand.java PRE-CREATION api/src/com/cloud/agent/api/storage/MigrateVolumeAnswer.java PRE-CREATION api/src/com/cloud/agent/api/storage/MigrateVolumeCommand.java PRE-CREATION api/src/com/cloud/hypervisor/HypervisorCapabilities.java aff81b0 api/src/com/cloud/server/ManagementService.java 6e6dbc3 api/src/com/cloud/vm/UserVmService.java d963b74 api/src/org/apache/cloudstack/api/ApiConstants.java b08e992 api/src/org/apache/cloudstack/api/ResponseGenerator.java c0dd57e api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 29844c3 api/src/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/volume/MigrateVolumeCmd.java 287241a api/src/org/apache/cloudstack/api/response/HostForMigrationResponse.java PRE-CREATION api/src/org/apache/cloudstack/api/response/HostResponse.java f5aa8f9 api/src/org/apache/cloudstack/api/response/StoragePoolForMigrationResponse.java PRE-CREATION api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java 0b16226 client/tomcatconf/applicationContext.xml.in 15cd6fe client/tomcatconf/commands.properties.in 798d226 core/src/com/cloud/hypervisor/HypervisorCapabilitiesVO.java fafc0a3 engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataSt
Re: Review Request: Storage motion changes for xenserver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10196/ --- (Updated April 11, 2013, 11:02 a.m.) Review request for cloudstack, Abhinandan Prateek, edison su, Alex Huang, and anthony xu. Changes --- Updated the patch to incorporate the review comments. 1. Created new response objects for listing hosts and storage pools available for migration. 2. Renamed the listHostsForMigration api and listStoragePoolsForMigration api to findHostsForMigration and findStoragePoolsForMigration respectively. 3. Introduced a new XenServerStorageMotionStrategy for migrating volumes of a vm. When a vm is being migrated with its volumes, the vm is put in migrating state and a request is send to the volume manager to migrate the vm and its volumes. Volume manager calls into the volume service which forwards the request to data motion service after moving all the volumes to migrating state. Data motion service enumerates the strategies and the request reaches the XenServerStorageMotionStrategy. It calls in to the resource to complete the operation. 4. Removed migrateAsync from data motion service. The work of migrating a volume of a running vm is also done in copyAsync. 5. Fixed the marvin tests to work with the updated/renamed apis. Description (updated) --- Storage motion for Xenserver. FS for the feature https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enabling+Storage+XenMotion+for+XenServer 1. Implemented Api findStoragePoolsForMigration. Added a new response objects to list storage pools available for migration. 2. Updated migrateVolume api for allowing migrating volumes of running vms. These changes are integrated into the latest storage refactoring changes. 3. Added the implementation for findHostsForMigration api. It lists the hosts to which an instance can be migrated, including hosts from within and across clusters to which an instance may be migrated with storage motion. The work of migrating a volume of a running vm is also done in copyAsync. 4. Updated the listHosts api for backward compatibility. 5. Added the implementation for migrateVirtualMachineWithVolume api. It migrates an instance with its volumes within a cluster and also across clusters. Also introduced a new XenServerStorageMotionStrategy for migrating volumes of a vm. When a vm is being migrated with its volumes, the vm is put in migrating state and a request is send to the volume manager to migrate the vm and its volumes. Volume manager calls into the volume service which forwards the request to data motion service after moving all the volumes to migrating state. Data motion service enumerates the strategies and the request reaches the XenServerStorageMotionStrategy. It calls in to the resource to complete the operation. 6. Resolved an issue where storage xenmotion of 2nd VM created from the same template to a host was failing with duplicate_vm exception. Made changes to remove the mac_seed key value pair from other_config when vms are created. This is was storage motion to fail. 7. Updated the db upgrade schema script. 8. Added the right permissions in commands.properties 9. Marvin tests for testing storage motion. Following scenarios are tested. 9.1. A virtual machine is migrated to another host. Its volumes are also migrated to another storage pool. 9.2. Just the volumes of a vm are migrated to another storage pool while the vm continues to run on the same host. 10. Unit tests for testing migration of a vm with its volumes. This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-659. Diffs (updated) - api/src/com/cloud/agent/api/MigrateWithStorageAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageCommand.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageCompleteAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageCompleteCommand.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageReceiveAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageReceiveCommand.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageSendAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageSendCommand.java PRE-CREATION api/src/com/cloud/agent/api/storage/MigrateVolumeAnswer.java PRE-CREATION api/src/com/cloud/agent/api/storage/MigrateVolumeCommand.java PRE-CREATION api/src/com/cloud/hypervisor/HypervisorCapabilities.java aff81b0 api/src/com/cloud/server/ManagementService.java 1e6ca8d api/src/com/cloud/vm/UserVmService.java 2c33d41 api/src/org/apache/cloudstack/api/ApiConstants.java c518830 api/src/org/apache/cloudstack/api/ResponseGenerator.java d1e1302 api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java PRE-CREAT
Review Request: Storage motion changes for xenserver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10196/ --- Review request for cloudstack, Abhinandan Prateek, edison su, Alex Huang, and anthony xu. Description --- Storage motion for Xenserver. FS for the feature https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enabling+Storage+XenMotion+for+XenServer Changes made. 1. Implemented Api listStoragePoolsForMigration as per the specification. It lists out all the pools available to which a volume me be migrated 2. Updated migrateVolume api for allowing migrating volumes of running vms. These changes are integrated into the latest storage refactoring changes. 3. Added the implementation for listHostsForMigration api. It lists the hosts to which an instance can be migrated, including hosts from other clusters to which an instance may be migrated with storage motion 4. Added the implementation for migrateVirtualMachineWithVolume api. It migrates a VM to another host with its volumes. The host may be in the same cluster or another cluster. 5. Updated the listHosts api for backward compatibility. 6. Resolved an issue where storage xenmotion of 2nd VM created from the same template to a host was failing with duplicate_vm exception. Made changes to remove the mac_seed key value pair from other_config when vms are created. The mac_seed is auto generated by the api if it is not passed in the record. 7. Updated the db schema script. 8. Added the right permissions in commands.properties for the apis. 9. Marvin tests for testing storage motion. Following scenarios are tested. 9.1. A virtual machine is migrated to another host. Its volumes are also migrated to another storage pool. 9.2. Just the volumes of a vm are migrated to another storage pool while the vm continues to run on the same host. 10. Unit tests for testing migration of a vm with its volumes. This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-659. Diffs - api/src/com/cloud/agent/api/MigrateWithStorageAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageCommand.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageCompleteAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageCompleteCommand.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageReceiveAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageReceiveCommand.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageSendAnswer.java PRE-CREATION api/src/com/cloud/agent/api/MigrateWithStorageSendCommand.java PRE-CREATION api/src/com/cloud/agent/api/storage/MigrateVolumeAnswer.java PRE-CREATION api/src/com/cloud/agent/api/storage/MigrateVolumeCommand.java PRE-CREATION api/src/com/cloud/hypervisor/HypervisorCapabilities.java aff81b0 api/src/com/cloud/server/ManagementService.java 1e6ca8d api/src/com/cloud/vm/UserVmService.java 2c33d41 api/src/org/apache/cloudstack/api/ApiConstants.java c518830 api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 29844c3 api/src/org/apache/cloudstack/api/command/admin/host/ListHostsForMigrationCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/admin/storage/ListStoragePoolsForMigrationCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/volume/MigrateVolumeCmd.java 287241a api/src/org/apache/cloudstack/api/response/HostResponse.java f5aa8f9 api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java 66dde36 client/tomcatconf/commands.properties.in 163c2ce core/src/com/cloud/hypervisor/HypervisorCapabilitiesVO.java b525a2d engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java 726ce08 engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/VolumeService.java 102c471 engine/storage/imagemotion/src/org/apache/cloudstack/storage/image/motion/DefaultImageMotionStrategy.java c49a521 engine/storage/integration-test/test/org/apache/cloudstack/storage/test/MockStorageMotionStrategy.java b619ee9 engine/storage/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java 3602bb1 engine/storage/src/org/apache/cloudstack/storage/motion/DataMotionService.java db36f64 engine/storage/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java 343140f engine/storage/src/org/apache/cloudstack/storage/motion/DataMotionStrategy.java ba40c6d engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java ceadb25 engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 32e7d27 plugins/host-allocators/random/s
