Review Request 12702: Fix CopyCmdAnswer returned by backupSnapshotCommand for VMware

2013-07-17 Thread Sateesh Chodapuneedi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12702/
---

Review request for cloudstack, edison su, Fang Wang, and Kelven Yang.


Bugs: CLOUDSTACK-3595


Repository: cloudstack-git


Description
---

Even after successful backup of snapshot to secondary storage, CopyCmdAnswer is 
sent with failure result.
Now sending pass result with full path of backup set to snapshotTO object.


Diffs
-

  
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
 4113803 

Diff: https://reviews.apache.org/r/12702/diff/


Testing
---

Created snapshot from volume in cloudstack deployed over VMware servers.


Thanks,

Sateesh Chodapuneedi



Re: Review Request 12702: Fix CopyCmdAnswer returned by backupSnapshotCommand for VMware

2013-07-17 Thread Sateesh Chodapuneedi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12702/
---

(Updated July 18, 2013, 4:29 a.m.)


Review request for cloudstack, edison su, Fang Wang, and Kelven Yang.


Bugs: CLOUDSTACK-3595


Repository: cloudstack-git


Description
---

Even after successful backup of snapshot to secondary storage, CopyCmdAnswer is 
sent with failure result.
Now sending pass result with full path of backup set to snapshotTO object.


Diffs
-

  
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
 4113803 

Diff: https://reviews.apache.org/r/12702/diff/


Testing
---

Created snapshot from volume in cloudstack deployed over VMware servers.


Thanks,

Sateesh Chodapuneedi



Re: Review Request 12702: Fix CopyCmdAnswer returned by backupSnapshotCommand for VMware

2013-07-17 Thread Venkata Siva Vijayendra Bhamidipati

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12702/#review23354
---

Ship it!


Ship It!

- Venkata Siva Vijayendra Bhamidipati


On July 18, 2013, 4:29 a.m., Sateesh Chodapuneedi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12702/
> ---
> 
> (Updated July 18, 2013, 4:29 a.m.)
> 
> 
> Review request for cloudstack, edison su, Fang Wang, and Kelven Yang.
> 
> 
> Bugs: CLOUDSTACK-3595
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Even after successful backup of snapshot to secondary storage, CopyCmdAnswer 
> is sent with failure result.
> Now sending pass result with full path of backup set to snapshotTO object.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
>  4113803 
> 
> Diff: https://reviews.apache.org/r/12702/diff/
> 
> 
> Testing
> ---
> 
> Created snapshot from volume in cloudstack deployed over VMware servers.
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>



Re: Review Request 12702: Fix CopyCmdAnswer returned by backupSnapshotCommand for VMware

2013-07-18 Thread edison su

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12702/#review23407
---

Ship it!


Ship It!

- edison su


On July 18, 2013, 4:29 a.m., Sateesh Chodapuneedi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12702/
> ---
> 
> (Updated July 18, 2013, 4:29 a.m.)
> 
> 
> Review request for cloudstack, edison su, Fang Wang, and Kelven Yang.
> 
> 
> Bugs: CLOUDSTACK-3595
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Even after successful backup of snapshot to secondary storage, CopyCmdAnswer 
> is sent with failure result.
> Now sending pass result with full path of backup set to snapshotTO object.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
>  4113803 
> 
> Diff: https://reviews.apache.org/r/12702/diff/
> 
> 
> Testing
> ---
> 
> Created snapshot from volume in cloudstack deployed over VMware servers.
> 
> 
> Thanks,
> 
> Sateesh Chodapuneedi
> 
>