Review Request 13320: In case when all the vnets are deleted we are not logging a error message if there are vnets allocated.

2013-08-06 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13320/
---

Review request for cloudstack and Jayapal Reddy.


Bugs: Cloudstack-4105


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-4105
In case when all the vnets are deleted we are not logging a error message if 
there are vnets allocated.
Also not updating the physicalnetwork table in this case.


Diffs
-

  engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java de68e1e 
  engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 3ac2729 
  server/src/com/cloud/network/NetworkServiceImpl.java 304cefa 

Diff: https://reviews.apache.org/r/13320/diff/


Testing
---

Tested on 4.2


Thanks,

bharat kumar



Re: Review Request 13320: In case when all the vnets are deleted we are not logging a error message if there are vnets allocated.

2013-08-06 Thread Jayapal Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13320/#review24775
---

Ship it!


Ship It!

- Jayapal Reddy


On Aug. 6, 2013, 11:18 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13320/
> ---
> 
> (Updated Aug. 6, 2013, 11:18 a.m.)
> 
> 
> Review request for cloudstack and Jayapal Reddy.
> 
> 
> Bugs: Cloudstack-4105
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-4105
> In case when all the vnets are deleted we are not logging a error message if 
> there are vnets allocated.
> Also not updating the physicalnetwork table in this case.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java de68e1e 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 3ac2729 
>   server/src/com/cloud/network/NetworkServiceImpl.java 304cefa 
> 
> Diff: https://reviews.apache.org/r/13320/diff/
> 
> 
> Testing
> ---
> 
> Tested on 4.2
> 
> 
> Thanks,
> 
> bharat kumar
> 
>