Re: Review Request 13324: CLOUDSTACK-4104: VM Creation should fail if a zone is dedicated to a domain and user of the same domain deploys vm without using affinity group Explicit Dedication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13324/#review24792 --- Commit a3ba198e5aba35297201bdf6b1ef127c0a5b01a5 in branch refs/heads/4.2 from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a3ba198 ] CLOUDSTACK-4104: VM Creation should fail if a zone is dedicated to a domain and user of the same domain deploys vm without using affinity group Explicit Dedication. - ASF Subversion and Git Services On Aug. 6, 2013, 12:53 p.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13324/ --- (Updated Aug. 6, 2013, 12:53 p.m.) Review request for cloudstack and Devdeep Singh. Bugs: 4104 Repository: cloudstack-git Description --- To use dedicated resources one must specify the affinity group explicit dedication. If the affinity groups is not specified dedicated resources should not accessible. Currently there are checks for pod/clusters and hosts but zone could still be used. Added check that throws exception whenever a dedicated zone is being used to deploy vm but no affinity group is being used. Diffs - server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ebf2b0c Diff: https://reviews.apache.org/r/13324/diff/ Testing --- Dedicate zone to account/domain and do not use affinity group of type Explicit Dedication - VM deployment fails. Dedicate zone to appropriate account/domain and use affinity group of type Explicit Dedication - VM deployment passes. Build passes. Thanks, Saksham Srivastava
Re: Review Request 13324: CLOUDSTACK-4104: VM Creation should fail if a zone is dedicated to a domain and user of the same domain deploys vm without using affinity group Explicit Dedication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13324/#review24795 --- Commit 61c7aa7afea078239146c8957f49e8ea07ebd5db in branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=61c7aa7 ] CLOUDSTACK-4104: VM Creation should fail if a zone is dedicated to a domain and user of the same domain deploys vm without using affinity group Explicit Dedication. - ASF Subversion and Git Services On Aug. 6, 2013, 12:53 p.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13324/ --- (Updated Aug. 6, 2013, 12:53 p.m.) Review request for cloudstack and Devdeep Singh. Bugs: 4104 Repository: cloudstack-git Description --- To use dedicated resources one must specify the affinity group explicit dedication. If the affinity groups is not specified dedicated resources should not accessible. Currently there are checks for pod/clusters and hosts but zone could still be used. Added check that throws exception whenever a dedicated zone is being used to deploy vm but no affinity group is being used. Diffs - server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ebf2b0c Diff: https://reviews.apache.org/r/13324/diff/ Testing --- Dedicate zone to account/domain and do not use affinity group of type Explicit Dedication - VM deployment fails. Dedicate zone to appropriate account/domain and use affinity group of type Explicit Dedication - VM deployment passes. Build passes. Thanks, Saksham Srivastava
Re: Review Request 13324: CLOUDSTACK-4104: VM Creation should fail if a zone is dedicated to a domain and user of the same domain deploys vm without using affinity group Explicit Dedication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13324/#review24796 --- Ship it! Ship It! - Devdeep Singh On Aug. 6, 2013, 12:53 p.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13324/ --- (Updated Aug. 6, 2013, 12:53 p.m.) Review request for cloudstack and Devdeep Singh. Bugs: 4104 Repository: cloudstack-git Description --- To use dedicated resources one must specify the affinity group explicit dedication. If the affinity groups is not specified dedicated resources should not accessible. Currently there are checks for pod/clusters and hosts but zone could still be used. Added check that throws exception whenever a dedicated zone is being used to deploy vm but no affinity group is being used. Diffs - server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ebf2b0c Diff: https://reviews.apache.org/r/13324/diff/ Testing --- Dedicate zone to account/domain and do not use affinity group of type Explicit Dedication - VM deployment fails. Dedicate zone to appropriate account/domain and use affinity group of type Explicit Dedication - VM deployment passes. Build passes. Thanks, Saksham Srivastava
Review Request 13324: CLOUDSTACK-4104: VM Creation should fail if a zone is dedicated to a domain and user of the same domain deploys vm without using affinity group Explicit Dedication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13324/ --- Review request for cloudstack and Devdeep Singh. Bugs: 4104 Repository: cloudstack-git Description --- To use dedicated resources one must specify the affinity group explicit dedication. If the affinity groups is not specified dedicated resources should not accessible. Currently there are checks for pod/clusters and hosts but zone could still be used. Added check that throws exception whenever a dedicated zone is being used to deploy vm but no affinity group is being used. Diffs - server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ebf2b0c Diff: https://reviews.apache.org/r/13324/diff/ Testing --- Dedicate zone to account/domain and do not use affinity group of type Explicit Dedication - VM deployment fails. Dedicate zone to appropriate account/domain and use affinity group of type Explicit Dedication - VM deployment passes. Build passes. Thanks, Saksham Srivastava
Re: Review Request 13324: CLOUDSTACK-4104: VM Creation should fail if a zone is dedicated to a domain and user of the same domain deploys vm without using affinity group Explicit Dedication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13324/#review24723 --- Review 13324 failed the build test : FAILURE The url of build cloudstack-master-with-patch #115 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/115/ - Jenkins Cloudstack.org On Aug. 6, 2013, 12:53 p.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13324/ --- (Updated Aug. 6, 2013, 12:53 p.m.) Review request for cloudstack and Devdeep Singh. Bugs: 4104 Repository: cloudstack-git Description --- To use dedicated resources one must specify the affinity group explicit dedication. If the affinity groups is not specified dedicated resources should not accessible. Currently there are checks for pod/clusters and hosts but zone could still be used. Added check that throws exception whenever a dedicated zone is being used to deploy vm but no affinity group is being used. Diffs - server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ebf2b0c Diff: https://reviews.apache.org/r/13324/diff/ Testing --- Dedicate zone to account/domain and do not use affinity group of type Explicit Dedication - VM deployment fails. Dedicate zone to appropriate account/domain and use affinity group of type Explicit Dedication - VM deployment passes. Build passes. Thanks, Saksham Srivastava
