Re: Review Request 14647: CLOUDSTACK-3583: Management server stop is not removing the PID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14647/#review27294 --- Commit 770bfe43542fea0f25fda2fab026361e7c701a5b in branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=770bfe4 ] CLOUDSTACK-3583: Fix for Management server stop is not removing the PID - ASF Subversion and Git Services On Oct. 15, 2013, 10:05 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14647/ --- (Updated Oct. 15, 2013, 10:05 a.m.) Review request for cloudstack and Rajesh Battala. Bugs: CLOUDSTACK-3583 https://issues.apache.org/jira/browse/CLOUDSTACK-3583 Repository: cloudstack-git Description --- The current implementation of #service cloudstack-management stop kills the process. The PID file and the lock file both continue to exist until the the service is started again, which replaces them. When the service has been stopped this causes #service cloudstack-management status to return message like: cloudstack-management dead but pid file exists The pid file locates at /var/run/cloudstack-management.pid and lock file at /var/lock/subsys/cloudstack-management. Starting cloudstack-management will take care of them or you can manually clean up In the fix I am removing the PID and the lock file once the service has been successfully killed. Also when the service is cleanly stopped the return value is 3, added the same check in handle_pid_file(). Diffs - packaging/centos63/cloud-management.rc 35f31b2 Diff: https://reviews.apache.org/r/14647/diff/ Testing --- Tested locally : The status is now as #service cloudstack-management status cloudstack-management is stopped Thanks, Saksham Srivastava
Re: Review Request 14647: CLOUDSTACK-3583: Management server stop is not removing the PID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14647/#review27295 --- Commit 2a914cb3c4ff61c5d29733cac77dca67030b in branch refs/heads/4.2 from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2a9 ] CLOUDSTACK-3583: Fix for Management server stop is not removing the PID - ASF Subversion and Git Services On Oct. 15, 2013, 10:05 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14647/ --- (Updated Oct. 15, 2013, 10:05 a.m.) Review request for cloudstack and Rajesh Battala. Bugs: CLOUDSTACK-3583 https://issues.apache.org/jira/browse/CLOUDSTACK-3583 Repository: cloudstack-git Description --- The current implementation of #service cloudstack-management stop kills the process. The PID file and the lock file both continue to exist until the the service is started again, which replaces them. When the service has been stopped this causes #service cloudstack-management status to return message like: cloudstack-management dead but pid file exists The pid file locates at /var/run/cloudstack-management.pid and lock file at /var/lock/subsys/cloudstack-management. Starting cloudstack-management will take care of them or you can manually clean up In the fix I am removing the PID and the lock file once the service has been successfully killed. Also when the service is cleanly stopped the return value is 3, added the same check in handle_pid_file(). Diffs - packaging/centos63/cloud-management.rc 35f31b2 Diff: https://reviews.apache.org/r/14647/diff/ Testing --- Tested locally : The status is now as #service cloudstack-management status cloudstack-management is stopped Thanks, Saksham Srivastava
Re: Review Request 14647: CLOUDSTACK-3583: Management server stop is not removing the PID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14647/#review27238 --- Ship it! LGTM. - Rajesh Battala On Oct. 15, 2013, 10:05 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14647/ --- (Updated Oct. 15, 2013, 10:05 a.m.) Review request for cloudstack and Rajesh Battala. Bugs: CLOUDSTACK-3583 https://issues.apache.org/jira/browse/CLOUDSTACK-3583 Repository: cloudstack-git Description --- The current implementation of #service cloudstack-management stop kills the process. The PID file and the lock file both continue to exist until the the service is started again, which replaces them. When the service has been stopped this causes #service cloudstack-management status to return message like: cloudstack-management dead but pid file exists The pid file locates at /var/run/cloudstack-management.pid and lock file at /var/lock/subsys/cloudstack-management. Starting cloudstack-management will take care of them or you can manually clean up In the fix I am removing the PID and the lock file once the service has been successfully killed. Also when the service is cleanly stopped the return value is 3, added the same check in handle_pid_file(). Diffs - packaging/centos63/cloud-management.rc 35f31b2 Diff: https://reviews.apache.org/r/14647/diff/ Testing --- Tested locally : The status is now as #service cloudstack-management status cloudstack-management is stopped Thanks, Saksham Srivastava
Review Request 14647: CLOUDSTACK-3583: Management server stop is not removing the PID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14647/ --- Review request for cloudstack and Rajesh Battala. Bugs: CLOUDSTACK-3583 Repository: cloudstack-git Description --- The current implementation of #service cloudstack-management stop kills the process. The PID file and the lock file both continue to exist until the the service is started again, which replaces them. When the service has been stopped this causes #service cloudstack-management status to return message like: cloudstack-management dead but pid file exists The pid file locates at /var/run/cloudstack-management.pid and lock file at /var/lock/subsys/cloudstack-management. Starting cloudstack-management will take care of them or you can manually clean up In the fix I am removing the PID and the lock file once the service has been successfully killed. Also when the service is cleanly stopped the return value is 3, added the same check in handle_pid_file(). Diffs - packaging/centos63/cloud-management.rc 35f31b2 Diff: https://reviews.apache.org/r/14647/diff/ Testing --- Tested locally : The status is now as #service cloudstack-management status cloudstack-management is stopped Thanks, Saksham Srivastava
