Re: Review Request 15725: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (master)
> On Dec. 3, 2013, 11:46 a.m., Murali Reddy wrote: > > patch does not apply on master. Please resubmit. Also do you want to push > > the changes to 4.3 as well? Updated the diff so it will patch on master. This can be applied to 4.3 as well, though that would be the other patch I believe based on the state of that branch. Should i submit a separate patch for that branch? - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/#review29656 --- On Dec. 3, 2013, 4:50 p.m., David Grizzanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15725/ > --- > > (Updated Dec. 3, 2013, 4:50 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-5220 > https://issues.apache.org/jira/browse/CLOUDSTACK-5220 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-5022: NullPointerException when invalid zone is passed into > UsageEventUtils > > Updated UsageEventUtils code to not blow up when an invalid zone ID is passed > in. Now will still generate usage event but leaving out zone UUID. > > > Diffs > - > > engine/components-api/src/com/cloud/event/UsageEventUtils.java e71afb0 > > Diff: https://reviews.apache.org/r/15725/diff/ > > > Testing > --- > > built on master > > > Thanks, > > David Grizzanti > >
Re: Review Request 15725: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (master)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/#review29805 --- Ship it! commit 22422b9ddd3ea1566f66d971307235569bffb003 - Murali Reddy On Dec. 3, 2013, 4:50 p.m., David Grizzanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15725/ > --- > > (Updated Dec. 3, 2013, 4:50 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-5220 > https://issues.apache.org/jira/browse/CLOUDSTACK-5220 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-5022: NullPointerException when invalid zone is passed into > UsageEventUtils > > Updated UsageEventUtils code to not blow up when an invalid zone ID is passed > in. Now will still generate usage event but leaving out zone UUID. > > > Diffs > - > > engine/components-api/src/com/cloud/event/UsageEventUtils.java e71afb0 > > Diff: https://reviews.apache.org/r/15725/diff/ > > > Testing > --- > > built on master > > > Thanks, > > David Grizzanti > >
Re: Review Request 15725: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (master)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/#review29804 --- Commit 22422b9ddd3ea1566f66d971307235569bffb003 in branch refs/heads/master from David Grizzanti [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=22422b9 ] CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils - ASF Subversion and Git Services On Dec. 3, 2013, 4:50 p.m., David Grizzanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15725/ > --- > > (Updated Dec. 3, 2013, 4:50 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-5220 > https://issues.apache.org/jira/browse/CLOUDSTACK-5220 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-5022: NullPointerException when invalid zone is passed into > UsageEventUtils > > Updated UsageEventUtils code to not blow up when an invalid zone ID is passed > in. Now will still generate usage event but leaving out zone UUID. > > > Diffs > - > > engine/components-api/src/com/cloud/event/UsageEventUtils.java e71afb0 > > Diff: https://reviews.apache.org/r/15725/diff/ > > > Testing > --- > > built on master > > > Thanks, > > David Grizzanti > >
Re: Review Request 15725: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (master)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/ --- (Updated Dec. 3, 2013, 4:50 p.m.) Review request for cloudstack. Changes --- Updating patch so it will work on master Bugs: CLOUDSTACK-5220 https://issues.apache.org/jira/browse/CLOUDSTACK-5220 Repository: cloudstack-git Description --- CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils Updated UsageEventUtils code to not blow up when an invalid zone ID is passed in. Now will still generate usage event but leaving out zone UUID. Diffs (updated) - engine/components-api/src/com/cloud/event/UsageEventUtils.java e71afb0 Diff: https://reviews.apache.org/r/15725/diff/ Testing --- built on master Thanks, David Grizzanti
Re: Review Request 15725: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (master)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/#review29656 --- patch does not apply on master. Please resubmit. Also do you want to push the changes to 4.3 as well? - Murali Reddy On Nov. 20, 2013, 8:15 p.m., David Grizzanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15725/ > --- > > (Updated Nov. 20, 2013, 8:15 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-5220 > https://issues.apache.org/jira/browse/CLOUDSTACK-5220 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-5022: NullPointerException when invalid zone is passed into > UsageEventUtils > > Updated UsageEventUtils code to not blow up when an invalid zone ID is passed > in. Now will still generate usage event but leaving out zone UUID. > > > Diffs > - > > engine/components-api/src/com/cloud/event/UsageEventUtils.java a4be4dd > > Diff: https://reviews.apache.org/r/15725/diff/ > > > Testing > --- > > built on master > > > Thanks, > > David Grizzanti > >
Re: Review Request 15725: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (master)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/#review29654 --- Commit 03ba659ae7263ca4fdb7c1c0eaccbecdf45594e8 in branch refs/heads/4.2 from David Grizzanti [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=03ba659 ] CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils - ASF Subversion and Git Services On Nov. 20, 2013, 8:15 p.m., David Grizzanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15725/ > --- > > (Updated Nov. 20, 2013, 8:15 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-5220 > https://issues.apache.org/jira/browse/CLOUDSTACK-5220 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-5022: NullPointerException when invalid zone is passed into > UsageEventUtils > > Updated UsageEventUtils code to not blow up when an invalid zone ID is passed > in. Now will still generate usage event but leaving out zone UUID. > > > Diffs > - > > engine/components-api/src/com/cloud/event/UsageEventUtils.java a4be4dd > > Diff: https://reviews.apache.org/r/15725/diff/ > > > Testing > --- > > built on master > > > Thanks, > > David Grizzanti > >
Review Request 15725: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (master)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/ --- Review request for cloudstack. Bugs: CLOUDSTACK-5220 https://issues.apache.org/jira/browse/CLOUDSTACK-5220 Repository: cloudstack-git Description --- CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils Updated UsageEventUtils code to not blow up when an invalid zone ID is passed in. Now will still generate usage event but leaving out zone UUID. Diffs - engine/components-api/src/com/cloud/event/UsageEventUtils.java a4be4dd Diff: https://reviews.apache.org/r/15725/diff/ Testing --- built on master Thanks, David Grizzanti
