Re: Review Request 15761: CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures

2013-12-03 Thread Girish Shilamkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15761/#review29720
---

Ship it!


Committed to 4.2, 4.3 and master.

- Girish Shilamkar


On Nov. 21, 2013, 12:49 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15761/
> ---
> 
> (Updated Nov. 21, 2013, 12:49 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5230
> https://issues.apache.org/jira/browse/CLOUDSTACK-5230
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Removing dependency between the test cases.
> Some test cases were trying to delete/recover the instances which are already 
> deleted in other test cases.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_vm_life_cycle.py beb5b99 
> 
> Diff: https://reviews.apache.org/r/15761/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on VMware Advanced setup.
> 
> Log:
> 
> Ran the failing test cases with the dependent test case.
> 
> test_05_destroy_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test destroy an instance in VPC networks ... ok
> test_06_recover_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test recover an instance in VPC networks ... ok
> test_10_expunge_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test expunge an instance in VPC networks ... ok
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>



Re: Review Request 15761: CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures

2013-12-03 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15761/#review29719
---


Commit 8525dfd9310df409a7ddcb925e6b85299f6e4436 in branch refs/heads/4.2 from 
Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8525dfd ]

CLOUDSTACK-5230: Removing test cases' dependency on each other leading to 
failures


- ASF Subversion and Git Services


On Nov. 21, 2013, 12:49 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15761/
> ---
> 
> (Updated Nov. 21, 2013, 12:49 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5230
> https://issues.apache.org/jira/browse/CLOUDSTACK-5230
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Removing dependency between the test cases.
> Some test cases were trying to delete/recover the instances which are already 
> deleted in other test cases.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_vm_life_cycle.py beb5b99 
> 
> Diff: https://reviews.apache.org/r/15761/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on VMware Advanced setup.
> 
> Log:
> 
> Ran the failing test cases with the dependent test case.
> 
> test_05_destroy_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test destroy an instance in VPC networks ... ok
> test_06_recover_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test recover an instance in VPC networks ... ok
> test_10_expunge_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test expunge an instance in VPC networks ... ok
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>



Re: Review Request 15761: CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures

2013-12-03 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15761/#review29718
---


Commit 0aa17c4213adb5ec513151478c578015c6690050 in branch refs/heads/4.3 from 
Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0aa17c4 ]

CLOUDSTACK-5230: Removing test cases' dependency on each other leading to 
failures


- ASF Subversion and Git Services


On Nov. 21, 2013, 12:49 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15761/
> ---
> 
> (Updated Nov. 21, 2013, 12:49 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5230
> https://issues.apache.org/jira/browse/CLOUDSTACK-5230
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Removing dependency between the test cases.
> Some test cases were trying to delete/recover the instances which are already 
> deleted in other test cases.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_vm_life_cycle.py beb5b99 
> 
> Diff: https://reviews.apache.org/r/15761/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on VMware Advanced setup.
> 
> Log:
> 
> Ran the failing test cases with the dependent test case.
> 
> test_05_destroy_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test destroy an instance in VPC networks ... ok
> test_06_recover_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test recover an instance in VPC networks ... ok
> test_10_expunge_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test expunge an instance in VPC networks ... ok
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>



Re: Review Request 15761: CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures

2013-12-03 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15761/#review29717
---


Commit 4b5a0ca4c27f511e48c6cc094ce4bec731c0d8fb in branch refs/heads/master 
from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4b5a0ca ]

CLOUDSTACK-5230: Removing test cases' dependency on each other leading to 
failures


- ASF Subversion and Git Services


On Nov. 21, 2013, 12:49 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15761/
> ---
> 
> (Updated Nov. 21, 2013, 12:49 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5230
> https://issues.apache.org/jira/browse/CLOUDSTACK-5230
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Removing dependency between the test cases.
> Some test cases were trying to delete/recover the instances which are already 
> deleted in other test cases.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_vm_life_cycle.py beb5b99 
> 
> Diff: https://reviews.apache.org/r/15761/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on VMware Advanced setup.
> 
> Log:
> 
> Ran the failing test cases with the dependent test case.
> 
> test_05_destroy_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test destroy an instance in VPC networks ... ok
> test_06_recover_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test recover an instance in VPC networks ... ok
> test_10_expunge_instance_in_network 
> (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
> Test expunge an instance in VPC networks ... ok
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>



Review Request 15761: CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures

2013-11-21 Thread Ashutosh Kelkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15761/
---

Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-5230
https://issues.apache.org/jira/browse/CLOUDSTACK-5230


Repository: cloudstack-git


Description
---

Removing dependency between the test cases.
Some test cases were trying to delete/recover the instances which are already 
deleted in other test cases.


Diffs
-

  test/integration/component/test_vpc_vm_life_cycle.py beb5b99 

Diff: https://reviews.apache.org/r/15761/diff/


Testing
---

Tested locally on VMware Advanced setup.

Log:

Ran the failing test cases with the dependent test case.

test_05_destroy_instance_in_network 
(test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
Test destroy an instance in VPC networks ... ok
test_06_recover_instance_in_network 
(test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
Test recover an instance in VPC networks ... ok
test_10_expunge_instance_in_network 
(test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC)
Test expunge an instance in VPC networks ... ok


Thanks,

Ashutosh Kelkar