Re: Review Request 15942: CLOUDSTACK-5333: Code changes related to snapshots listing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/#review29711 --- Commit 11231d6b12770c98d32e533d94ec63183cc19eda in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=11231d6 ] CLOUDSTACK-5333: Code changes related to snapshots listing Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Dec. 2, 2013, 2:57 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15942/ > --- > > (Updated Dec. 2, 2013, 2:57 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5333 > https://issues.apache.org/jira/browse/CLOUDSTACK-5333 > > > Repository: cloudstack-git > > > Description > --- > > test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project > was failing with error "Check Snapshot state is Running or not". > The snapshot state does not really matter here, as we are checking the > limits. Instead of checking the snapshot state from all the possible options, > just list the snapshots under the project and check if exactly one snapshot > exists. > > > Diffs > - > > test/integration/component/test_project_limits.py c497311 > > Diff: https://reviews.apache.org/r/15942/diff/ > > > Testing > --- > > Tested locally on XenServer advanced setup. > > Log: > test_maxAccountNetworks (test_project_limits_fixed.TestMaxProjectNetworks) > Test Limit number of guest account specific networks ... skipped 'skip' > test_01_project_limits (test_project_limits_fixed.TestProjectLimits) > Test project limits for domain admin ... skipped 'skip' > test_02_project_limits_normal_user > (test_project_limits_fixed.TestProjectLimits) > Test project limits for normal user ... skipped 'skip' > test_03_vm_per_project (test_project_limits_fixed.TestResourceLimitsProject) > Test VM limit per project ... skipped 'Skip' > test_04_publicip_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Public IP limit per project ... skipped 'Skip' > test_05_snapshots_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Snapshot limit per project ... ok > test_06_volumes_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Volumes limit per project ... skipped 'Skip' > test_07_templates_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Templates limit per project ... skipped 'Skip' > > -- > Ran 8 tests in 360.690s > > OK (skipped=7) > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15942: CLOUDSTACK-5333: Code changes related to snapshots listing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/#review29710 --- Commit e5047141a9fd305be186fc303f7cfdfc68a4bfd3 in branch refs/heads/4.3 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e504714 ] CLOUDSTACK-5333: Code changes related to snapshots listing Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Dec. 2, 2013, 2:57 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15942/ > --- > > (Updated Dec. 2, 2013, 2:57 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5333 > https://issues.apache.org/jira/browse/CLOUDSTACK-5333 > > > Repository: cloudstack-git > > > Description > --- > > test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project > was failing with error "Check Snapshot state is Running or not". > The snapshot state does not really matter here, as we are checking the > limits. Instead of checking the snapshot state from all the possible options, > just list the snapshots under the project and check if exactly one snapshot > exists. > > > Diffs > - > > test/integration/component/test_project_limits.py c497311 > > Diff: https://reviews.apache.org/r/15942/diff/ > > > Testing > --- > > Tested locally on XenServer advanced setup. > > Log: > test_maxAccountNetworks (test_project_limits_fixed.TestMaxProjectNetworks) > Test Limit number of guest account specific networks ... skipped 'skip' > test_01_project_limits (test_project_limits_fixed.TestProjectLimits) > Test project limits for domain admin ... skipped 'skip' > test_02_project_limits_normal_user > (test_project_limits_fixed.TestProjectLimits) > Test project limits for normal user ... skipped 'skip' > test_03_vm_per_project (test_project_limits_fixed.TestResourceLimitsProject) > Test VM limit per project ... skipped 'Skip' > test_04_publicip_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Public IP limit per project ... skipped 'Skip' > test_05_snapshots_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Snapshot limit per project ... ok > test_06_volumes_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Volumes limit per project ... skipped 'Skip' > test_07_templates_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Templates limit per project ... skipped 'Skip' > > -- > Ran 8 tests in 360.690s > > OK (skipped=7) > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15942: CLOUDSTACK-5333: Code changes related to snapshots listing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/#review29709 --- Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar On Dec. 2, 2013, 2:57 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15942/ > --- > > (Updated Dec. 2, 2013, 2:57 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5333 > https://issues.apache.org/jira/browse/CLOUDSTACK-5333 > > > Repository: cloudstack-git > > > Description > --- > > test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project > was failing with error "Check Snapshot state is Running or not". > The snapshot state does not really matter here, as we are checking the > limits. Instead of checking the snapshot state from all the possible options, > just list the snapshots under the project and check if exactly one snapshot > exists. > > > Diffs > - > > test/integration/component/test_project_limits.py c497311 > > Diff: https://reviews.apache.org/r/15942/diff/ > > > Testing > --- > > Tested locally on XenServer advanced setup. > > Log: > test_maxAccountNetworks (test_project_limits_fixed.TestMaxProjectNetworks) > Test Limit number of guest account specific networks ... skipped 'skip' > test_01_project_limits (test_project_limits_fixed.TestProjectLimits) > Test project limits for domain admin ... skipped 'skip' > test_02_project_limits_normal_user > (test_project_limits_fixed.TestProjectLimits) > Test project limits for normal user ... skipped 'skip' > test_03_vm_per_project (test_project_limits_fixed.TestResourceLimitsProject) > Test VM limit per project ... skipped 'Skip' > test_04_publicip_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Public IP limit per project ... skipped 'Skip' > test_05_snapshots_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Snapshot limit per project ... ok > test_06_volumes_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Volumes limit per project ... skipped 'Skip' > test_07_templates_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Templates limit per project ... skipped 'Skip' > > -- > Ran 8 tests in 360.690s > > OK (skipped=7) > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15942: CLOUDSTACK-5333: Code changes related to snapshots listing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/#review29708 --- Commit 6b955958c6165f69de8dbaf6310868d8f5c2a3b1 in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6b95595 ] CLOUDSTACK-5333: Code changes related to snapshots listing Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Dec. 2, 2013, 2:57 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15942/ > --- > > (Updated Dec. 2, 2013, 2:57 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5333 > https://issues.apache.org/jira/browse/CLOUDSTACK-5333 > > > Repository: cloudstack-git > > > Description > --- > > test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project > was failing with error "Check Snapshot state is Running or not". > The snapshot state does not really matter here, as we are checking the > limits. Instead of checking the snapshot state from all the possible options, > just list the snapshots under the project and check if exactly one snapshot > exists. > > > Diffs > - > > test/integration/component/test_project_limits.py c497311 > > Diff: https://reviews.apache.org/r/15942/diff/ > > > Testing > --- > > Tested locally on XenServer advanced setup. > > Log: > test_maxAccountNetworks (test_project_limits_fixed.TestMaxProjectNetworks) > Test Limit number of guest account specific networks ... skipped 'skip' > test_01_project_limits (test_project_limits_fixed.TestProjectLimits) > Test project limits for domain admin ... skipped 'skip' > test_02_project_limits_normal_user > (test_project_limits_fixed.TestProjectLimits) > Test project limits for normal user ... skipped 'skip' > test_03_vm_per_project (test_project_limits_fixed.TestResourceLimitsProject) > Test VM limit per project ... skipped 'Skip' > test_04_publicip_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Public IP limit per project ... skipped 'Skip' > test_05_snapshots_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Snapshot limit per project ... ok > test_06_volumes_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Volumes limit per project ... skipped 'Skip' > test_07_templates_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Templates limit per project ... skipped 'Skip' > > -- > Ran 8 tests in 360.690s > > OK (skipped=7) > > > Thanks, > > Gaurav Aradhye > >
Review Request 15942: CLOUDSTACK-5333: Code changes related to snapshots listing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/ --- Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5333 https://issues.apache.org/jira/browse/CLOUDSTACK-5333 Repository: cloudstack-git Description --- test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project was failing with error "Check Snapshot state is Running or not". The snapshot state does not really matter here, as we are checking the limits. Instead of checking the snapshot state from all the possible options, just list the snapshots under the project and check if exactly one snapshot exists. Diffs - test/integration/component/test_project_limits.py c497311 Diff: https://reviews.apache.org/r/15942/diff/ Testing --- Tested locally on XenServer advanced setup. Log: test_maxAccountNetworks (test_project_limits_fixed.TestMaxProjectNetworks) Test Limit number of guest account specific networks ... skipped 'skip' test_01_project_limits (test_project_limits_fixed.TestProjectLimits) Test project limits for domain admin ... skipped 'skip' test_02_project_limits_normal_user (test_project_limits_fixed.TestProjectLimits) Test project limits for normal user ... skipped 'skip' test_03_vm_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test VM limit per project ... skipped 'Skip' test_04_publicip_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Public IP limit per project ... skipped 'Skip' test_05_snapshots_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Snapshot limit per project ... ok test_06_volumes_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Volumes limit per project ... skipped 'Skip' test_07_templates_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Templates limit per project ... skipped 'Skip' -- Ran 8 tests in 360.690s OK (skipped=7) Thanks, Gaurav Aradhye
