Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5638 https://issues.apache.org/jira/browse/CLOUDSTACK-5638 Repository: cloudstack-git Description --- test_02_NetworkGarbageCollection was failing on XenServer advances setup while checking the router state. Sometimes, it needs more time for router to come up in running state, so modified code to check the router state after definite time intervals, it will fail after timeout (180 Seconds for now). Diffs - test/integration/component/test_routers.py 5f1ebc6 Diff: https://reviews.apache.org/r/16467/diff/ Testing --- Tested locally: Log: Test advanced zone router services ... SKIP: Skip Test network garbage collection ... ok Test router start on VM deploy ... SKIP: Skip Test router stop create Firewall rule ... SKIP: Skip Test router stop create Load balancing ... SKIP: Skip Test router stop create port forwarding ... SKIP: Skip -- Ran 6 tests in 799.271s OK (SKIP=5) Thanks, Gaurav Aradhye
Re: Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/#review30900 --- Commit ec8610f7566b74ea36399db020007fb878d013eb in branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ec8610f ] CLOUDSTACK-5638: Fixed code to check router state - ASF Subversion and Git Services On Dec. 26, 2013, 2:06 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/ --- (Updated Dec. 26, 2013, 2:06 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5638 https://issues.apache.org/jira/browse/CLOUDSTACK-5638 Repository: cloudstack-git Description --- test_02_NetworkGarbageCollection was failing on XenServer advances setup while checking the router state. Sometimes, it needs more time for router to come up in running state, so modified code to check the router state after definite time intervals, it will fail after timeout (180 Seconds for now). Diffs - test/integration/component/test_routers.py 5f1ebc6 Diff: https://reviews.apache.org/r/16467/diff/ Testing --- Tested locally: Log: Test advanced zone router services ... SKIP: Skip Test network garbage collection ... ok Test router start on VM deploy ... SKIP: Skip Test router stop create Firewall rule ... SKIP: Skip Test router stop create Load balancing ... SKIP: Skip Test router stop create port forwarding ... SKIP: Skip -- Ran 6 tests in 799.271s OK (SKIP=5) Thanks, Gaurav Aradhye
Re: Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/#review30902 --- Commit 53f0d35517ff717950120d2cb4206d50fbed13de in branch refs/heads/4.3 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53f0d35 ] CLOUDSTACK-5638: Fixed code to check router state - ASF Subversion and Git Services On Dec. 26, 2013, 2:06 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/ --- (Updated Dec. 26, 2013, 2:06 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5638 https://issues.apache.org/jira/browse/CLOUDSTACK-5638 Repository: cloudstack-git Description --- test_02_NetworkGarbageCollection was failing on XenServer advances setup while checking the router state. Sometimes, it needs more time for router to come up in running state, so modified code to check the router state after definite time intervals, it will fail after timeout (180 Seconds for now). Diffs - test/integration/component/test_routers.py 5f1ebc6 Diff: https://reviews.apache.org/r/16467/diff/ Testing --- Tested locally: Log: Test advanced zone router services ... SKIP: Skip Test network garbage collection ... ok Test router start on VM deploy ... SKIP: Skip Test router stop create Firewall rule ... SKIP: Skip Test router stop create Load balancing ... SKIP: Skip Test router stop create port forwarding ... SKIP: Skip -- Ran 6 tests in 799.271s OK (SKIP=5) Thanks, Gaurav Aradhye
Re: Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/#review30901 --- Ship it! Committed to 4.3 and master. - Girish Shilamkar On Dec. 26, 2013, 2:06 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/ --- (Updated Dec. 26, 2013, 2:06 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5638 https://issues.apache.org/jira/browse/CLOUDSTACK-5638 Repository: cloudstack-git Description --- test_02_NetworkGarbageCollection was failing on XenServer advances setup while checking the router state. Sometimes, it needs more time for router to come up in running state, so modified code to check the router state after definite time intervals, it will fail after timeout (180 Seconds for now). Diffs - test/integration/component/test_routers.py 5f1ebc6 Diff: https://reviews.apache.org/r/16467/diff/ Testing --- Tested locally: Log: Test advanced zone router services ... SKIP: Skip Test network garbage collection ... ok Test router start on VM deploy ... SKIP: Skip Test router stop create Firewall rule ... SKIP: Skip Test router stop create Load balancing ... SKIP: Skip Test router stop create port forwarding ... SKIP: Skip -- Ran 6 tests in 799.271s OK (SKIP=5) Thanks, Gaurav Aradhye
